From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: imre.deak@intel.com
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 2/2] i915/treewide: Replace gem_mmap__gtt() by gem_mmap__device_coherent()
Date: Wed, 15 Jan 2020 09:03:30 -0800 [thread overview]
Message-ID: <87sgkgwt25.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20200115162740.GE18295@ideak-desk.fi.intel.com>
On Wed, 15 Jan 2020 08:27:40 -0800, Imre Deak wrote:
>
> Hi,
>
> On Fri, Jan 10, 2020 at 09:36:53PM -0800, Ashutosh Dixit wrote:
> > As another step towards supporting GPU's without mappable aperture,
> > globally replace gem_mmap__gtt() by gem_mmap__device_coherent(). This
> > will not affect GPU's with a mappable aperture but will fix tests on
> > GPU's without a mappable aperture through the use of WC mapping,
> > unless those tests test actual features available via the aperture.
>
> igt_draw_rect() depends on detiling via the aperture. I'd suggest
> converting first only the places that don't depend on this and follow-up
> with the rest once we have a way to do the detiling in another way.
Patch 1/2 was supposed to take care of this so that at least platforms with
mappable aperture don't break. Platforms without mappable aperture anyway
need to figure out a different way, but I agree, you are probably saying
just don't touch them in this patch.
In any case we are not moving forward with this approach at this point
because of Chris' comments.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-01-15 17:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-11 5:36 [igt-dev] [PATCH i-g-t 1/2] lib/i915/gem_mman: Prioritize GTT mappings over WC Ashutosh Dixit
2020-01-11 5:36 ` [igt-dev] [PATCH i-g-t 2/2] i915/treewide: Replace gem_mmap__gtt() by gem_mmap__device_coherent() Ashutosh Dixit
2020-01-11 8:44 ` Chris Wilson
2020-01-12 2:57 ` Dixit, Ashutosh
2020-01-12 10:06 ` Chris Wilson
2020-01-15 16:27 ` Imre Deak
2020-01-15 17:03 ` Dixit, Ashutosh [this message]
2020-01-11 6:15 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib/i915/gem_mman: Prioritize GTT mappings over WC Patchwork
2020-01-11 8:40 ` [igt-dev] [PATCH i-g-t 1/2] " Chris Wilson
2020-01-14 22:36 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgkgwt25.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=imre.deak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.