From mboxrd@z Thu Jan 1 00:00:00 1970 From: Francisco Jerez Subject: Re: [PATCH] Revert "drm/i915: disable set/get_tiling ioctl on gen12+" Date: Thu, 21 Nov 2019 11:19:03 -0800 Message-ID: <87sgmhvxzs.fsf@riseup.net> References: <20191121181101.401609-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0582125260==" Return-path: Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129]) by gabe.freedesktop.org (Postfix) with ESMTPS id 549206E197 for ; Thu, 21 Nov 2019 19:18:31 +0000 (UTC) In-Reply-To: <20191121181101.401609-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0582125260== Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Chris Wilson writes: > Restore the DRI2/DRI3 uABI backchannel that was removed by ab016914984e > ("drm/i915: disable set/get_tiling ioctl on gen12+") before the ABI > change was agreed upon. > > Fixes: ab016914984e ("drm/i915: disable set/get_tiling ioctl on gen12+") > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen Thanks. This makes things easier for userspace until the modifiers-based alternative to this is in better shape. Reviewed-by: Francisco Jerez > --- > drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_tiling.c b/drivers/gpu/drm= /i915/gem/i915_gem_tiling.c > index 1fa592d82af5..39f3bd5defd6 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_tiling.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_tiling.c > @@ -317,14 +317,10 @@ int > i915_gem_set_tiling_ioctl(struct drm_device *dev, void *data, > struct drm_file *file) > { > - struct drm_i915_private *dev_priv =3D to_i915(dev); > struct drm_i915_gem_set_tiling *args =3D data; > struct drm_i915_gem_object *obj; > int err; >=20=20 > - if (!dev_priv->ggtt.num_fences) > - return -EOPNOTSUPP; > - > obj =3D i915_gem_object_lookup(file, args->handle); > if (!obj) > return -ENOENT; > @@ -405,9 +401,6 @@ i915_gem_get_tiling_ioctl(struct drm_device *dev, voi= d *data, > struct drm_i915_gem_object *obj; > int err =3D -ENOENT; >=20=20 > - if (!dev_priv->ggtt.num_fences) > - return -EOPNOTSUPP; > - > rcu_read_lock(); > obj =3D i915_gem_object_lookup_rcu(file, args->handle); > if (obj) { > --=20 > 2.24.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEAREIAB0WIQST8OekYz69PM20/4aDmTidfVK/WwUCXdbjJwAKCRCDmTidfVK/ WynqAP9sGIQW5hcKrlctPJIUXNyrtKLESVFK/GpXlLLcHWH84QEAgZHtrLe4mCzs PWGVtPZ69YatFx2NS20zFcLCIpugcPA= =8wS9 -----END PGP SIGNATURE----- --==-=-=-- --===============0582125260== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 --===============0582125260==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38373C432C0 for ; Thu, 21 Nov 2019 19:18:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 155282068E for ; Thu, 21 Nov 2019 19:18:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 155282068E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=riseup.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 05DDA6E1B5; Thu, 21 Nov 2019 19:18:33 +0000 (UTC) Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129]) by gabe.freedesktop.org (Postfix) with ESMTPS id 549206E197 for ; Thu, 21 Nov 2019 19:18:31 +0000 (UTC) Received: from bell.riseup.net (bell-pn.riseup.net [10.0.1.178]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 47Jq926vlPzDrN1; Thu, 21 Nov 2019 11:18:30 -0800 (PST) X-Riseup-User-ID: 7431C1FB9B43F02D496AF38F59FD11F761F1268789D6E719B0C42462A38103AC Received: from [127.0.0.1] (localhost [127.0.0.1]) by bell.riseup.net (Postfix) with ESMTPSA id 47Jq925SmrzJsqj; Thu, 21 Nov 2019 11:18:30 -0800 (PST) From: Francisco Jerez To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <20191121181101.401609-1-chris@chris-wilson.co.uk> References: <20191121181101.401609-1-chris@chris-wilson.co.uk> Date: Thu, 21 Nov 2019 11:19:03 -0800 Message-ID: <87sgmhvxzs.fsf@riseup.net> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1574363911; bh=AQKo3cn1sWkRKoQm/R9Y5DeJehb4hiQHYt09BIh54ZA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=H50Gd+N20nOUnEdl3TACTA1vvfKb5JF/kJKbc0Pl5uCcVyyNL4Q0/BiqKfChVZ9Xa T3H/CtL81c2y9PDrfiSrKUCglLuVKxZyQVSkvz588lqJh+Cx9PXK8z5c/CxdOyHegy Wy1UK45idb1BuxlmD287TmCb3jMKL8sBLUabocbk= Subject: Re: [Intel-gfx] [PATCH] Revert "drm/i915: disable set/get_tiling ioctl on gen12+" X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0582125260==" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191121191903.4idw8ibtv1QLsEp2rlCstXKVBQeKE17ngSLLj_6RE00@z> --===============0582125260== Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Chris Wilson writes: > Restore the DRI2/DRI3 uABI backchannel that was removed by ab016914984e > ("drm/i915: disable set/get_tiling ioctl on gen12+") before the ABI > change was agreed upon. > > Fixes: ab016914984e ("drm/i915: disable set/get_tiling ioctl on gen12+") > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen Thanks. This makes things easier for userspace until the modifiers-based alternative to this is in better shape. Reviewed-by: Francisco Jerez > --- > drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_tiling.c b/drivers/gpu/drm= /i915/gem/i915_gem_tiling.c > index 1fa592d82af5..39f3bd5defd6 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_tiling.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_tiling.c > @@ -317,14 +317,10 @@ int > i915_gem_set_tiling_ioctl(struct drm_device *dev, void *data, > struct drm_file *file) > { > - struct drm_i915_private *dev_priv =3D to_i915(dev); > struct drm_i915_gem_set_tiling *args =3D data; > struct drm_i915_gem_object *obj; > int err; >=20=20 > - if (!dev_priv->ggtt.num_fences) > - return -EOPNOTSUPP; > - > obj =3D i915_gem_object_lookup(file, args->handle); > if (!obj) > return -ENOENT; > @@ -405,9 +401,6 @@ i915_gem_get_tiling_ioctl(struct drm_device *dev, voi= d *data, > struct drm_i915_gem_object *obj; > int err =3D -ENOENT; >=20=20 > - if (!dev_priv->ggtt.num_fences) > - return -EOPNOTSUPP; > - > rcu_read_lock(); > obj =3D i915_gem_object_lookup_rcu(file, args->handle); > if (obj) { > --=20 > 2.24.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEAREIAB0WIQST8OekYz69PM20/4aDmTidfVK/WwUCXdbjJwAKCRCDmTidfVK/ WynqAP9sGIQW5hcKrlctPJIUXNyrtKLESVFK/GpXlLLcHWH84QEAgZHtrLe4mCzs PWGVtPZ69YatFx2NS20zFcLCIpugcPA= =8wS9 -----END PGP SIGNATURE----- --==-=-=-- --===============0582125260== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 --===============0582125260==--