All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/tgl: Disable read-only support
Date: Wed, 11 Sep 2019 16:08:10 +0300	[thread overview]
Message-ID: <87sgp3rnet.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20190911125717.28997-1-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> The same read-only affliction as befell Icelake is affecting Tigerlake.
> Disable the read-only support as cleary it was not fixed.
>
> Testcase: igt/i915_selftests/live_gem_context
> References: 3936867dbc1e ("drm/i915: Disable read only ppgtt support for gen11")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/i915_gem_gtt.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index e4f66bfe74c2..a09a9b62afbe 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -1486,8 +1486,10 @@ static struct i915_ppgtt *gen8_ppgtt_create(struct drm_i915_private *i915)
>  	 *
>  	 * Gen11 has HSDES#:1807136187 unresolved. Disable ro support
>  	 * for now.
> +	 *
> +	 * Gen12 has inherited the same read-only fault issue from gen11.
>  	 */
> -	ppgtt->vm.has_read_only = INTEL_GEN(i915) != 11;
> +	ppgtt->vm.has_read_only = !IS_GEN_RANGE(i915, 11, 12);
>  
>  	/* There are only few exceptions for gen >=6. chv and bxt.
>  	 * And we are not sure about the latter so play safe for now.
> -- 
> 2.23.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-09-11 13:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11 12:57 [PATCH] drm/i915/tgl: Disable read-only support Chris Wilson
2019-09-11 13:08 ` Mika Kuoppala [this message]
2019-09-11 15:11   ` Chris Wilson
2019-09-11 13:38 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-09-11 14:11 ` ✓ Fi.CI.BAT: success " Patchwork
2019-09-11 23:11 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgp3rnet.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.