From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH v4 2/9] drm/shmem: Put pages independent of a SG table being set Date: Thu, 08 Aug 2019 16:15:34 -0700 Message-ID: <87sgqbnt9l.fsf@anholt.net> References: <20190808222200.13176-1-robh@kernel.org> <20190808222200.13176-3-robh@kernel.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1625751825==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id B96346ECDB for ; Thu, 8 Aug 2019 23:15:37 +0000 (UTC) In-Reply-To: <20190808222200.13176-3-robh@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring , dri-devel@lists.freedesktop.org Cc: Tomeu Vizoso , Maxime Ripard , Robin Murphy , Steven Price , David Airlie , Boris Brezillon , Alyssa Rosenzweig , Sean Paul List-Id: dri-devel@lists.freedesktop.org --===============1625751825== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Rob Herring writes: > If a driver does its own management of pages, the shmem helper object's > pages array could be allocated when a SG table is not. There's not > really any good reason to tie putting pages with having a SG table when > freeing the object, so just put pages if the pages array is populated. > > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > Cc: Eric Anholt > Reviewed-by: Steven Price > Acked-by: Alyssa Rosenzweig > Signed-off-by: Rob Herring Patch 1, 2: Reviewed-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAl1MrRYACgkQtdYpNtH8 nujCqQ//dJjqUu80g1XuGf842aG+VIxKp1QxZc19aTMeqyTPTeVr/Ry/jdTyE4z4 /O5nhO7s8xITjI7pMEObVpMX+CWftOc0bVsDdWzhDSbxv8cSiNP4sfjGleME3UoH IYaG1rWpvlCGNsXskBxWaCHxjrsUAbX4vbBQQHAR+41haM2zKDnW/OJzNCljhNMj aIol+9elGT0RHfBb8W3+/A0DZSzC4LTB50sMitfA3wVIdQ88GfXwSjeQEJGMfV+y W23Mwfs286pwoaLXg5PdxggHIsUjdkltLW+4ZmBch/iQ2YN4DJ1eoPnNbODldZNO c2FR8cendUr+6pQ1qPg4LUeFelf362bhUlgzX+/yaFxz4bxdpclCHEmOS2abWdAq GP+EHk022DysVorXYozLiDmaOGG0mNKq6sbcnQZne6jAP4pd6vlPRZHjnqkQOyYp 5nUZaADsB2wFpsm1YBZ5EGJ6xrqa7AGAOcE0TeOA9ePKx4tBvgqNIacwva55P3yZ mW+st3CgJbv3u3pLx5FRLeBXi+220lQzm+7137ZjRU4JrjwDemJ/mB1Z4YG7W5Pn fYzMjXWcdSf1ONcW1tobgYSReTCXaPTDRbkAixHKDLalJC9qHegbv+arux8Fq+sv AAoEI/7VOetRIZcPFqUztTQCtsa3wTsYROqS5aMZiuqqHDGeNro= =JGeJ -----END PGP SIGNATURE----- --=-=-=-- --===============1625751825== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1625751825==--