Re: [PATCH V2] ath11k: Fix Rx signal strength reporting

From: Kalle Valo <kvalo@codeaurora.org>
To: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
Cc: ath11k@lists.infradead.org
Subject: Re: [PATCH V2] ath11k: Fix Rx signal strength reporting
Date: Thu, 20 Jun 2019 16:36:08 +0300	[thread overview]
Message-ID: <87sgs44bw7.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <8736k8b50h.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Mon, 17 Jun 2019 18:33:50 +0300")

Kalle Valo <kvalo@codeaurora.org> writes:

> Kalle Valo <kvalo@codeaurora.org> writes:
>
>> Vasanthakumar Thiagarajan <vthiagar@codeaurora.org> wrote:
>>
>>> Since rssi in not reported in MSDU_START tlv, current signal strength
>>> reporting is always wrong. Correct rssi is reported in PPDU_END tlv.
>>> Enable PPDU_END, PPDU_END_STATUS_DONE and MPDU_START tlv reporting in
>>> monitor status by default. Pass the sta's Rx signal strength to mac80211
>>> in sta_statistics() ops. This patch also makes sure the default rx filter
>>> is always enabled whenever there is a call to reset the filter (from
>>> extd_rx_stats debugfs and config_filter path). Since some of the rx_stats
>>> are enabled by default, make memory allocation of arsta->rx_stats unconditional.
>>> 
>>> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
>>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>>
>> This had a conflict and 3-way merge didn't work as the SHA ids were not valid.
>> Please always try to use ath11k-bringup branch as the baseline (and no extra
>> patches), that helps my conflict resolution a lot.
>>
>> Applied patch drivers/net/wireless/ath/ath11k/core.h cleanly.
>> Applied patch drivers/net/wireless/ath/ath11k/debug.c cleanly.
>> Applied patch drivers/net/wireless/ath/ath11k/dp_rx.c cleanly.
>> Applying patch drivers/net/wireless/ath/ath11k/dp_tx.c with 1 reject...
>> Rejected hunk #1.
>> Applied patch drivers/net/wireless/ath/ath11k/hal_rx.c cleanly.
>> Applied patch drivers/net/wireless/ath/ath11k/mac.c cleanly.
>> Applied patch drivers/net/wireless/ath/ath11k/mac.h cleanly.
>> Patch failed at 0001 ath11k: Fix Rx signal strength reporting
>>
>> I fixed the conflict in dp_tx.c, that was pretty easy. Also I fixed one
>> compilation error due to dp function renames. Also I removed
>> ath11k_dp_rx_h_msdu_start_rssi() as GCC warned that it's unused.
>
> Oops, I forgot to add the link to the pending branch:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending-ath11k&id=b36e8ecd8b4e7000a2844db022601890e0b1b39d
>
> Please check carefully my changes.
>
> Oh, and I also added mac_ prefix to mon_status_filter_default.

Actually, I changed the prefix ath11k_mac_ to make the style consistent.

-- 
Kalle Valo

_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k