From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH v3 3/3] drm/panfrost: Add initial panfrost driver
Date: Tue, 09 Apr 2019 14:27:49 -0700
Message-ID: <87sguqdg2y.fsf@anholt.net>
References: <20190409205427.6943-1-robh@kernel.org> <20190409205427.6943-4-robh@kernel.org> <87v9zmdg66.fsf@anholt.net>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <87v9zmdg66.fsf@anholt.net>
Sender: linux-kernel-owner@vger.kernel.org
To: Rob Herring <robh@kernel.org>, dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <maxime.ripard@bootlin.com>, Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Lyude Paul <lyude@redhat.com>, "Marty E . Plummer" <hanetzer@startmail.com>, Tomeu Vizoso <tomeu.vizoso@collabora.com>, Neil Armstrong <narmstrong@baylibre.com>, Alyssa Rosenzweig <alyssa@rosenzweig.io>
List-Id: dri-devel@lists.freedesktop.org

--=-=-=
Content-Type: text/plain

Eric Anholt <eric@anholt.net> writes:

> [ Unknown signature status ]
> Rob Herring <robh@kernel.org> writes:
>
>> This adds the initial driver for panfrost which supports Arm Mali
>> Midgard and Bifrost family of GPUs. Currently, only the T860 and
>> T760 Midgard GPUs have been tested.
>
>> +static int panfrost_ioctl_get_bo_offset(struct drm_device *dev, void *data,
>> +			    struct drm_file *file_priv)
>> +{
>> +	struct drm_panfrost_get_bo_offset *args = data;
>> +	struct drm_gem_object *gem_obj;
>> +	struct panfrost_gem_object *bo;
>> +
>
> Missing check for pad == 0.  With that fixed,
>
> Reviewed-by: Eric Anholt <eric@anholt.net>

I suppose you could also drop both flags and pad from uapi, since both
of them must be 0 filled and you could just add a new flags at the end
of the create struct if you ever need one.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlytDlUACgkQtdYpNtH8
nujTvQ/8DLl9gw2KT5rPuNbZlc1c0j7l4nxEJVuTaGb8y+CDcmeAthE+6yavpYOz
sOYfejrD3xh/I3dW0hagyx3N2roqqT6U4n6AAQoG3g79pnlOY/1KQsJoyOU1InEl
KNxXe51S4oeCL09w/Kd4ywW8sxbxofLZAlkzySQW+ClkAv0fPApu/fTrukjlHXER
lxX0he8uJPmaetHkHoaT5JUNoLth0vQ4iwOWLu6L37YzeWtGU2AmJMMDmPdPuks5
ot6Yt0kwCXGFtPDQBarR1TTZvA2vBOuwEgDVnCuea2e406pmkcURJOlWdCfCIN93
LKURY77dQAuXTsL8XwBeBb/ZPcB2fe3w2Htwygb++R4SFAKdWSGCZ4xtZSHBr+O6
Pr/hhUeFBZSF7/LK9d6U1vvAAf85VE4GQi2a0rNEKRkYuslEk36cs138DCu2Sx4k
oBd7ONwV6Lt9l2J35vcIAjIY/H3/Yzz0ZGHMI4CYwNXwZGJcQd0GInwltNgEWKp3
ROmVgQzXy4CChxfykBj9laABo8GDPXfc5QKBsmsYsaaSwV24w6OY0ln4Mx8RP3Zl
mUhHxIA0Bmr7yHly+V5Ac+Q0N2DPck5cOqI/XhYTS7TnQkLlmpCYsjLcDjMK0gGI
BWieLpmbRFYcCwLFPEWyBXGFXIE1eIZWe2fJMzb6Lep5D2hFT1U=
=16Ej
-----END PGP SIGNATURE-----
--=-=-=--