From: Markus Armbruster <armbru@redhat.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: pbonzini@redhat.com, Wei Yang <richardw.yang@linux.intel.com>,
ehabkost@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] vl.c: make find_default_machine() local
Date: Tue, 02 Apr 2019 17:17:32 +0200 [thread overview]
Message-ID: <87sgv08mib.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20190402150710.gz4rs3rn4sy7khcl@master> (Wei Yang's message of "Tue, 2 Apr 2019 15:07:10 +0000")
Wei Yang <richard.weiyang@gmail.com> writes:
> On Tue, Apr 02, 2019 at 08:33:08AM +0200, Markus Armbruster wrote:
>>Wei Yang <richardw.yang@linux.intel.com> writes:
>>
>>> Function find_default_machine() is introduced by commit 2c8cffa599b7
>>> "vl: make find_default_machine externally visible", while it seems no
>>> one outside use it.
>>It was used outside of vl.c until commit a904410af5f.
>>
>>> This patch make it local again.
>>
>>Suggest:
>>
>> Commit a904410af5f removed the only user of find_default_machine()
>> outside vl.c, but neglected to make it static. Do that now.
>>
>
> Markus
>
> Thanks for your comments.
>
> BTW, I think I need to spin a v2, right?
A v2 with the review comments addressed and my two patches included
would help.
next prev parent reply other threads:[~2019-04-02 15:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 6:08 [Qemu-devel] [PATCH 0/2] cleanup select_machine Wei Yang
2019-03-11 6:08 ` [Qemu-devel] [PATCH 1/2] vl.c: make find_default_machine() local Wei Yang
2019-04-02 6:33 ` Markus Armbruster
2019-04-02 15:07 ` Wei Yang
2019-04-02 15:17 ` Markus Armbruster [this message]
2019-03-11 6:08 ` [Qemu-devel] [PATCH 2/2] vl.c: allocate TYPE_MACHINE list once during bootup Wei Yang
2019-04-02 13:28 ` Markus Armbruster
2019-04-02 15:16 ` Wei Yang
2019-04-02 16:10 ` Markus Armbruster
2019-04-03 0:49 ` Wei Yang
2019-04-03 6:15 ` Markus Armbruster
2019-04-02 13:26 ` [Qemu-devel] [PATCH 3/4] vl: Clean up after previous commit Markus Armbruster
2019-04-03 22:10 ` Wei Yang
2019-04-04 15:49 ` Markus Armbruster
2019-04-02 13:26 ` [Qemu-devel] [PATCH 4/4] vl: Simplify machine_parse() Markus Armbruster
2019-04-03 22:32 ` Wei Yang
2019-04-04 16:05 ` Markus Armbruster
2019-04-04 23:15 ` Wei Yang
2019-04-04 23:15 ` Wei Yang
2019-04-05 5:39 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgv08mib.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.weiyang@gmail.com \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.