All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>,
	Swati Sharma <swati2.sharma@intel.com>
Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org,
	ankit.k.nautiyal@intel.com
Subject: Re: [PATCH] drm/i915: adding state checker for gamma lut values
Date: Fri, 29 Mar 2019 11:07:37 +0200	[thread overview]
Message-ID: <87sgv6121y.fsf@intel.com> (raw)
In-Reply-To: <20190328205618.GT4773@mdroper-desk.amr.corp.intel.com>

On Thu, 28 Mar 2019, Matt Roper <matthew.d.roper@intel.com> wrote:
> I agree with Jani's feedback and have a couple other comments inline below.

Thanks Matt, good stuff here. One naming note below.

> What does the "internal" in this name refer to?  I think just something
> like i9xx_get_gamma_config() would be sufficient
>
> Actually the term "gamma_config" on these functions makes me think we're
> going to be reading out the gamma mode register as well, although that's
> actually done in foo_get_pipe_config().  Maybe just calling this
> something like "i9xx_get_gamma_lut()" or "i9xx_readout_gamma_lut()"
> would be more clear?

I'd like to retain "get" and "config" in the names, just to mentally map
to what's going on. Having "gamma lut" in there is good too to
distinguish from *_get_pipe_config().

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2019-03-29  9:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-28  6:33 [PATCH] drm/i915: adding state checker for gamma lut values Swati Sharma
2019-03-28  6:53 ` ✗ Fi.CI.BAT: failure for drm/i915: adding state checker for gamma lut values (rev2) Patchwork
2019-03-28 11:47 ` [PATCH] drm/i915: adding state checker for gamma lut values Jani Nikula
2019-03-28 20:56 ` Matt Roper
2019-03-28 21:24   ` Ville Syrjälä
2019-03-29  9:07   ` Jani Nikula [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgv6121y.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.