From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH] drm/i915: Avoid waking the engines just to check if they are idle Date: Wed, 27 Feb 2019 15:36:56 +0200 Message-ID: <87sgw9uzd3.fsf@gaia.fi.intel.com> References: <20190227114958.32438-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id A66B56E0C9 for ; Wed, 27 Feb 2019 13:37:23 +0000 (UTC) In-Reply-To: <20190227114958.32438-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gRXhwbG9p dCB0aGF0IHJlYWRzIG9mIHRoZSByaW5nIHJlZ2lzdGVycyByZXR1cm4gMCBmcm9tIHRoZSBlbmdp bmUgd2hlbgo+IGl0IGlzIGlkbGUgYW5kIHdlIGRvIG5vdCBhcHBseSBmb3JjZXdha2UgdG8ga25v dyB0aGF0IGlmIHRoZSBlbmdpbmUgaXMKPiBpZGxlIHRoZW4gYm90aCByZWFkcyB3aWxsIGJlIGlk ZW50aWNhbCAoYW5kIHNvIHdlIGludGVycHJldCB0aGUgcmluZyBhcwo+IGlkbGUpLgo+Cj4gVGhl IHVsdGVyaW9yIG1vdGl2ZSBpcyB0byB0cnkgYW5kIHJlZHVjZSB0aGUgbnVtYmVyIG9mIHNwdXJp b3VzIHdha2V1cHMKPiB0byBhdm9pZCB1bnRpbWVseSBkZWF0aCwgc3VjaCBhczoKPgo+IDwzPiBb ODUuMDQ2ODM2XSBbZHJtOmZ3X2RvbWFpbnNfZ2V0IFtpOTE1XV0gKkVSUk9SKiByZW5kZXI6IHRp bWVkIG91dCB3YWl0aW5nIGZvciBmb3JjZXdha2UgYWNrIHJlcXVlc3QuCj4gPDQ+IFs4NS4wNTE5 MTZdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQo+IDw0PiBbODUuMDUxOTE3 XSBHVCB0aHJlYWQgc3RhdHVzIHdhaXQgdGltZWQgb3V0Cj4gPDQ+IFs4NS4wNTE5NjNdIFdBUk5J Tkc6IENQVTogMiBQSUQ6IDIxOTUgYXQgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3Jl LmM6MzAzIF9fZ2VuNl9ndF93YWl0X2Zvcl90aHJlYWRfYzArMHg2ZS8weGEwIFtpOTE1XQo+IDw0 PiBbODUuMDUxOTY0XSBNb2R1bGVzIGxpbmtlZCBpbjogc25kX2hkYV9jb2RlY19oZG1pIHNuZF9o ZGFfY29kZWNfcmVhbHRlayBzbmRfaGRhX2NvZGVjX2dlbmVyaWMgaTkxNSB4ODZfcGtnX3RlbXBf dGhlcm1hbCBjb3JldGVtcCBtZWlfaGRjcCBjcmN0MTBkaWZfcGNsbXVsIGNyYzMyX3BjbG11bCBz bmRfaGRhX2ludGVsIGdoYXNoX2NsbXVsbmlfaW50ZWwgc25kX2hkYV9jb2RlYyBicm9hZGNvbSBi Y21fcGh5X2xpYiBpMmNfaTgwMSBzbmRfaHdkZXAgc25kX2hkYV9jb3JlIHRnMyBzbmRfcGNtIHB0 cCBwcHNfY29yZSBtZWlfbWUgbWVpIHByaW1lX251bWJlcnMgbHBjX2ljaAo+IDw0PiBbODUuMDUx OTgwXSBDUFU6IDIgUElEOiAyMTk1IENvbW06IGRybV9yZWFkIFRhaW50ZWQ6IEcgICAgIFUgICAg ICAgICAgICA1LjAuMC1yYzgtQ0ktQ0lfRFJNXzU2NjIrICMxCj4gPDQ+IFs4NS4wNTE5ODFdIEhh cmR3YXJlIG5hbWU6IERlbGwgSW5jLiBYUFMgODMwMCAgLzBZMk1SRywgQklPUyBBMDYgMTAvMTcv MjAxMQo+IDw0PiBbODUuMDUyMDEyXSBSSVA6IDAwMTA6X19nZW42X2d0X3dhaXRfZm9yX3RocmVh ZF9jMCsweDZlLzB4YTAgW2k5MTVdCj4gPDQ+IFs4NS4wNTIwMTVdIENvZGU6IDhiIDkyIDVjIDgw IDEzIDAwIDgzIGUyIDA3IDc1IGQ1IDViIDVkIGMzIDgwIDNkIDViIDZhIDFhIDAwIDAwIDc1IGY0 IDQ4IGM3IGM3IDM4IDIxIDMxIGEwIGM2IDA1IDRiIDZhIDFhIDAwIDAxIGU4IGUyIDg0IGVhIGUw IDwwZj4gMGIgZWIgZGQgODAgM2QgM2EgNmEgMWEgMDAgMDAgNzUgOTggNDggYzcgYzYgMDggMjEg MzEgYTAgNDggYzcKPiA8ND4gWzg1LjA1MjAxNl0gUlNQOiAwMDE4OmZmZmZjOTAwMDA0M2JkMDAg RUZMQUdTOiAwMDAxMDA4Ngo+IDw0PiBbODUuMDUyMDE5XSBSQVg6IDAwMDAwMDAwMDAwMDAwMDAg UkJYOiBmZmZmODg4MjE3YzUwMDAwIFJDWDogMDAwMDAwMDAwMDAwMDAwMAo+IDw0PiBbODUuMDUy MDIwXSBSRFg6IDAwMDAwMDAwMDAwMDAwMDcgUlNJOiBmZmZmZmZmZjgyMGNiMTQxIFJESTogMDAw MDAwMDBmZmZmZmZmZgo+IDw0PiBbODUuMDUyMDIyXSBSQlA6IDAwMDAwMDEzY2QzMGYyZmIgUjA4 OiAwMDAwMDAwMDAwMDAwMDAwIFIwOTogMDAwMDAwMDAwMDAwMDAwMQo+IDw0PiBbODUuMDUyMDI0 XSBSMTA6IGZmZmZjOTAwMDA0M2JjZTAgUjExOiAwMDAwMDAwMDAwMDAwMDAwIFIxMjogZmZmZjg4 ODIxN2M1MGVlMAo+IDw0PiBbODUuMDUyMDI1XSBSMTM6IDAwMDAwMDAwMDAwMDAwMDEgUjE0OiAw MDAwMDAwMGZmZmZmZmZmIFIxNTogZmZmZjg4ODIxODA3NjUzMAo+IDw0PiBbODUuMDUyMDI4XSBG UzogIDAwMDA3ZmM3OWQwNDk5ODAoMDAwMCkgR1M6ZmZmZjg4ODIyN2E4MDAwMCgwMDAwKSBrbmxH UzowMDAwMDAwMDAwMDAwMDAwCj4gPDQ+IFs4NS4wNTIwMjldIENTOiAgMDAxMCBEUzogMDAwMCBF UzogMDAwMCBDUjA6IDAwMDAwMDAwODAwNTAwMzMKPiA8ND4gWzg1LjA1MjAzMV0gQ1IyOiAwMDAw N2Y3ODJlMjk0MGY4IENSMzogMDAwMDAwMDIyNDU4ZTAwNiBDUjQ6IDAwMDAwMDAwMDAwNjA2ZTAK PiA8ND4gWzg1LjA1MjAzM10gQ2FsbCBUcmFjZToKPiA8ND4gWzg1LjA1MjA2NF0gIGdlbjZfcmVh ZDMyKzB4MTRlLzB4MjUwIFtpOTE1XQo+IDw0PiBbODUuMDUyMDk2XSAgaW50ZWxfZW5naW5lX2lz X2lkbGUrMHg3ZC8weDE4MCBbaTkxNV0KPiA8ND4gWzg1LjA1MjEyNl0gIGludGVsX2VuZ2luZXNf YXJlX2lkbGUrMHgyOS8weDUwIFtpOTE1XQo+IDw0PiBbODUuMDUyMTUzXSAgaTkxNV9kcm9wX2Nh Y2hlc19zZXQrMHgyMWMvMHgyOTAgW2k5MTVdCj4gPDQ+IFs4NS4wNTIxNjBdICBzaW1wbGVfYXR0 cl93cml0ZSsweGIwLzB4ZDAKPiA8ND4gWzg1LjA1MjE2NV0gIGZ1bGxfcHJveHlfd3JpdGUrMHg1 MS8weDgwCj4gPDQ+IFs4NS4wNTIxNzBdICBfX3Zmc193cml0ZSsweDMxLzB4MTkwCj4gPDQ+IFs4 NS4wNTIxNzZdICA/IHJjdV9yZWFkX2xvY2tfc2NoZWRfaGVsZCsweDZmLzB4ODAKPiA8ND4gWzg1 LjA1MjE3OF0gID8gcmN1X3N5bmNfbG9ja2RlcF9hc3NlcnQrMHgyOS8weDUwCj4gPDQ+IFs4NS4w NTIxODFdICA/IF9fc2Jfc3RhcnRfd3JpdGUrMHgxNTIvMHgxZjAKPiA8ND4gWzg1LjA1MjE4M10g ID8gX19zYl9zdGFydF93cml0ZSsweDE2My8weDFmMAo+IDw0PiBbODUuMDUyMTg3XSAgdmZzX3dy aXRlKzB4YmQvMHgxYjAKPiA8ND4gWzg1LjA1MjE5MV0gIGtzeXNfd3JpdGUrMHg1MC8weGMwCj4g PDQ+IFs4NS4wNTIxOTZdICBkb19zeXNjYWxsXzY0KzB4NTUvMHgxOTAKPiA8ND4gWzg1LjA1MjIw MF0gIGVudHJ5X1NZU0NBTExfNjRfYWZ0ZXJfaHdmcmFtZSsweDQ5LzB4YmUKPiA8ND4gWzg1LjA1 MjIwMl0gUklQOiAwMDMzOjB4N2ZjNzljOWQzMjgxCj4gPDQ+IFs4NS4wNTIyMDRdIENvZGU6IGMz IDBmIDFmIDg0IDAwIDAwIDAwIDAwIDAwIDQ4IDhiIDA1IDU5IDhkIDIwIDAwIGMzIDBmIDFmIDg0 IDAwIDAwIDAwIDAwIDAwIDhiIDA1IDhhIGQxIDIwIDAwIDg1IGMwIDc1IDE2IGI4IDAxIDAwIDAw IDAwIDBmIDA1IDw0OD4gM2QgMDAgZjAgZmYgZmYgNzcgNTcgZjMgYzMgMGYgMWYgNDQgMDAgMDAg NDEgNTQgNTUgNDkgODkgZDQgNTMKPiA8ND4gWzg1LjA1MjIwNl0gUlNQOiAwMDJiOjAwMDA3ZmZm YTRhMGE3ZjggRUZMQUdTOiAwMDAwMDI0NiBPUklHX1JBWDogMDAwMDAwMDAwMDAwMDAwMQo+IDw0 PiBbODUuMDUyMjA4XSBSQVg6IGZmZmZmZmZmZmZmZmZmZGEgUkJYOiAwMDAwMDAwMDAwMDAwMDAx IFJDWDogMDAwMDdmYzc5YzlkMzI4MQo+IDw0PiBbODUuMDUyMjEwXSBSRFg6IDAwMDAwMDAwMDAw MDAwMDUgUlNJOiAwMDAwN2ZmZmE0YTBhODgwIFJESTogMDAwMDAwMDAwMDAwMDAwOAo+IDw0PiBb ODUuMDUyMjEyXSBSQlA6IDAwMDA3ZmZmYTRhMGE4MjAgUjA4OiAwMDAwMDAwMDAwMDAwMDAwIFIw OTogMDAwMDAwMDAwMDAwMDAwMAo+IDw0PiBbODUuMDUyMjEzXSBSMTA6IDAwMDAwMDAwMDAwMDAw MDAgUjExOiAwMDAwMDAwMDAwMDAwMjQ2IFIxMjogMDAwMDdmYzc5YzliYzcxOAo+IDw0PiBbODUu MDUyMjE1XSBSMTM6IDAwMDAwMDAwMDAwMDAwMDMgUjE0OiAwMDAwN2ZjNzljOWMxNjI4IFIxNTog MDAwMDdmYzc5YzliZGQ4MAo+IDw0PiBbODUuMDUyMjIzXSBpcnEgZXZlbnQgc3RhbXA6IDcxNjMw Cj4gPDQ+IFs4NS4wNTIyMjZdIGhhcmRpcnFzIGxhc3QgIGVuYWJsZWQgYXQgKDcxNjI5KTogWzxm ZmZmZmZmZjgxOTdiNjRjPl0gX3Jhd19zcGluX3VubG9ja19pcnFyZXN0b3JlKzB4NGMvMHg2MAo+ IDw0PiBbODUuMDUyMjI4XSBoYXJkaXJxcyBsYXN0IGRpc2FibGVkIGF0ICg3MTYzMCk6IFs8ZmZm ZmZmZmY4MTk3YjRiZD5dIF9yYXdfc3Bpbl9sb2NrX2lycXNhdmUrMHhkLzB4NTAKPiA8ND4gWzg1 LjA1MjIzMV0gc29mdGlycXMgbGFzdCAgZW5hYmxlZCBhdCAoNzA0NDQpOiBbPGZmZmZmZmZmODFj MDAzM2E+XSBfX2RvX3NvZnRpcnErMHgzM2EvMHg0YjkKPiA8ND4gWzg1LjA1MjIzNF0gc29mdGly cXMgbGFzdCBkaXNhYmxlZCBhdCAoNzA0MzMpOiBbPGZmZmZmZmZmODEwYjUxYjE+XSBpcnFfZXhp dCsweGQxLzB4ZTAKPiA8ND4gWzg1LjA1MjI2NF0gV0FSTklORzogQ1BVOiAyIFBJRDogMjE5NSBh dCBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNvcmUuYzozMDMgX19nZW42X2d0X3dhaXRf Zm9yX3RocmVhZF9jMCsweDZlLzB4YTAgW2k5MTVdCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBX aWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogTWlrYSBLdW9wcGFsYSA8bWlr YS5rdW9wcGFsYUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2VuZ2luZV9jcy5jIHwgMTcgKysrKysrKysrKystLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEx IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9lbmdpbmVfY3MuYwo+IGluZGV4IGI3YjYyNjE5NWVkYS4uNGYyNDQwMTk1NjBkIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPiBAQCAtOTY4LDYgKzk2OCw3IEBA IHN0YXRpYyBib29sIHJpbmdfaXNfaWRsZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUp Cj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGVuZ2luZS0+aTkx NTsKPiAgCWludGVsX3dha2VyZWZfdCB3YWtlcmVmOwo+ICsJdW5zaWduZWQgbG9uZyBmbGFnczsK PiAgCWJvb2wgaWRsZSA9IHRydWU7Cj4gIAo+ICAJaWYgKEk5MTVfU0VMRlRFU1RfT05MWSghZW5n aW5lLT5tbWlvX2Jhc2UpKQo+IEBAIC05NzgsMTUgKzk3OSwxOSBAQCBzdGF0aWMgYm9vbCByaW5n X2lzX2lkbGUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAJaWYgKCF3YWtlcmVm KQo+ICAJCXJldHVybiB0cnVlOwo+ICAKPiAtCS8qIEZpcnN0IGNoZWNrIHRoYXQgbm8gY29tbWFu ZHMgYXJlIGxlZnQgaW4gdGhlIHJpbmcgKi8KPiAtCWlmICgoSTkxNV9SRUFEX0hFQUQoZW5naW5l KSAmIEhFQURfQUREUikgIT0KPiAtCSAgICAoSTkxNV9SRUFEX1RBSUwoZW5naW5lKSAmIFRBSUxf QUREUikpCj4gLQkJaWRsZSA9IGZhbHNlOwo+ICsJc3Bpbl9sb2NrX2lycXNhdmUoJmRldl9wcml2 LT51bmNvcmUubG9jaywgZmxhZ3MpOwo+ICAKPiAtCS8qIE5vIGJpdCBmb3IgZ2VuMiwgc28gYXNz dW1lIHRoZSBDUyBwYXJzZXIgaXMgaWRsZSAqLwo+IC0JaWYgKElOVEVMX0dFTihkZXZfcHJpdikg PiAyICYmICEoSTkxNV9SRUFEX01PREUoZW5naW5lKSAmIE1PREVfSURMRSkpCgpJIGFncmVlIG9u IHRoZSBzZW50aW1lbnQgdGhhdCBpbiBoZXJlIHdlIHNob3VsZCBoYXZlIGEgb25lIG1hcmtlciBv bmx5LgpBbmQgdGhhdCBpcyBpZGxlID09IChoZWFkID09IHRhaWwpLiBXZSBoYXZlIE1PREVfSURM RSBjaGVja3MKb24gb3RoZXIgcGFydHMgYnV0IHRoZXkgZG9udCBhZmZlY3QgdGhlIGZsb3cuCgpS ZXZpZXdlZC1ieTogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+ Cgo+ICsJLyoKPiArCSAqIENoZWNrIHRoYXQgbm8gY29tbWFuZHMgYXJlIGxlZnQgaW4gdGhlIHJp bmcuCj4gKwkgKgo+ICsJICogSWYgdGhlIGVuZ2luZSBpcyBub3QgYXdha2UsIGJvdGggcmVhZHMg cmV0dXJuIDAgYXMgd2UgZG8gc28gd2l0aG91dAo+ICsJICogZm9yY2V3YWtlLgo+ICsJICovCj4g KwlpZiAoKEk5MTVfUkVBRF9GVyhSSU5HX0hFQUQoZW5naW5lLT5tbWlvX2Jhc2UpKSAmIEhFQURf QUREUikgIT0KPiArCSAgICAoSTkxNV9SRUFEX0ZXKFJJTkdfVEFJTChlbmdpbmUtPm1taW9fYmFz ZSkpICYgVEFJTF9BRERSKSkKPiAgCQlpZGxlID0gZmFsc2U7Cj4gIAo+ICsJc3Bpbl91bmxvY2tf aXJxcmVzdG9yZSgmZGV2X3ByaXYtPnVuY29yZS5sb2NrLCBmbGFncyk7Cj4gIAlpbnRlbF9ydW50 aW1lX3BtX3B1dChkZXZfcHJpdiwgd2FrZXJlZik7Cj4gIAo+ICAJcmV0dXJuIGlkbGU7Cj4gLS0g Cj4gMi4yMC4xCj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4