From: Christian Stewart <christian@paral.in>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/docker-engine: add sysv init script
Date: Wed, 30 Jan 2019 19:11:33 -0800 [thread overview]
Message-ID: <87sgx9ed22.fsf@paral.in> (raw)
In-Reply-To: <20190130222810.3927-1-peter@korsgaard.com>
Hi Peter,
Peter Korsgaard <peter@korsgaard.com> writes:
> +++ b/package/docker-engine/S60dockerd
> @@ -0,0 +1,38 @@
> +#!/bin/sh
> +
> +NAME=dockerd
> +DAEMON=/usr/bin/$NAME
> +PIDFILE=/var/run/$NAME.pid
> +DAEMON_ARGS=""
We pull the systemd unit file from /contrib/init/systemd/docker.service
within the docker-engine codebase.
There also exists /contrib/init/openrc as well as sysvinit-debian,
sysvinit-redhat, and upstart. I guess none of these are suitable for the
sysv init system.
> +define DOCKER_ENGINE_INSTALL_INIT_SYSV
> + $(INSTALL) -D -m 755 package/docker-engine/S60dockerd \
> + $(TARGET_DIR)/etc/init.d/S60dockerd
> +endef
In general LGTM.
Acked-by: Christian Stewart <christian@paral.in>
Best,
Christian
next prev parent reply other threads:[~2019-01-31 3:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 22:28 [Buildroot] [PATCH] package/docker-engine: add sysv init script Peter Korsgaard
2019-01-31 3:11 ` Christian Stewart [this message]
2019-01-31 7:32 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgx9ed22.fsf@paral.in \
--to=christian@paral.in \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.