From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.toke.dk ([52.28.52.200]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1glckd-0004BP-AM for ath10k@lists.infradead.org; Mon, 21 Jan 2019 16:48:45 +0000 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [PATCH v4 6/6] ath10k: reporting estimated tx airtime for fairness In-Reply-To: <8736pmmjbk.fsf@toke.dk> References: <1545172374-1072-1-git-send-email-rmanohar@codeaurora.org> <1545172374-1072-7-git-send-email-rmanohar@codeaurora.org> <8736pmmjbk.fsf@toke.dk> Date: Mon, 21 Jan 2019 17:48:39 +0100 Message-ID: <87sgxmklco.fsf@toke.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Rajkumar Manoharan , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Cc: Kan Yan , make-wifi-fast@lists.bufferbloat.net VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHRva2UuZGs+IHdyaXRlczoKCj4gUmFqa3Vt YXIgTWFub2hhcmFuIDxybWFub2hhckBjb2RlYXVyb3JhLm9yZz4gd3JpdGVzOgo+Cj4+IEZyb206 IEthbiBZYW4gPGt5YW5AZ29vZ2xlLmNvbT4KPj4KPj4gVHJhbnNtaXQgYWlydGltZSB3aWxsIGJl IGVzdGltYXRlZCBmcm9tIGxhc3QgdHggcmF0ZSB1c2VkLgo+PiBGaXJtd2FyZSByZXBvcnQgdHgg cmF0ZSBieSBwZWVyIHN0YXRzLiBBaXJ0aW1lIGlzIGNvbXB1dGVkCj4+IG9uIHR4IHBhdGggYW5k IHRoZSBzYW1lIHdpbGwgYmUgcmVwb3J0ZWQgdG8gbWFjODAyMTEgdXBvbgo+PiB0eCBjb21wbGV0 aW9uLgo+Cj4gRllJLCBpdCBzZWVtcyB0aGF0IHRoaXMgbGFzdCBwYXRjaCBpbiB0aGUgc2VyaWVz IG5vIGxvbmdlciBhcHBsaWVzCj4gY2xlYW5seSBvbiB0b3Agb2YgbWFjODAyMTEtbmV4dC4gTWF5 IG5lZWQgYSByZWZyZXNoLgo+Cj4gVGhlIG1hYzgwMjExIHBhcnRzIHdlcmUgbWVyZ2VkIGludG8g bWFjODAyMTEtbmV4dCAodGhhbmtzLCBKb2hhbm5lcyEpOyBJCj4gZ3Vlc3MgdGhlIGRyaXZlciB1 cGRhdGVzIGFyZSB3YWl0aW5nIGZvciBkcml2ZXJzLW5leHQgdG8gY2F0Y2ggdXAgdG8KPiB0aGF0 Pwo+Cj4gUGF0Y2hlcyA0IGFuZCA1IGluIHRoZSBzZXJpZXMgYXJlIGZpbmUuLi4KClRoaXMgd2Fz IG1lYW50IHRvIGJlIGEgcmVwbHkgdG8gdjUgb2YgdGhlIHBhdGNoIHNldCAod2hpY2ggaXMgd2hl cmUgSQpoYWQgdGhlIGlzc3VlKTsgYXBvbG9naWVzIGZvciBwaWNraW5nIHRoZSB3cm9uZyBvbmUg dG8gcmVwbHkgdG8uLi4KCi1Ub2tlCj4KPiAtVG9rZQoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KYXRoMTBrIG1haWxpbmcgbGlzdAphdGgxMGtAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2F0aDEwawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4675C2F441 for ; Mon, 21 Jan 2019 16:48:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 81D1820663 for ; Mon, 21 Jan 2019 16:48:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toke.dk header.i=@toke.dk header.b="ICLfXLei" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730366AbfAUQsl (ORCPT ); Mon, 21 Jan 2019 11:48:41 -0500 Received: from mail.toke.dk ([52.28.52.200]:34375 "EHLO mail.toke.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730135AbfAUQsl (ORCPT ); Mon, 21 Jan 2019 11:48:41 -0500 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1548089319; bh=r14cw7ZTUoQ1g4hz99LMnr1pSAW48GyAl0gMHC4xJrQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ICLfXLeilaNBk4jMoPimgwPV2d0LNe/wKyvlbTiTCmE9mmwC8va8gZhS6NcE0GArt hiPLwCvPxbxJe2iqa088ssDMjy6jwET/GqxuyrUBmZ1TCGPPOGYdRIK0bwlY9XLLzH bsb9scYcbxFY/oSYEbyKcAXk+wy5uZOcFzW9P3nPKPZMfshTfOVN/vAlR+3bhL00/P 2IRHkAY7NAGByWv0cpgumF/e4WNtnzbX3wiPIk0pyictUszSJbyenj6buKO+2Aal6r Gb/uT/TJTjgopGJdVjIBNO/Z2nDFkik8IIPTrJYmQGOD9x7mvPMq5Ihpfso7is2VHH /O9Cg6+Az5Wrw== To: Rajkumar Manoharan , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Cc: make-wifi-fast@lists.bufferbloat.net, Kan Yan , Rajkumar Manoharan Subject: Re: [PATCH v4 6/6] ath10k: reporting estimated tx airtime for fairness In-Reply-To: <8736pmmjbk.fsf@toke.dk> References: <1545172374-1072-1-git-send-email-rmanohar@codeaurora.org> <1545172374-1072-7-git-send-email-rmanohar@codeaurora.org> <8736pmmjbk.fsf@toke.dk> Date: Mon, 21 Jan 2019 17:48:39 +0100 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87sgxmklco.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Toke H=C3=B8iland-J=C3=B8rgensen writes: > Rajkumar Manoharan writes: > >> From: Kan Yan >> >> Transmit airtime will be estimated from last tx rate used. >> Firmware report tx rate by peer stats. Airtime is computed >> on tx path and the same will be reported to mac80211 upon >> tx completion. > > FYI, it seems that this last patch in the series no longer applies > cleanly on top of mac80211-next. May need a refresh. > > The mac80211 parts were merged into mac80211-next (thanks, Johannes!); I > guess the driver updates are waiting for drivers-next to catch up to > that? > > Patches 4 and 5 in the series are fine... This was meant to be a reply to v5 of the patch set (which is where I had the issue); apologies for picking the wrong one to reply to... -Toke > > -Toke