From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [RESEND PATCH 2/5] drm/i915/backlight: Fix
 backlight takeover on LPT, v2.
Date: Fri, 28 Dec 2018 16:45:29 +0200
Message-ID: <87sgyhvhfa.fsf@intel.com>
References: <20181217095024.2340-1-maarten.lankhorst@linux.intel.com>
 <20181217095024.2340-2-maarten.lankhorst@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 27D016E4E9
 for <intel-gfx@lists.freedesktop.org>; Fri, 28 Dec 2018 14:45:05 +0000 (UTC)
In-Reply-To: <20181217095024.2340-2-maarten.lankhorst@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, intel-gfx@lists.freedesktop.org
Cc: Hans de Goede <jwrdegoede@fedoraproject.org>, Basil Eric Rabi <ericbasil.rabi@gmail.com>, Tolga Cakir <cevelnet@gmail.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCAxNyBEZWMgMjAxOCwgTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0
QGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gT24gbHlueHBvaW50IHRoZSBiaW9zIHNvbWV0aW1l
cyBzZXRzIHVwIHRoZSBiYWNrbGlnaHQgdXNpbmcgdGhlIENQVQo+IGRpc3BsYXksIGJ1dCB0aGUg
ZHJpdmVyIGV4cGVjdHMgdXNpbmcgdGhlIFBXTSBQQ0ggb3ZlcnJpZGUgcmVnaXN0ZXIuCj4KPiBS
ZWFkIHRoZSB2YWx1ZSBmcm9tIHRoZSBDUFUgcmVnaXN0ZXIsIHRoZW4gY29udmVydCBpdCB0byB0
aGUgb3RoZXIKPiB1bml0cyBieSBjb252ZXJ0aW5nIGZyb20gdGhlIG9sZCBkdXR5IGN5Y2xlLCB0
byBmcmVxLCB0byB0aGUgbmV3IHVuaXRzLgo+Cj4gVGhpcyB2YWx1ZSBpcyB0aGVuIHByb2dyYW1t
ZWQgaW4gdGhlIG92ZXJyaWRlIHJlZ2lzdGVyLCBhZnRlciB3aGljaAo+IHdlIHNldCB0aGUgb3Zl
cnJpZGUgYW5kIGRpc2FibGUgdGhlIENQVSBkaXNwbGF5IGNvbnRyb2wuIFRoaXMgYWxsb3dzCj4g
dXMgdG8gc3dpdGNoIHRoZSBzb3VyY2Ugd2l0aG91dCBmbGlja2VyaW5nLCBhbmQgbWFrZSB0aGUg
YmFja2xpZ2h0Cj4gY29udHJvbHMgd29yayBpbiB0aGUgZHJpdmVyLgo+Cj4gQ2hhbmdlcyBzaW5j
ZSB2MToKPiAtIFJlYWQgQkxDX1BXTV9DUFVfQ1RMMiB0byBjcHVfY3RsMi4KPiAtIENsZWFuIHVw
IGNwdV9tb2RlIGlmIHNsaWdodGx5Lgo+IC0gQWx3YXlzIGRpc2FibGUgQkxNX1BXTV9FTkFCTEUg
aW4gY3B1X2N0bDIuCj4KPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRl
bi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJl
ZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDgyMjUKPiBDYzogQmFzaWwgRXJpYyBSYWJp
IDxlcmljYmFzaWwucmFiaUBnbWFpbC5jb20+Cj4gQ2M6IEhhbnMgZGUgR29lZGUgPGp3cmRlZ29l
ZGVAZmVkb3JhcHJvamVjdC5vcmc+Cj4gQ2M6IFRvbGdhIENha2lyIDxjZXZlbG5ldEBnbWFpbC5j
b20+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+
Cj4gVGVzdGVkLWJ5OiBUb2xnYSBDYWtpciA8Y2V2ZWxuZXRAZ21haWwuY29tPgo+IC0tLQo+ICBk
cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5jIHwgNDAgKysrKysrKysrKysrKysrKysr
KysrKysrKysrLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzNiBpbnNlcnRpb25zKCspLCA0IGRlbGV0
aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVs
LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5jCj4gaW5kZXggNzk5Mjg0ZmNk
NTdkLi4zZTNjZTdhNzc3MDAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfcGFuZWwuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMKPiBA
QCAtMTQ4NCw4ICsxNDg0LDggQEAgc3RhdGljIGludCBscHRfc2V0dXBfYmFja2xpZ2h0KHN0cnVj
dCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvciwgZW51bSBwaXBlIHVudXMKPiAgewo+ICAJc3Ry
dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShjb25uZWN0b3ItPmJhc2Uu
ZGV2KTsKPiAgCXN0cnVjdCBpbnRlbF9wYW5lbCAqcGFuZWwgPSAmY29ubmVjdG9yLT5wYW5lbDsK
PiAtCXUzMiBwY2hfY3RsMSwgcGNoX2N0bDIsIHZhbDsKPiAtCWJvb2wgYWx0Owo+ICsJdTMyIGNw
dV9jdGwyLCBwY2hfY3RsMSwgcGNoX2N0bDIsIHZhbDsKPiArCWJvb2wgYWx0LCBjcHVfbW9kZTsK
PiAgCj4gIAlpZiAoSEFTX1BDSF9MUFQoZGV2X3ByaXYpKQo+ICAJCWFsdCA9IEk5MTVfUkVBRChT
T1VUSF9DSElDS0VOMikgJiBMUFRfUFdNX0dSQU5VTEFSSVRZOwo+IEBAIC0xNDk5LDYgKzE0OTks
OCBAQCBzdGF0aWMgaW50IGxwdF9zZXR1cF9iYWNrbGlnaHQoc3RydWN0IGludGVsX2Nvbm5lY3Rv
ciAqY29ubmVjdG9yLCBlbnVtIHBpcGUgdW51cwo+ICAJcGNoX2N0bDIgPSBJOTE1X1JFQUQoQkxD
X1BXTV9QQ0hfQ1RMMik7Cj4gIAlwYW5lbC0+YmFja2xpZ2h0Lm1heCA9IHBjaF9jdGwyID4+IDE2
Owo+ICAKPiArCWNwdV9jdGwyID0gSTkxNV9SRUFEKEJMQ19QV01fQ1BVX0NUTDIpOwo+ICsKPiAg
CWlmICghcGFuZWwtPmJhY2tsaWdodC5tYXgpCj4gIAkJcGFuZWwtPmJhY2tsaWdodC5tYXggPSBn
ZXRfYmFja2xpZ2h0X21heF92YnQoY29ubmVjdG9yKTsKPiAgCj4gQEAgLTE1MDcsMTIgKzE1MDks
NDIgQEAgc3RhdGljIGludCBscHRfc2V0dXBfYmFja2xpZ2h0KHN0cnVjdCBpbnRlbF9jb25uZWN0
b3IgKmNvbm5lY3RvciwgZW51bSBwaXBlIHVudXMKPiAgCj4gIAlwYW5lbC0+YmFja2xpZ2h0Lm1p
biA9IGdldF9iYWNrbGlnaHRfbWluX3ZidChjb25uZWN0b3IpOwo+ICAKPiAtCXZhbCA9IGxwdF9n
ZXRfYmFja2xpZ2h0KGNvbm5lY3Rvcik7Cj4gKwlwYW5lbC0+YmFja2xpZ2h0LmVuYWJsZWQgPSBw
Y2hfY3RsMSAmIEJMTV9QQ0hfUFdNX0VOQUJMRTsKPiArCj4gKwljcHVfbW9kZSA9IHBhbmVsLT5i
YWNrbGlnaHQuZW5hYmxlZCAmJiBIQVNfUENIX0xQVChkZXZfcHJpdikgJiYKPiArCQkgICAhKHBj
aF9jdGwxICYgQkxNX1BDSF9PVkVSUklERV9FTkFCTEUpICYmCj4gKwkJICAgKGNwdV9jdGwyICYg
QkxNX1BXTV9FTkFCTEUpOwo+ICsJaWYgKGNwdV9tb2RlKSB7Cj4gKwkJdTMyIGZyZXE7Cj4gKwo+
ICsJCS8qCj4gKwkJICogV2UncmUgaW4gY3B1IG1vZGUsIGNvbnZlcnQgdG8gUENIIHVuaXRzLgo+
ICsJCSAqCj4gKwkJICogQ29udmVydCBDUFUgcHdtIHRpY2sgYmFjayB0byBoeiwgYmFjayB0byBu
ZXcgUENIIHVuaXRzIGFnYWluLgo+ICsJCSAqIHRoaXMgaXMgdGhlIHNhbWUgZm9ybXVsYSBhcyBw
Y2hfaHpfdG9fcHdtLCBidXQgdGhlIG90aGVyIHdheQo+ICsJCSAqIGFyb3VuZC4uCj4gKwkJICov
Cj4gKwkJdmFsID0gcGNoX2dldF9iYWNrbGlnaHQoY29ubmVjdG9yKTsKPiArCQlmcmVxID0gRElW
X1JPVU5EX0NMT1NFU1QoS0h6KGRldl9wcml2LT5yYXdjbGtfZnJlcSksIHZhbCAqIDEyOCk7Cj4g
Kwo+ICsJCURSTV9ERUJVR19LTVMoIkJhY2tsaWdodCBQQ0ggdmFsdWU6ICV1LCBjb252ZXJ0ZWQg
dG8gZnJlcSAldSwgY29udmVydGVkIHRvIGxwdCB1bml0cyAldSwgbWlubWF4OiAldS8ldVxuIiwK
PiArCQkJICAgICAgdmFsLCBmcmVxLCBscHRfaHpfdG9fcHdtKGNvbm5lY3RvciwgZnJlcSksIHBh
bmVsLT5iYWNrbGlnaHQubWluLCBwYW5lbC0+YmFja2xpZ2h0Lm1heCk7Cj4gKwo+ICsJCXZhbCA9
IGxwdF9oel90b19wd20oY29ubmVjdG9yLCBmcmVxKTsKCklmIHRoZSBDUFUgcmVnaXN0ZXIgaXMg
ZHJpdmluZyB0aGUgUENIIFBXTSwgSSB0aGluayB5b3UncmUgZ29vZCB3aXRoCnVzaW5nIHZhbCA9
IHBjaF9nZXRfYmFja2xpZ2h0KGNvbm5lY3RvcikgZGlyZWN0bHkuIEluIHRoYXQgY2FzZSwgdGhl
Cm1vZHVsYXRpb24gZnJlcXVlbmN5IHNob3VsZCBiZSBzZXQgaW4gdGhlIFBDSCByZWdpc3RlciBh
bnl3YXksIGFuZCBpdApzaG91bGQgYmUgYWxsIHJpZ2h0LiBUaGUgaW5jcmVtZW50cyBhbmQgcmVm
ZXJlbmNlIGNsb2NrcyBhbmQgZXZlcnl0aGluZwpzaG91bGQgYmUgdGhlIHNhbWUuIFNvIHRoZSBk
dXR5IGN5Y2xlIHNob3VsZCBiZSB0aGUgc2FtZS4KClRoZSBDUFUgcmVnaXN0ZXIgbW9kdWxhdGlv
biBmcmVxdWVuY3kgc3R1ZmYgc2hvdWxkIG9ubHkgYmUgdXNlZCBmb3IKZHJpdmluZyB0aGUgYmFj
a2xpZ2h0IGluIHRoZSB1dGlsaXR5IHBpbi4gVGhhdCdzIGEgcG9zc2liaWxpdHkgd2Ugc2hvdWxk
Cm1heWJlIGNoZWNrLCBidXQgaWYgdGhpcyBwYXRjaCBmaXhlcyBhbnl0aGluZywgdGhhdCdzIG5v
dCB0aGUgY2FzZQpoZXJlLiBJdCdzIGEgcGh5c2ljYWxseSBkaWZmZXJlbnQgcGluLCBhbmQgd2Ug
b25seSBzdXBwb3J0IHRoYXQgb24KQlhULiBJSVJDIEkndmUgYmVlbiB0b2xkIG5vYm9keSB1c2Vz
IHRoYXQgb24gSFNXL0xQVCwgYW5kIEkgZG9uJ3QgcmVjYWxsCmFueSByZWxldmFudCBidWcgcmVw
b3J0cyBlaXRoZXIuCgpVc2luZyB0aGUgdXRpbGl0eSBwaW4gd291bGQgaW52b2x2ZToKCiogU2V0
dGluZyB0aGUgdXRpbGl0eSBwaW4gbW9kZSB0byBQV00sIGFuZCBlbmFibGluZyBpdCBpbiBVVElM
X1BJTl9DVEwKICAoMHg0ODQwMCkuCgoqIFNldHRpbmcgdGhlIFBXTSBwaW4gc2VsZWN0cyBpbiBC
TENfTUlTQ19DVEwgKDB4NDgzNjApLgoKKiBTZXR0aW5nIHRoZSBtb2R1bGF0aW9uIGZyZXF1ZW5j
eSBpbiBCTENfUFdNX0NQVV9DVEwgKDB4NDgyNTQpICpvciogaW4KICBIU1dfQkxDX1BXTTJfQ1RM
ICgweDQ4MzU0KSBkZXBlbmRpbmcgb24gQkxDX01JU0NfQ1RMLgoKUGVyaGFwcyB3ZSBzaG91bGQg
YWRkIFdBUk5fT04oKXMgb24gdXRpbCBwaW4gcHdtIG1vZGUgYW5kIG5vbi16ZXJvIGJsYwptaXNj
LCBidXQgdGhhdCdzIGFub3RoZXIgcGF0Y2guCgpUTDtEUiBtYWtlIHRoYXQ6CgoJaWYgKGNwdV9t
b2RlKQoJCXZhbCA9IHBjaF9nZXRfYmFja2xpZ2h0KGNvbm5lY3Rvcik7CgllbHNlCgkJdmFsID0g
bHB0X2dldF9iYWNrbGlnaHQoY29ubmVjdG9yKTsKCj4gKwl9IGVsc2UKPiArCQl2YWwgPSBscHRf
Z2V0X2JhY2tsaWdodChjb25uZWN0b3IpOwo+ICAJdmFsID0gaW50ZWxfcGFuZWxfY29tcHV0ZV9i
cmlnaHRuZXNzKGNvbm5lY3RvciwgdmFsKTsKPiAgCXBhbmVsLT5iYWNrbGlnaHQubGV2ZWwgPSBj
bGFtcCh2YWwsIHBhbmVsLT5iYWNrbGlnaHQubWluLAo+ICAJCQkJICAgICAgIHBhbmVsLT5iYWNr
bGlnaHQubWF4KTsKPiAgCj4gLQlwYW5lbC0+YmFja2xpZ2h0LmVuYWJsZWQgPSBwY2hfY3RsMSAm
IEJMTV9QQ0hfUFdNX0VOQUJMRTsKPiArCWlmIChjcHVfbW9kZSkgewoKQWZ0ZXIgdGhlIHNpbXBs
aWNpY2F0aW9uIGFib3ZlLCBwZXJoYXBzIGFkZCBhIGRlYnVnIGxvZyBoZXJlIGluc3RlYWQKYWJv
dXQgc3dpdGNoaW5nIHRvIFBDSCBvdmVycmlkZS4KCj4gKwkJLyogV3JpdGUgY29udmVydGVkIENQ
VSBQV00gdmFsdWUgdG8gUENIIG92ZXJyaWRlIHJlZ2lzdGVyICovCj4gKwkJbHB0X3NldF9iYWNr
bGlnaHQoY29ubmVjdG9yLT5iYXNlLnN0YXRlLCBwYW5lbC0+YmFja2xpZ2h0LmxldmVsKTsKPiAr
CQlJOTE1X1dSSVRFKEJMQ19QV01fUENIX0NUTDEsIHBjaF9jdGwxIHwgQkxNX1BDSF9PVkVSUklE
RV9FTkFCTEUpOwo+ICsJfQo+ICsKPiArCWlmIChjcHVfY3RsMiAmIEJMTV9QV01fRU5BQkxFKQo+
ICsJCUk5MTVfV1JJVEUoQkxDX1BXTV9DUFVfQ1RMMiwgY3B1X2N0bDIgJiB+QkxNX1BXTV9FTkFC
TEUpOwoKUGxlYXNlIG1vdmUgdGhhdCB3aXRoaW4gdGhlIGNwdV9tb2RlIGJsb2NrIGFib3ZlLiBJ
IHdhbnQgdG8gbWluaW1pemUgdGhlCmltcGFjdCBvbiAhY3B1X21vZGUuCgpCUiwKSmFuaS4KCj4g
IAo+ICAJcmV0dXJuIDA7Cj4gIH0KCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2Ug
R3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w
Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs
LWdmeAo=