From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 07/16] drm/i915: Remove redundant checks for num_pipes == 0 Date: Mon, 22 Oct 2018 11:31:13 +0300 Message-ID: <87sh0yfkmm.fsf@intel.com> References: <20181012215218.5119-1-jose.souza@intel.com> <20181012215218.5119-7-jose.souza@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 68C0889A4A for ; Mon, 22 Oct 2018 08:31:36 +0000 (UTC) In-Reply-To: <20181012215218.5119-7-jose.souza@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?utf-8?Q?Jos=C3=A9?= Roberto de Souza , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAxMiBPY3QgMjAxOCwgSm9zw6kgUm9iZXJ0byBkZSBTb3V6YSA8am9zZS5zb3V6YUBp bnRlbC5jb20+IHdyb3RlOgo+IFRoaXMgJ2lmJ3Mgd2lsbCBhbHdheXMgYmUgZmFsc2UgYmVjYXVz ZSBvZiBwcmV2aW91cyBjaGFuZ2VzIHNvIGxldCdzCj4gZHJvcCB0aGVuLgoKSSBhbHNvIHRoaW5r IHRoaXMgd2lsbCBnYWluIGNsYXJpdHkgaWYgaTkxNV9sb2FkX21vZGVzZXRfaW5pdCgpIHN0YXJ0 cwp3aXRoIGVhcmx5IHJldHVybiBvbiBubyBkaXNwbGF5LgoKPgo+IFNpZ25lZC1vZmYtYnk6IEpv c8OpIFJvYmVydG8gZGUgU291emEgPGpvc2Uuc291emFAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jICAgICAgfCAxMiArKystLS0tLS0tLS0KPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYmlvcy5jICAgIHwgIDUgLS0tLS0KPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgIDMgLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2ZiZGV2LmMgICB8ICAzIC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9pMmMuYyAgICAgfCAgMyAtLS0KPiAgNSBmaWxlcyBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyks IDIzIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gaW5kZXggODMzNGQx Nzk3ZGY3Li5kNjlmYWY3MGRjZmQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPiBAQCAt NjQ1LDEyICs2NDUsOSBAQCBzdGF0aWMgaW50IGk5MTVfbG9hZF9tb2Rlc2V0X2luaXQoc3RydWN0 IGRybV9kZXZpY2UgKmRldikKPiAgCWlmIChpOTE1X2luamVjdF9sb2FkX2ZhaWx1cmUoKSkKPiAg CQlyZXR1cm4gLUVOT0RFVjsKPiAgCj4gLQlpZiAoSU5URUxfSU5GTyhkZXZfcHJpdiktPm51bV9w aXBlcykgewo+IC0JCXJldCA9IGRybV92YmxhbmtfaW5pdCgmZGV2X3ByaXYtPmRybSwKPiAtCQkJ CSAgICAgIElOVEVMX0lORk8oZGV2X3ByaXYpLT5udW1fcGlwZXMpOwo+IC0JCWlmIChyZXQpCj4g LQkJCWdvdG8gb3V0Owo+IC0JfQo+ICsJcmV0ID0gZHJtX3ZibGFua19pbml0KCZkZXZfcHJpdi0+ ZHJtLCBJTlRFTF9JTkZPKGRldl9wcml2KS0+bnVtX3BpcGVzKTsKPiArCWlmIChyZXQpCj4gKwkJ Z290byBvdXQ7Cj4gIAo+ICAJaW50ZWxfYmlvc19pbml0KGRldl9wcml2KTsKPiAgCj4gQEAgLTY4 Myw5ICs2ODAsNiBAQCBzdGF0aWMgaW50IGk5MTVfbG9hZF9tb2Rlc2V0X2luaXQoc3RydWN0IGRy bV9kZXZpY2UgKmRldikKPiAgCj4gIAlpbnRlbF9zZXR1cF9vdmVybGF5KGRldl9wcml2KTsKPiAg Cj4gLQlpZiAoSU5URUxfSU5GTyhkZXZfcHJpdiktPm51bV9waXBlcyA9PSAwKQo+IC0JCXJldHVy biAwOwo+IC0KPiAgCXJldCA9IGludGVsX2ZiZGV2X2luaXQoZGV2KTsKPiAgCWlmIChyZXQpCj4g IAkJZ290byBjbGVhbnVwX21vZGVzZXQ7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Jpb3MuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+IGlu ZGV4IDFmYWE0OTRlMmJjOS4uMWUwMjA1NTcyZmY5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Jpb3MuYwo+IEBAIC0xNzIxLDExICsxNzIxLDYgQEAgdm9pZCBpbnRlbF9iaW9zX2luaXQoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJY29uc3Qgc3RydWN0IGJkYl9oZWFk ZXIgKmJkYjsKPiAgCXU4IF9faW9tZW0gKmJpb3MgPSBOVUxMOwo+ICAKPiAtCWlmIChJTlRFTF9J TkZPKGRldl9wcml2KS0+bnVtX3BpcGVzID09IDApIHsKPiAtCQlEUk1fREVCVUdfS01TKCJTa2lw cGluZyBWQlQgaW5pdCBkdWUgdG8gZGlzYWJsZWQgZGlzcGxheS5cbiIpOwo+IC0JCXJldHVybjsK PiAtCX0KPiAtCgpJIG1pZ2h0IGxlYXZlIGluIGFzc2VydHMgc3VjaCBhcwoKCWlmIChXQVJOX09O KCFIQVNfRElTUExBWShkZXZfcHJpdikpKQogICAgICAgIAlyZXR1cm47CgppbiBtb3N0IHBsYWNl cyBhbnl3YXkuCgpCUiwKSmFuaS4KCgo+ICAJaW5pdF92YnRfZGVmYXVsdHMoZGV2X3ByaXYpOwo+ ICAKPiAgCS8qIElmIHRoZSBPcFJlZ2lvbiBkb2VzIG5vdCBoYXZlIFZCVCwgbG9vayBpbiBQQ0kg Uk9NLiAqLwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCAxZDA3ZmM0 MWQ0OTIuLmQzNjljNzMzNjI4NiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMKPiBAQCAtMTM5NTcsOSArMTM5NTcsNiBAQCBzdGF0aWMgdm9pZCBpbnRlbF9zZXR1cF9vdXRw dXRzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCj4gIAlpbnRlbF9wcHNf aW5pdChkZXZfcHJpdik7Cj4gIAo+IC0JaWYgKElOVEVMX0lORk8oZGV2X3ByaXYpLT5udW1fcGlw ZXMgPT0gMCkKPiAtCQlyZXR1cm47Cj4gLQo+ICAJLyoKPiAgCSAqIGludGVsX2VkcF9pbml0X2Nv bm5lY3RvcigpIGRlcGVuZHMgb24gdGhpcyBjb21wbGV0aW5nIGZpcnN0LCB0bwo+ICAJICogcHJl dmVudCB0aGUgcmVnaXN0ZXJhdGlvbiBvZiBib3RoIGVEUCBhbmQgTFZEUyBhbmQgdGhlIGluY29y cmVjdAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJkZXYuYwo+IGluZGV4IDI0ODBjN2Q2ZWRlZS4u NWVhZjFjMzUzMzJiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Zi ZGV2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jCj4gQEAgLTY3 Miw5ICs2NzIsNiBAQCBpbnQgaW50ZWxfZmJkZXZfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 KQo+ICAJc3RydWN0IGludGVsX2ZiZGV2ICppZmJkZXY7Cj4gIAlpbnQgcmV0Owo+ICAKPiAtCWlm IChXQVJOX09OKElOVEVMX0lORk8oZGV2X3ByaXYpLT5udW1fcGlwZXMgPT0gMCkpCj4gLQkJcmV0 dXJuIC1FTk9ERVY7Cj4gLQo+ICAJaWZiZGV2ID0ga3phbGxvYyhzaXplb2Yoc3RydWN0IGludGVs X2ZiZGV2KSwgR0ZQX0tFUk5FTCk7Cj4gIAlpZiAoaWZiZGV2ID09IE5VTEwpCj4gIAkJcmV0dXJu IC1FTk9NRU07Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2kyYy5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaTJjLmMKPiBpbmRleCAzM2Q4N2FiOTNmZGQu LjljMDVmN2FmNjhhNiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9p MmMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2kyYy5jCj4gQEAgLTgxNyw5 ICs4MTcsNiBAQCBpbnQgaW50ZWxfc2V0dXBfZ21idXMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2KQo+ICAJdW5zaWduZWQgaW50IHBpbjsKPiAgCWludCByZXQ7Cj4gIAo+IC0JaWYg KElOVEVMX0lORk8oZGV2X3ByaXYpLT5udW1fcGlwZXMgPT0gMCkKPiAtCQlyZXR1cm4gMDsKPiAt Cj4gIAlpZiAoSVNfVkFMTEVZVklFVyhkZXZfcHJpdikgfHwgSVNfQ0hFUlJZVklFVyhkZXZfcHJp dikpCj4gIAkJZGV2X3ByaXYtPmdwaW9fbW1pb19iYXNlID0gVkxWX0RJU1BMQVlfQkFTRTsKPiAg CWVsc2UgaWYgKCFIQVNfR01DSF9ESVNQTEFZKGRldl9wcml2KSkKCi0tIApKYW5pIE5pa3VsYSwg SW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=