From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] PCI: add support for Immediate Readiness
Date: Mon, 01 Oct 2018 08:42:18 +0300 [thread overview]
Message-ID: <87sh1q9q9x.fsf@linux.intel.com> (raw)
In-Reply-To: <20180928175718.GE18434@bhelgaas-glaptop.roam.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 1575 bytes --]
Bjorn Helgaas <helgaas@kernel.org> writes:
> On Fri, Sep 07, 2018 at 09:16:51AM +0300, Felipe Balbi wrote:
>> PCIe GEN4 defines, on section 7.5.1.1.4, a new bit on Status Register
>> which tells us that:
>>
>> "Immediate Readiness – This optional bit, when Set, indicates the
>> Function is guaranteed to be ready to successfully complete valid
>> configuration accesses at any time following any reset that the host
>> is capable of issuing Configuration Requests to this Function.
>>
>> When this bit is Set, for accesses to this Function, software is
>> exempt from all requirements to delay configuration accesses following
>> any type of reset, including but not limited to the timing
>> requirements defined in Section 6.6. How this guarantee is
>> established is beyond the scope of this document.
>>
>> It is permitted that system software/firmware provide mechanisms that
>> supersede the indication provided by this bit, however such
>> software/firmware mechanisms are outside the scope of this
>> specification."
>>
>> This means that all delays after a Conventional or Function Reset can
>> be skipped.
>>
>> This patch reads such bit and caches its value in a flag inside struct
>> pci_dev to be checked later if we should delay or can skip delays
>> after a reset. While at that, also move the explicit msleep(100) call
>> from pcie_flr() and pci_af_flr() to pci_dev_wait().
>>
>> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>
> Applied to pci/enumeration for v4.20, thanks!
Thank you
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2018-10-01 5:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 11:36 [RFC] PCI: add support for Immediate Readiness Felipe Balbi
2018-08-02 11:56 ` Christoph Hellwig
2018-08-02 12:11 ` Felipe Balbi
2018-08-03 6:14 ` Sinan Kaya
2018-08-03 6:26 ` Felipe Balbi
2018-08-03 17:25 ` Sinan Kaya
2018-09-04 18:11 ` Bjorn Helgaas
2018-09-05 5:18 ` Felipe Balbi
2018-09-05 5:23 ` Felipe Balbi
2018-09-05 5:29 ` Felipe Balbi
2018-09-05 16:49 ` Bjorn Helgaas
2018-09-05 16:54 ` Sinan Kaya
2018-09-06 6:02 ` Felipe Balbi
2018-09-06 14:13 ` Bjorn Helgaas
2018-09-07 6:16 ` [PATCH v2] " Felipe Balbi
2018-09-20 6:12 ` Felipe Balbi
2018-09-28 17:57 ` Bjorn Helgaas
2018-10-01 5:42 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh1q9q9x.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.