From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (146.0.238.70:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 24 Jul 2018 05:58:29 -0000 Received: from mx2.suse.de ([195.135.220.15] helo=mx1.suse.de) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1fhqL4-0003Jv-7y for speck@linutronix.de; Tue, 24 Jul 2018 07:58:28 +0200 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 3E27FACC1 for ; Tue, 24 Jul 2018 05:58:19 +0000 (UTC) From: Nicolai Stange Subject: [MODERATED] Re: [RFC PATCH 4/6] kvm: handle host mode irqs 4 References: <6815cf025aa41954f911a1e76c2415035307b00f.1532339695.git.nstange@suse.de> <20180723154021.GE35943@tassilo.jf.intel.com> Date: Tue, 24 Jul 2018 07:58:06 +0200 In-Reply-To: <20180723154021.GE35943@tassilo.jf.intel.com> (speck for Andi Kleen's message of "Mon, 23 Jul 2018 08:40:21 -0700") Message-ID: <87sh49xjip.fsf_-_@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: speck@linutronix.de List-ID: speck for Andi Kleen writes: >> +.macro TRACK_KERNEL_MODE_IRQ >> +#ifdef CONFIG_X86_TRACK_KERNEL_MODE_IRQS >> + /* >> + * Increment the kernel mode irq generation count even if >> + * coming from userspace -- nobody will care. >> + */ >> + incl PER_CPU_VAR(kernel_mode_irq_gen) >> +#endif >> +.endm > > You can put it into irq_enter/exit, no need to mess with assembler code. The reason I put it there was to avoid touching anything outside of arch/x86. In addition, - uv_bau_message_interrupt() doesn't call irq_enter() at all, - smp_reschedule_interrupt() calls it conditionally But I'm not sure it matters much and either way is fine by me. Thanks, Nicolai -- SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)