From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH v3 2/5] drm/i915: Combine tasklet_kill and tasklet_disable Date: Wed, 09 May 2018 16:54:04 +0300 Message-ID: <87sh719bpf.fsf@gaia.fi.intel.com> References: <20180509120419.6733-1-chris@chris-wilson.co.uk> <20180509120419.6733-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id C40FC6E84F for ; Wed, 9 May 2018 13:54:09 +0000 (UTC) In-Reply-To: <20180509120419.6733-2-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gSWRlYWxs eSwgd2Ugd2FudCB0byBhdG9taWNhbGx5IGZsdXNoIGFuZCBkaXNhYmxlIHRoZSB0YXNrbGV0IGJl Zm9yZQo+IHJlc2V0dGluZyB0aGUgR1BVLiBBdCBwcmVzZW50LCB3ZSByZWx5IG9uIGJlaW5nIHRo ZSBvbmx5IHBhcnQgdG8gdG91Y2gKPiBvdXIgdGFza2xldCBhbmQgc2VyaWFsaXNhdGlvbiBvZiB0 aGUgcmVzZXQgcHJvY2VzcyB0byBlbnN1cmUgdGhhdCB3ZSBjYW4KPiBzdXNwZW5kIHRoZSB0YXNr bGV0IGZyb20gdGhlIG1peCBvZiByZXNldC93ZWRnZSBwYXRod2F5cy4gSW4gdGhpcyBwYXRjaCwK PiB3ZSBtb3ZlIHRoZSB0YXNrbGV0IGFidXNlIGludG8gaXRzIG93biBmdW5jdGlvbiBhbmQgdHdl YWsgaXQgc3VjaCB0aGF0Cj4gd2Ugb25seSBkbyBhIHN5bmNocm9ub3VzIG9wZXJhdGlvbiB0aGUg Zmlyc3QgdGltZSBpdCBpcyBkaXNhYmxlZCBhcm91bmQKPiB0aGUgcmVzZXQuIFRoaXMgYWxsb3dz IHVzIHRvIGF2b2lkIHRoZSBzeW5jIGluc2lkZSBhIHNvZnRpcnEgY29udGV4dCBpbgo+IHN1YnNl cXVlbnQgcGF0Y2hlcy4KPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hy aXMtd2lsc29uLmNvLnVrPgo+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50 ZWwuY29tPgo+IENjOiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNv bT4KPiBDYzogTWljaGHFgiBXaW5pYXJza2kgPG1pY2hhbC53aW5pYXJza2lAaW50ZWwuY29tPgo+ IENDOiBNaWNoZWwgVGhpZXJyeSA8bWljaGVsLnRoaWVycnlAaW50ZWwuY29tPgo+IENjOiBKZWZm IE1jR2VlIDxqZWZmLm1jZ2VlQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW0uYyAgICAgICAgfCAgMiAtLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X3Rhc2tsZXQuaCAgICB8IDE0ICsrKysrKysrKysrKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2VuZ2luZV9jcy5jIHwgIDQgKystLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDE2IGluc2Vy dGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBpbmRl eCA5ODQ4MWUxNTBlNjEuLjhkMjdlNzhiMDUyYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0u Ywo+IEBAIC0zMDQzLDggKzMwNDMsNiBAQCBpOTE1X2dlbV9yZXNldF9wcmVwYXJlX2VuZ2luZShz dHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gIAkgKiBjb21tb24gY2FzZSBvZiByZWN1 cnNpdmVseSBiZWluZyBjYWxsZWQgZnJvbSBzZXQtd2VkZ2VkIGZyb20gaW5zaWRlCj4gIAkgKiBp OTE1X3Jlc2V0Lgo+ICAJICovCj4gLQlpZiAoaTkxNV90YXNrbGV0X2lzX2VuYWJsZWQoJmVuZ2lu ZS0+ZXhlY2xpc3RzLnRhc2tsZXQpKQo+IC0JCWk5MTVfdGFza2xldF9mbHVzaCgmZW5naW5lLT5l eGVjbGlzdHMudGFza2xldCk7Cj4gIAlpOTE1X3Rhc2tsZXRfZGlzYWJsZSgmZW5naW5lLT5leGVj bGlzdHMudGFza2xldCk7Cj4gIAo+ICAJLyoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV90YXNrbGV0LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Rhc2tsZXQu aAo+IGluZGV4IGM5ZjQxYTVlYmI5MS4uZDgyNjM4OTJmMzg1IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfdGFza2xldC5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV90YXNrbGV0LmgKPiBAQCAtNTksMTAgKzU5LDI0IEBAIHN0YXRpYyBpbmxpbmUgdm9p ZCBpOTE1X3Rhc2tsZXRfZW5hYmxlKHN0cnVjdCBpOTE1X3Rhc2tsZXQgKnQpCj4gIH0KPiAgCj4g IHN0YXRpYyBpbmxpbmUgdm9pZCBpOTE1X3Rhc2tsZXRfZGlzYWJsZShzdHJ1Y3QgaTkxNV90YXNr bGV0ICp0KQo+ICt7Cj4gKwlpZiAoaTkxNV90YXNrbGV0X2lzX2VuYWJsZWQodCkpCj4gKwkJaTkx NV90YXNrbGV0X2ZsdXNoKHQpOwoKVGhpcyBuZWVkcyBhIGNvbW1lbnQgdG8gZXhwbGFpbiBob3cg d2UgY2FuIGdldCBhd2F5IHdpdGgKdGhlIHJhY2UuCgo+ICsKPiArCWlmIChhdG9taWNfaW5jX3Jl dHVybigmdC0+YmFzZS5jb3VudCkgPT0gMSkKPiArCQl0YXNrbGV0X3VubG9ja193YWl0KCZ0LT5i YXNlKTsKCkkgd291bGQgYWRkIGNvbW1lbnQgaW4gaGVyZSB0b28uCi8qIE5vIG5lZWQgdG8gc3lu YyBvbiBmdXJ0aGVyIGRpc2FibGVzICovCgotTWlrYQoKPiArfQo+ICsKPiArc3RhdGljIGlubGlu ZSB2b2lkIGk5MTVfdGFza2xldF9sb2NrKHN0cnVjdCBpOTE1X3Rhc2tsZXQgKnQpCj4gIHsKPiAg CXRhc2tsZXRfZGlzYWJsZSgmdC0+YmFzZSk7Cj4gIH0KPiAgCj4gK3N0YXRpYyBpbmxpbmUgdm9p ZCBpOTE1X3Rhc2tsZXRfdW5sb2NrKHN0cnVjdCBpOTE1X3Rhc2tsZXQgKnQpCj4gK3sKPiArCXRh c2tsZXRfZW5hYmxlKCZ0LT5iYXNlKTsKPiArfQo+ICsKPiAgc3RhdGljIGlubGluZSB2b2lkIGk5 MTVfdGFza2xldF9zZXRfZnVuYyhzdHJ1Y3QgaTkxNV90YXNrbGV0ICp0LAo+ICAJCQkJCSB2b2lk ICgqZnVuYykodW5zaWduZWQgbG9uZyBkYXRhKSwKPiAgCQkJCQkgdW5zaWduZWQgbG9uZyBkYXRh KQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jCj4gaW5kZXggNWYxMTE4ZWE5 NmQ4Li4zYzhhMGMzMjQ1ZjMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZW5naW5lX2NzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVf Y3MuYwo+IEBAIC0xNDc4LDcgKzE0NzgsNyBAQCBpbnQgaW50ZWxfZW5hYmxlX2VuZ2luZV9zdGF0 cyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gIAlpZiAoIWludGVsX2VuZ2luZV9z dXBwb3J0c19zdGF0cyhlbmdpbmUpKQo+ICAJCXJldHVybiAtRU5PREVWOwo+ICAKPiAtCWk5MTVf dGFza2xldF9kaXNhYmxlKCZleGVjbGlzdHMtPnRhc2tsZXQpOwo+ICsJaTkxNV90YXNrbGV0X2xv Y2soJmV4ZWNsaXN0cy0+dGFza2xldCk7CgpBZnRlciB0aGUgaW5pdGlhbCBzaG9jaywgdGhlICps b2NrIHN0YXJ0cyB0byBmaXQuCi1NaWthCgo+ICAJd3JpdGVfc2VxbG9ja19pcnFzYXZlKCZlbmdp bmUtPnN0YXRzLmxvY2ssIGZsYWdzKTsKPiAgCj4gIAlpZiAodW5saWtlbHkoZW5naW5lLT5zdGF0 cy5lbmFibGVkID09IH4wKSkgewo+IEBAIC0xNTA0LDcgKzE1MDQsNyBAQCBpbnQgaW50ZWxfZW5h YmxlX2VuZ2luZV9zdGF0cyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gIAo+ICB1 bmxvY2s6Cj4gIAl3cml0ZV9zZXF1bmxvY2tfaXJxcmVzdG9yZSgmZW5naW5lLT5zdGF0cy5sb2Nr LCBmbGFncyk7Cj4gLQlpOTE1X3Rhc2tsZXRfZW5hYmxlKCZleGVjbGlzdHMtPnRhc2tsZXQpOwo+ ICsJaTkxNV90YXNrbGV0X3VubG9jaygmZXhlY2xpc3RzLT50YXNrbGV0KTsKPiAgCj4gIAlyZXR1 cm4gZXJyOwo+ICB9Cj4gLS0gCj4gMi4xNy4wCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=