From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f4NV1-0001qU-G1 for ath10k@lists.infradead.org; Fri, 06 Apr 2018 09:17:37 +0000 From: Kalle Valo Subject: Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets References: <20180226084406.2093-1-s.gottschall@dd-wrt.com> <871sftemru.fsf@kamboji.qca.qualcomm.com> <1d917688-9f59-39ad-46a6-527d9e3dec03@dd-wrt.com> <87d0zcsqmv.fsf@codeaurora.org> <41fa794e-d5d5-004e-5403-1e14c77a567a@dd-wrt.com> <87sh88rbba.fsf@codeaurora.org> Date: Fri, 06 Apr 2018 12:17:17 +0300 In-Reply-To: (Sebastian Gottschall's message of "Fri, 6 Apr 2018 10:27:26 +0200") Message-ID: <87sh88d78i.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Sebastian Gottschall Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org KGFkZGluZyBiYWNrIGxpc3RzKQoKU2ViYXN0aWFuIEdvdHRzY2hhbGwgPHMuZ290dHNjaGFsbEBk ZC13cnQuY29tPiB3cml0ZXM6Cgo+IEFtIDA2LjA0LjIwMTggdW0gMTA6MjUgc2NocmllYiBLYWxs ZSBWYWxvOgo+PiBTZWJhc3RpYW4gR290dHNjaGFsbCA8cy5nb3R0c2NoYWxsQGRkLXdydC5jb20+ IHdyaXRlczoKPj4KPj4+IEFtIDA2LjA0LjIwMTggdW0gMTA6MDkgc2NocmllYiBLYWxsZSBWYWxv Ogo+Pj4+IChhZGRpbmcgYmFjayB0aGUgbGlzdHMsIHBsZWFzZSBkb24ndCB0b3AgcG9zdCBhbmQg dHJpbSB5b3VyIHF1b3RlcykKPj4+Pgo+Pj4+IFNlYmFzdGlhbiBHb3R0c2NoYWxsIDxzLmdvdHRz Y2hhbGxAZGQtd3J0LmNvbT4gd3JpdGVzOgo+Pj4+Cj4+Pj4+IG9rYXkuIGF0aDEway1jaGVjayBp cyBidWdneSBhbmQgZG9lc250IHdvcmsuIHNvIGl0IGRvZXNudCBoZWxwIG11Y2gKPj4+Pj4gd2l0 aCBjb2RlIHN0eWxlcwo+Pj4+Pgo+Pj4+PiByb290QHNlZy1kZXNrdG9wOi94ZnMvYXRoMTBrL2F0 aC5ncGlvIyAuL2F0aDEway1jaGVjawo+Pj4+PiBnbG9iYWw6ICdkcml2ZXJzL25ldC93aXJlbGVz cy9hdGgvYXRoMTBrL0tjb25maWcnIGlzIG5vdCBhIHNvdXJjZSBmaWxlLgo+Pj4+PiBUcmFjZWJh Y2sgKG1vc3QgcmVjZW50IGNhbGwgbGFzdCk6Cj4+Pj4+ICAgwqAgRmlsZSAiLi9hdGgxMGstY2hl Y2siLCBsaW5lIDQ2MSwgaW4gPG1vZHVsZT4KPj4+Pj4gICDCoMKgwqAgbWFpbigpCj4+Pj4+ICAg wqAgRmlsZSAiLi9hdGgxMGstY2hlY2siLCBsaW5lIDQ1NSwgaW4gbWFpbgo+Pj4+PiAgIMKgwqDC oCByZXQgPSBydW5fY2hlY2twYXRjaChhcmdzKQo+Pj4+PiAgIMKgIEZpbGUgIi4vYXRoMTBrLWNo ZWNrIiwgbGluZSAyNzUsIGluIHJ1bl9jaGVja3BhdGNoCj4+Pj4+ICAgwqDCoMKgIG91dHB1dCA9 IHN1YnByb2Nlc3MuY2hlY2tfb3V0cHV0KGNtZCwgc2hlbGw9VHJ1ZSkKPj4+Pj4gICDCoCBGaWxl ICIvdXNyL2xpYi9weXRob24yLjcvc3VicHJvY2Vzcy5weSIsIGxpbmUgMjE5LCBpbiBjaGVja19v dXRwdXQKPj4+Pj4gICDCoMKgwqAgcmFpc2UgQ2FsbGVkUHJvY2Vzc0Vycm9yKHJldGNvZGUsIGNt ZCwgb3V0cHV0PW91dHB1dCkKPj4+Pj4gc3VicHJvY2Vzcy5DYWxsZWRQcm9jZXNzRXJyb3I6IENv bW1hbmQgJ2dsb2JhbCAtZgo+Pj4+PiBkcml2ZXJzL25ldC93aXJlbGVzcy9hdGgvYXRoMTBrL0tj b25maWcnIHJldHVybmVkIG5vbi16ZXJvIGV4aXQgc3RhdHVzIDEKPj4+PiBZb3UgYXJlIG1pc3Np bmcgZ3RhZ3MsIHNlZSAnYXRoMTBrLWNoZWNrIC0taGVscCcgZm9yIGhvdyB0byBpbnN0YWxsOgo+ Pj4+Cj4+Pj4gUmVxdWlyZW1lbnRzIChhbGwgYXZhaWxhYmxlIGluICRQQVRIKToKPj4+Pgo+Pj4+ ICogZ2NjCj4+Pj4gKiBzcGFyc2UKPj4+PiAqIGNoZWNrcGF0Y2gucGwKPj4+PiAqIGd0YWdzIChm cm9tIHBhY2thZ2UgZ2xvYmFsKQo+Pj4gYWhtIGkgZGlkIHJlYWQgdGhpcyBhbmQgdGhpcyB3YXMg YWxsIGluc3RhbGxlZC4gYnV0IGF0aDEway1jaGVjawo+Pj4gcmVmdXNlcyB0byB3b3JrCj4+Pgo+ Pj4gcm9vdEBzZWctZGVza3RvcDovaG9tZS9zZWcvREVWIyBndGFncyAtLXZlcnNpb24KPj4+IGd0 YWdzIChHTlUgR0xPQkFMKSA2LjUuNwo+Pj4gQ29weXJpZ2h0IChjKSAxOTk2LTIwMTcgVGFtYSBD b21tdW5pY2F0aW9ucyBDb3Jwb3JhdGlvbgo+Pj4gTGljZW5zZSBHUEx2Mys6IEdOVSBHUEwgdmVy c2lvbiAzIG9yIGxhdGVyCj4+PiA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzL2dwbC5odG1s Pgo+Pj4gVGhpcyBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgYXJlIGZyZWUgdG8gY2hhbmdlIGFuZCBy ZWRpc3RyaWJ1dGUgaXQuCj4+PiBUaGVyZSBpcyBOTyBXQVJSQU5UWSwgdG8gdGhlIGV4dGVudCBw ZXJtaXR0ZWQgYnkgbGF3Lgo+PiBEYW1uLCBJIGd1ZXNzIHNvbWV0aGluZyBoYXMgY2hhbmdlZCBp biBndGFncyBhcyBJIHVzZSBvbGRlciB2ZXJzaW9uOgo+Pgo+PiBndGFncyAtIEdOVSBHTE9CQUwg NS43LjEKPgo+IG9rYXkuIGkgd2lsbCB0cnkgdG8gdXNlIGEgb2xkZXIgdmVyc2lvbiBhbmQgc2Vl IHdoYXQgaGFwcGVucwoKWW91IGNhbiBhbHNvIHJ1biBjaGVja3BhdGNoIG1hbnVhbGx5IChzb3Jy eSBmb3IgdGhlIGxvbmcgbGluZSk6CgpjaGVja3BhdGNoLnBsIC0tc3RyaWN0IC1xIC0tdGVyc2Ug LS1uby1zdW1tYXJ5IC0tbWF4LWxpbmUtbGVuZ3RoPTkwIC0tc2hvdy10eXBlcyAtLWlnbm9yZSBN U0xFRVAsVVNMRUVQX1JBTkdFLFBSSU5US19XSVRIT1VUX0tFUk5fTEVWRUwsTkVUV09SS0lOR19C TE9DS19DT01NRU5UX1NUWUxFLExJTlVYX1ZFUlNJT05fQ09ERSxDT01QTEVYX01BQ1JPLFBSRUZF Ul9ERVZfTEVWRUwsUFJFRkVSX1BSX0xFVkVMLENPTVBBUklTT05fVE9fTlVMTCxCSVRfTUFDUk8s Q09OU1RBTlRfQ09NUEFSSVNPTixNQUNST19XSVRIX0ZMT1dfQ09OVFJPTCxDT05TVF9TVFJVQ1Qs TUFDUk9fQVJHX1JFVVNFLE1BQ1JPX0FSR19QUkVDRURFTkNFIGZvby5wYXRjaAoKSSBtb2RpZmll ZCBhdGgxMGstY2hlY2sgLS1oZWxwIHRvIHByaW50IHRoZSBmdWxsIGNvbW1hbmRsaW5lLCBqdXN0 CmhhdmVuJ3QgcHVzaGVkIGl0IG91dCB5ZXQuCgotLSAKS2FsbGUgVmFsbwoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYXRoMTBrIG1haWxpbmcgbGlzdAph dGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2F0aDEwawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:34472 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751329AbeDFJRY (ORCPT ); Fri, 6 Apr 2018 05:17:24 -0400 From: Kalle Valo To: Sebastian Gottschall Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets References: <20180226084406.2093-1-s.gottschall@dd-wrt.com> <871sftemru.fsf@kamboji.qca.qualcomm.com> <1d917688-9f59-39ad-46a6-527d9e3dec03@dd-wrt.com> <87d0zcsqmv.fsf@codeaurora.org> <41fa794e-d5d5-004e-5403-1e14c77a567a@dd-wrt.com> <87sh88rbba.fsf@codeaurora.org> Date: Fri, 06 Apr 2018 12:17:17 +0300 In-Reply-To: (Sebastian Gottschall's message of "Fri, 6 Apr 2018 10:27:26 +0200") Message-ID: <87sh88d78i.fsf@kamboji.qca.qualcomm.com> (sfid-20180406_111728_810903_97D67F10) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: (adding back lists) Sebastian Gottschall writes: > Am 06.04.2018 um 10:25 schrieb Kalle Valo: >> Sebastian Gottschall writes: >> >>> Am 06.04.2018 um 10:09 schrieb Kalle Valo: >>>> (adding back the lists, please don't top post and trim your quotes) >>>> >>>> Sebastian Gottschall writes: >>>> >>>>> okay. ath10k-check is buggy and doesnt work. so it doesnt help much >>>>> with code styles >>>>> >>>>> root@seg-desktop:/xfs/ath10k/ath.gpio# ./ath10k-check >>>>> global: 'drivers/net/wireless/ath/ath10k/Kconfig' is not a source fil= e. >>>>> Traceback (most recent call last): >>>>> =C2=A0 File "./ath10k-check", line 461, in >>>>> =C2=A0=C2=A0=C2=A0 main() >>>>> =C2=A0 File "./ath10k-check", line 455, in main >>>>> =C2=A0=C2=A0=C2=A0 ret =3D run_checkpatch(args) >>>>> =C2=A0 File "./ath10k-check", line 275, in run_checkpatch >>>>> =C2=A0=C2=A0=C2=A0 output =3D subprocess.check_output(cmd, shell=3D= True) >>>>> =C2=A0 File "/usr/lib/python2.7/subprocess.py", line 219, in check_= output >>>>> =C2=A0=C2=A0=C2=A0 raise CalledProcessError(retcode, cmd, output=3D= output) >>>>> subprocess.CalledProcessError: Command 'global -f >>>>> drivers/net/wireless/ath/ath10k/Kconfig' returned non-zero exit statu= s 1 >>>> You are missing gtags, see 'ath10k-check --help' for how to install: >>>> >>>> Requirements (all available in $PATH): >>>> >>>> * gcc >>>> * sparse >>>> * checkpatch.pl >>>> * gtags (from package global) >>> ahm i did read this and this was all installed. but ath10k-check >>> refuses to work >>> >>> root@seg-desktop:/home/seg/DEV# gtags --version >>> gtags (GNU GLOBAL) 6.5.7 >>> Copyright (c) 1996-2017 Tama Communications Corporation >>> License GPLv3+: GNU GPL version 3 or later >>> >>> This is free software; you are free to change and redistribute it. >>> There is NO WARRANTY, to the extent permitted by law. >> Damn, I guess something has changed in gtags as I use older version: >> >> gtags - GNU GLOBAL 5.7.1 > > okay. i will try to use a older version and see what happens You can also run checkpatch manually (sorry for the long line): checkpatch.pl --strict -q --terse --no-summary --max-line-length=3D90 --sho= w-types --ignore MSLEEP,USLEEP_RANGE,PRINTK_WITHOUT_KERN_LEVEL,NETWORKING_B= LOCK_COMMENT_STYLE,LINUX_VERSION_CODE,COMPLEX_MACRO,PREFER_DEV_LEVEL,PREFER= _PR_LEVEL,COMPARISON_TO_NULL,BIT_MACRO,CONSTANT_COMPARISON,MACRO_WITH_FLOW_= CONTROL,CONST_STRUCT,MACRO_ARG_REUSE,MACRO_ARG_PRECEDENCE foo.patch I modified ath10k-check --help to print the full commandline, just haven't pushed it out yet. --=20 Kalle Valo