From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/2] drm/i915: Fix memory leak in intel_hdcp auth Date: Wed, 04 Apr 2018 15:04:07 +0300 Message-ID: <87sh8bfaa0.fsf@intel.com> References: <20180404000456.1407-1-radhakrishna.sripada@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id B29706E34A for ; Wed, 4 Apr 2018 12:03:19 +0000 (UTC) In-Reply-To: <20180404000456.1407-1-radhakrishna.sripada@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Radhakrishna Sripada , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAwMyBBcHIgMjAxOCwgUmFkaGFrcmlzaG5hIFNyaXBhZGEgPHJhZGhha3Jpc2huYS5z cmlwYWRhQGludGVsLmNvbT4gd3JvdGU6Cj4gU3RhdGljIGNvZGUgYW5hbHlzaXMgdG9vbCByZXBv cnRlZCBtZW1vcnkgbGVhayBpbgo+IGludGVsX2hkY3BfYXV0aF9kb3duc3RyZWFtLiBGaXhpbmcg dGhlIG1lbW9yeSBsZWFrLgo+Cj4gQ2M6IEFudXNoYSBTcml2YXRzYSA8YW51c2hhLnNyaXZhdHNh QGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBSYWRoYWtyaXNobmEgU3JpcGFkYSA8cmFkaGFr cmlzaG5hLnNyaXBhZGFAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9oZGNwLmMgfCAxOSArKysrKysrKysrKysrKystLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAx NSBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2hkY3AuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2hk Y3AuYwo+IGluZGV4IDE0Y2E1ZDMwNTdhNy4uY2U3NzFmNmMxYTVhIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2hkY3AuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2hkY3AuYwo+IEBAIC0xODYsMTQgKzE4NiwxOCBAQCBpbnQgaW50ZWxfaGRjcF9h dXRoX2Rvd25zdHJlYW0oc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQs Cj4gIAkJcmV0dXJuIC1FTk9NRU07Cj4gIAo+ICAJcmV0ID0gc2hpbS0+cmVhZF9rc3ZfZmlmbyhp bnRlbF9kaWdfcG9ydCwgbnVtX2Rvd25zdHJlYW0sIGtzdl9maWZvKTsKPiAtCWlmIChyZXQpCj4g KwlpZiAocmV0KSB7Cj4gKwkJa2ZyZWUoa3N2X2ZpZm8pOwoKUGxlYXNlIGFkZCBhbiBzaW5nbGUg Y2xlYW51cCBsYWJlbCBhbmQgZ290byBpdCBmcm9tIGFsbCBlcnJvciBwYXRocy4KCkJSLApKYW5p LgoKCj4gIAkJcmV0dXJuIHJldDsKPiArCX0KPiAgCj4gIAkvKiBQcm9jZXNzIFYnIHZhbHVlcyBm cm9tIHRoZSByZWNlaXZlciAqLwo+ICAJZm9yIChpID0gMDsgaSA8IERSTV9IRENQX1ZfUFJJTUVf TlVNX1BBUlRTOyBpKyspIHsKPiAgCQlyZXQgPSBzaGltLT5yZWFkX3ZfcHJpbWVfcGFydChpbnRl bF9kaWdfcG9ydCwgaSwgJnZwcmltZSk7Cj4gLQkJaWYgKHJldCkKPiArCQlpZiAocmV0KSB7Cj4g KwkJCWtmcmVlKGtzdl9maWZvKTsKPiAgCQkJcmV0dXJuIHJldDsKPiArCQl9Cj4gIAkJSTkxNV9X UklURShIRENQX1NIQV9WX1BSSU1FKGkpLCB2cHJpbWUpOwo+ICAJfQo+ICAKPiBAQCAtMjIyLDgg KzIyNiwxMCBAQCBpbnQgaW50ZWxfaGRjcF9hdXRoX2Rvd25zdHJlYW0oc3RydWN0IGludGVsX2Rp Z2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQsCj4gIAkJCXNoYV90ZXh0IHw9IGtzdltqXSA8PCAo KHNpemVvZihzaGFfdGV4dCkgLSBqIC0gMSkgKiA4KTsKPiAgCj4gIAkJcmV0ID0gaW50ZWxfd3Jp dGVfc2hhX3RleHQoZGV2X3ByaXYsIHNoYV90ZXh0KTsKPiAtCQlpZiAocmV0IDwgMCkKPiArCQlp ZiAocmV0IDwgMCkgewo+ICsJCQlrZnJlZShrc3ZfZmlmbyk7Cj4gIAkJCXJldHVybiByZXQ7Cj4g KwkJfQo+ICAKPiAgCQkvKiBQcm9ncmFtbWluZyBndWlkZSB3cml0ZXMgdGhpcyBldmVyeSA2NCBi eXRlcyAqLwo+ICAJCXNoYV9pZHggKz0gc2l6ZW9mKHNoYV90ZXh0KTsKPiBAQCAtMjQ1LDEzICsy NTEsMTggQEAgaW50IGludGVsX2hkY3BfYXV0aF9kb3duc3RyZWFtKHN0cnVjdCBpbnRlbF9kaWdp dGFsX3BvcnQgKmludGVsX2RpZ19wb3J0LAo+ICAJCQljb250aW51ZTsKPiAgCj4gIAkJcmV0ID0g aW50ZWxfd3JpdGVfc2hhX3RleHQoZGV2X3ByaXYsIHNoYV90ZXh0KTsKPiAtCQlpZiAocmV0IDwg MCkKPiArCQlpZiAocmV0IDwgMCkgewo+ICsJCQlrZnJlZShrc3ZfZmlmbyk7Cj4gIAkJCXJldHVy biByZXQ7Cj4gKwkJfQo+ICsKPiAgCQlzaGFfbGVmdG92ZXJzID0gMDsKPiAgCQlzaGFfdGV4dCA9 IDA7Cj4gIAkJc2hhX2lkeCArPSBzaXplb2Yoc2hhX3RleHQpOwo+ICAJfQo+ICAKPiArCWtmcmVl KGtzdl9maWZvKTsKPiArCj4gIAkvKgo+ICAJICogV2UgbmVlZCB0byB3cml0ZSBCSU5GTy9CU1RB VFVTLCBhbmQgTTAgbm93LiBEZXBlbmRpbmcgb24gaG93IG1hbnkKPiAgCSAqIGJ5dGVzIGFyZSBs ZWZ0b3ZlciBmcm9tIHRoZSBsYXN0IGtzdiwgd2UgbWlnaHQgYmUgYWJsZSB0byBmaXQgdGhlbQoK LS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK