All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: Dylan Baker <dylan@pnwbakers.com>,
	Eric Engestrom <eric.engestrom@imgtec.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH libdrm] meson: add configuration summary
Date: Tue, 27 Feb 2018 12:30:48 -0800	[thread overview]
Message-ID: <87sh9mb2fb.fsf@anholt.net> (raw)
In-Reply-To: <151975177593.18067.13224393958188782022@localhost.localdomain>


[-- Attachment #1.1: Type: text/plain, Size: 1764 bytes --]

Dylan Baker <dylan@pnwbakers.com> writes:

> [ Unknown signature status ]
> Quoting Eric Engestrom (2018-02-27 03:11:07)
>> The message block printed is the same as the one in configure.ac
>> 
>> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
>> ---
>>  meson.build | 17 +++++++++++++++++
>>  1 file changed, 17 insertions(+)
>> 
>> diff --git a/meson.build b/meson.build
>> index bd00cdc2cae9f0749180..ab6f881755935968b822 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -373,3 +373,20 @@ if with_man_pages
>>  endif
>>  subdir('data')
>>  subdir('tests')
>> +
>> +message('')
>> +message('@0@ will be compiled with:'.format(meson.project_name()))
>> +message('')
>> +message('  libkms         @0@'.format(with_libkms))
>> +message('  Intel API      @0@'.format(with_intel))
>> +message('  vmwgfx API     @0@'.format(with_vmwgfx))
>> +message('  Radeon API     @0@'.format(with_radeon))
>> +message('  AMDGPU API     @0@'.format(with_amdgpu))
>> +message('  Nouveau API    @0@'.format(with_nouveau))
>> +message('  OMAP API       @0@'.format(with_omap))
>> +message('  EXYNOS API     @0@'.format(with_exynos))
>> +message('  Freedreno API  @0@ (kgsl: @1@)'.format(with_freedreno, with_freedreno_kgsl))
>> +message('  Tegra API      @0@'.format(with_tegra))
>> +message('  VC4 API        @0@'.format(with_vc4))
>> +message('  Etnaviv API    @0@'.format(with_etnaviv))
>> +message('')
>> -- 
>> Cheers,
>>   Eric
>> 
>
> This one is certainly simple enough that we can use a single message call and a
> ''' string :)

But then you end up with 13 @n@ values and when someone wants to put
something earlier in the list for some sorting reason, then they need to
renumber the rest.  This is much nicer.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-02-27 20:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-27 11:11 [PATCH libdrm] meson: add configuration summary Eric Engestrom
2018-02-27 17:16 ` Dylan Baker
2018-02-27 20:30   ` Eric Anholt [this message]
2018-02-28 15:11     ` Eric Engestrom
2018-02-28 17:41       ` Dylan Baker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sh9mb2fb.fsf@anholt.net \
    --to=eric@anholt.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=dylan@pnwbakers.com \
    --cc=eric.engestrom@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.