From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from [2001:470:dc45:1000::1] (helo=mail.toke.dk) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eDtRL-00086r-Vg for ath10k@lists.infradead.org; Sun, 12 Nov 2017 14:40:53 +0000 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [PATCH v2] ath10k: Re-enable TXQs for all devices In-Reply-To: References: <20171110004839.7478-1-toke@toke.dk> Date: Sun, 12 Nov 2017 23:40:12 +0900 Message-ID: <87shdjpnlf.fsf@toke.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Felix Fietkau , make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org RmVsaXggRmlldGthdSA8bmJkQG5iZC5uYW1lPiB3cml0ZXM6Cgo+IE9uIDIwMTctMTEtMTAgMDE6 NDgsIFRva2UgSMO4aWxhbmQtSsO4cmdlbnNlbiB3cm90ZToKPj4gQ29tbWl0IDRjYTE4MDc4MTVh YTY4MDFhYWNlZDdmZGVmYTllZGFjYzI1MjE3NjcgZGlzYWJsZXMgdGhlIHVzZSBvZiB0aGUKPj4g bWFjODAyMTEgVFhRcyBmb3Igc29tZSBkZXZpY2VzIGJlY2F1c2Ugb2YgYSB0aGVvcmV0aWNhbCB0 aHJvdWdocHV0Cj4+IHJlZ3Jlc3Npb24uIFRoZSBvcmlnaW5hbCByZWdyZXNzaW9uIHJlcG9ydFsx XSB3YXMgcmVsYXRlZCB0byBmcV9jb2RlbAo+PiBxZGlzYyBkcm9wIHBlcmZvcm1hbmNlLCB3aGlj aCB3YXMgZml4ZWQgaW4KPj4gOWQxODU2MmEyMjc4NzQyODlmZGE4Y2E1ZDExN2Q4ZjUwM2YxZGNj YS4gU2luY2UgdGhlbiwgd2UgaGF2ZSBub3Qgc2Vlbgo+PiB0aGUgVFhRLXJlbGF0ZWQgcmVncmVz c2lvbiwgc28gaXQgc2hvdWxkIGJlIHNhZmUgdG8gcmUtZW5hYmxlIFRYUXMuCj4gVGhhdCBjb21t aXQgaXMgdW5yZWxhdGVkIHRvIHRoZSBmcS9jb2RlbCBpbXBsZW1lbnRhdGlvbnMgaW4gbWFjODAy MTEsCj4gc2luY2UgbWFjODAyMTEgd2l0aCB0eHEgZG9lcyBub3QgdXNlIHFkaXNjLgoKWXVwLiBX aGljaCBpcyB3aHkgaXQncyBvZGQgdGhhdCB0aGUgaW5pdGlhbCBidWcgcmVwb3J0IHJlZmVycmVk IHRvIHRoaXM7CnRoYXQgd291bGQgaW5kaWNhdGUgdGhhdCB0aGUgcmVncmVzc2lvbiBoYWQgbm90 aGluZyB0byBkbyB3aXRoIFRYUXMgaW4KdGhlIGZpcnN0IHBsYWNlLCBhbmQgd2UgY291bGQgaGF2 ZSBtZXJnZWQgdGhpcyBhZ2VzIGFnbz8KCi1Ub2tlCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwphdGgxMGsgbWFpbGluZyBsaXN0CmF0aDEwa0BsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v YXRoMTBrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.toke.dk ([52.28.52.200]:38029 "EHLO mail.toke.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750953AbdKLOk1 (ORCPT ); Sun, 12 Nov 2017 09:40:27 -0500 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Felix Fietkau , make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: Re: [PATCH v2] ath10k: Re-enable TXQs for all devices In-Reply-To: References: <20171110004839.7478-1-toke@toke.dk> Date: Sun, 12 Nov 2017 23:40:12 +0900 Message-ID: <87shdjpnlf.fsf@toke.dk> (sfid-20171112_154031_764601_5AC105C8) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Felix Fietkau writes: > On 2017-11-10 01:48, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> Commit 4ca1807815aa6801aaced7fdefa9edacc2521767 disables the use of the >> mac80211 TXQs for some devices because of a theoretical throughput >> regression. The original regression report[1] was related to fq_codel >> qdisc drop performance, which was fixed in >> 9d18562a227874289fda8ca5d117d8f503f1dcca. Since then, we have not seen >> the TXQ-related regression, so it should be safe to re-enable TXQs. > That commit is unrelated to the fq/codel implementations in mac80211, > since mac80211 with txq does not use qdisc. Yup. Which is why it's odd that the initial bug report referred to this; that would indicate that the regression had nothing to do with TXQs in the first place, and we could have merged this ages ago? -Toke