Re: [PATCH] bcma: use bcma_debug and pr_cont in MIPS driver

[Kalle Valo <kvalo@codeaurora.org>]

Joe Perches <joe@perches.com> writes:

> On Mon, 2017-10-16 at 23:21 +0200, Hauke Mehrtens wrote:
>> On 10/16/2017 02:54 PM, Rafa=C5=82 Mi=C5=82ecki wrote:
>> > From: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
>> >=20
>> > Using bcma_debug gives a device-specific prefix for messages and pr_co=
nt
>> > is a common helper for continuing a line.
>> >=20
>> > Signed-off-by: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
>>=20
>> Acked-By: Hauke Mehrtens <hauke@hauke-m.de>
>>=20
>> > ---
>> >  drivers/bcma/driver_mips.c | 7 ++++---
>> >  1 file changed, 4 insertions(+), 3 deletions(-)
>> >=20
>> > diff --git a/drivers/bcma/driver_mips.c b/drivers/bcma/driver_mips.c
>> > index 89af807cf29c..5904ef1aa624 100644
>> > --- a/drivers/bcma/driver_mips.c
>> > +++ b/drivers/bcma/driver_mips.c
>> > @@ -184,10 +184,11 @@ static void bcma_core_mips_print_irq(struct bcma=
_device *dev, unsigned int irq)
>> >  {
>> >  	int i;
>> >  	static const char *irq_name[] =3D {"2(S)", "3", "4", "5", "6", "D", =
"I"};
>> > -	printk(KERN_DEBUG KBUILD_MODNAME ": core 0x%04x, irq :", dev->id.id);
>> > +
>> > +	bcma_debug(dev->bus, "core 0x%04x, irq :", dev->id.id);
>> >  	for (i =3D 0; i <=3D 6; i++)
>> > -		printk(" %s%s", irq_name[i], i =3D=3D irq ? "*" : " ");
>> > -	printk("\n");
>> > +		pr_cont(" %s%s", irq_name[i], i =3D=3D irq ? "*" : " ");
>> > +	pr_cont("\n");
>> >  }
>> >=20=20
>> >  static void bcma_core_mips_dump_irq(struct bcma_bus *bus)
>> >=20
>
> This isn't the same code as it depends on #define DEBUG
> and will not output the first line in most cases.
>
> I'd suggest a nack.

Too late, I already applied this. Please submit a followup patch if
something needs to be changed.

--=20
Kalle Valo