From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 9/9] disas: Add capstone as submodule
Date: Fri, 13 Oct 2017 08:50:13 +0100 [thread overview]
Message-ID: <87shena3m2.fsf@linaro.org> (raw)
In-Reply-To: <f185d9b4-bd5d-0294-bcfa-76214caa3167@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
> On 10/02/2017 10:43 AM, Alex Bennée wrote:
>>> + mkdir -p capstone
>>
>> Having a mkdir -p here seems a little out of place. Shouldn't the build
>> directory creation be handled by the make recipe?
>
> *shrug* We do this for the other directories at configure time.
fair enough.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>
>
> r~
--
Alex Bennée
next prev parent reply other threads:[~2017-10-13 7:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 16:54 [Qemu-devel] [PATCH v4 0/9] Support the Capstone disassembler Richard Henderson
2017-09-28 16:54 ` [Qemu-devel] [PATCH v4 1/9] target/i386: Convert to disas_set_info hook Richard Henderson
2017-10-02 12:56 ` Philippe Mathieu-Daudé
2017-09-28 16:54 ` [Qemu-devel] [PATCH v4 2/9] target/ppc: " Richard Henderson
2017-10-02 12:56 ` Philippe Mathieu-Daudé
2017-09-28 16:54 ` [Qemu-devel] [PATCH v4 3/9] disas: Remove unused flags arguments Richard Henderson
2017-10-02 12:56 ` Philippe Mathieu-Daudé
2017-09-28 16:54 ` [Qemu-devel] [PATCH v4 4/9] disas: Support the Capstone disassembler library Richard Henderson
2017-10-02 13:36 ` Philippe Mathieu-Daudé
2017-10-02 18:34 ` Richard Henderson
2017-10-02 18:45 ` Philippe Mathieu-Daudé
2017-10-03 1:51 ` Richard Henderson
2017-10-03 13:45 ` Philippe Mathieu-Daudé
2017-10-02 14:40 ` Alex Bennée
2017-10-02 18:31 ` Richard Henderson
2017-09-28 16:54 ` [Qemu-devel] [PATCH v4 5/9] i386: Support Capstone in disas_set_info Richard Henderson
2017-10-02 13:37 ` Philippe Mathieu-Daudé
2017-09-28 16:54 ` [Qemu-devel] [PATCH v4 6/9] arm: " Richard Henderson
2017-10-02 13:37 ` Philippe Mathieu-Daudé
2017-09-28 16:54 ` [Qemu-devel] [PATCH v4 7/9] ppc: " Richard Henderson
2017-10-02 13:56 ` Philippe Mathieu-Daudé
2017-09-28 16:54 ` [Qemu-devel] [PATCH v4 8/9] disas: Remove monitor_disas_is_physical Richard Henderson
2017-10-02 13:55 ` Philippe Mathieu-Daudé
2017-09-28 16:54 ` [Qemu-devel] [PATCH v4 9/9] disas: Add capstone as submodule Richard Henderson
2017-10-02 13:54 ` Philippe Mathieu-Daudé
2017-10-02 14:43 ` Alex Bennée
2017-10-02 18:27 ` Richard Henderson
2017-10-13 7:50 ` Alex Bennée [this message]
2017-10-12 12:34 ` [Qemu-devel] [PATCH v4 0/9] Support the Capstone disassembler Peter Maydell
2017-10-12 14:49 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shena3m2.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.