From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH v2] drm/i915: Drain the device workqueue on unload Date: Wed, 19 Jul 2017 14:18:47 +0300 Message-ID: <87shhs7jzc.fsf@gaia.fi.intel.com> References: <20170628153909.22493-1-chris@chris-wilson.co.uk> <20170718134124.14832-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id D2C146E449 for ; Wed, 19 Jul 2017 11:19:43 +0000 (UTC) In-Reply-To: <20170718134124.14832-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Matthew Auld List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gV29ya2Vy cyBvbiB0aGUgaTkxNS0+d3EgbWF5IHJlYXJtIHRoZW1zZWx2ZXMgc28gZm9yIGNvbXBsZXRlbmVz cyB3ZSBuZWVkCj4gdG8gcmVwbGFjZSBvdXIgZmx1c2hfd29ya3F1ZXVlKCkgd2l0aCBhIGNhbGwg dG8gZHJhaW5fd29ya3F1ZXVlKCkgYmVmb3JlCj4gdW5sb2FkaW5nIHRoZSBkZXZpY2UuCj4KPiB2 MjogUmVpbmZvcmNlIHRoZSBkcmFpbl93b3JrcXVldWUgd2l0aCBhbiBwcmVjZWVkaW5nIHJjdV9i YXJyaWVyKCkgYXMgYQo+IGZldyBvZiB0aGUgdGFza3MgdGhhdCBuZWVkIHRvIGJlIGRyYWluZWQg bWF5IGZpcnN0IGJlIGFybWVkIGJ5IFJDVS4KPgo+IFJlZmVyZW5jZXM6IGh0dHBzOi8vYnVncy5m cmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTYyNwo+IFNpZ25lZC1vZmYtYnk6IENo cmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBNYXR0aGV3IEF1bGQg PG1hdHRoZXcuYXVsZEBpbnRlbC5jb20+Cj4gQ2M6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBh bGFAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Ry di5jICAgICAgICAgICAgICAgICAgfCAgNiArKy0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9kcnYuaCAgICAgICAgICAgICAgICAgIHwgMjAgKysrKysrKysrKysrKysrKysrKysKPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL21vY2tfZ2VtX2RldmljZS5jIHwgIDIgKy0K PiAgMyBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+Cj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gaW5kZXggNGI2MmZkMDEyODc3Li40MWM1YjExYTdjOGYg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPiBAQCAtNTk2LDcgKzU5Niw4IEBAIHN0YXRp YyBjb25zdCBzdHJ1Y3QgdmdhX3N3aXRjaGVyb29fY2xpZW50X29wcyBpOTE1X3N3aXRjaGVyb29f b3BzID0gewo+ICAKPiAgc3RhdGljIHZvaWQgaTkxNV9nZW1fZmluaShzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYpCj4gIHsKPiAtCWZsdXNoX3dvcmtxdWV1ZShkZXZfcHJpdi0+d3Ep Owo+ICsJLyogRmx1c2ggYW55IG91dHN0YW5kaW5nIHVucGluX3dvcmsuICovCj4gKwlpOTE1X2dl bV9kcmFpbl93b3JrcXVldWUoZGV2X3ByaXYpOwo+ICAKPiAgCW11dGV4X2xvY2soJmRldl9wcml2 LT5kcm0uc3RydWN0X211dGV4KTsKPiAgCWludGVsX3VjX2ZpbmlfaHcoZGV2X3ByaXYpOwo+IEBA IC0xNDA5LDkgKzE0MTAsNiBAQCB2b2lkIGk5MTVfZHJpdmVyX3VubG9hZChzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2KQo+ICAJY2FuY2VsX2RlbGF5ZWRfd29ya19zeW5jKCZkZXZfcHJpdi0+Z3B1X2Vy cm9yLmhhbmdjaGVja193b3JrKTsKPiAgCWk5MTVfcmVzZXRfZXJyb3Jfc3RhdGUoZGV2X3ByaXYp Owo+ICAKPiAtCS8qIEZsdXNoIGFueSBvdXRzdGFuZGluZyB1bnBpbl93b3JrLiAqLwo+IC0JZHJh aW5fd29ya3F1ZXVlKGRldl9wcml2LT53cSk7Cj4gLQo+ICAJaTkxNV9nZW1fZmluaShkZXZfcHJp dik7Cj4gIAlpbnRlbF91Y19maW5pX2Z3KGRldl9wcml2KTsKPiAgCWludGVsX2ZiY19jbGVhbnVw X2NmYihkZXZfcHJpdik7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf ZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggNjY3ZmI1YzQ0 NDgzLi5lOWE0Yjk2ZGM3NzUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtMzMw MCw2ICszMzAwLDI2IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBpOTE1X2dlbV9kcmFpbl9mcmVlZF9v YmplY3RzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+ICAJfSB3aGlsZSAoZmx1c2hf d29yaygmaTkxNS0+bW0uZnJlZV93b3JrKSk7Cj4gIH0KPiAgCj4gK3N0YXRpYyBpbmxpbmUgdm9p ZCBpOTE1X2dlbV9kcmFpbl93b3JrcXVldWUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUp Cj4gK3sKPiArCS8qCj4gKwkgKiBTaW1pbGFyIHRvIG9iamVjdHMgYWJvdmUgKHNlZSBpOTE1X2dl bV9kcmFpbl9mcmVlZC1vYmplY3RzKSwgaW4KPiArCSAqIGdlbmVyYWwgd2UgaGF2ZSB3b3JrZXJz IHRoYXQgYXJlIGFybWVkIGJ5IFJDVSBhbmQgdGhlbiByZWFybQo+ICsJICogdGhlbXNlbHZlcyBp biB0aGVpciBjYWxsYmFja3MuIFRvIGJlIHBhcmFub2lkLCB3ZSBuZWVkIHRvCj4gKwkgKiBkcmFp biB0aGUgd29ya3F1ZXVlIGEgc2Vjb25kIHRpbWUgYWZ0ZXIgd2FpdGluZyBmb3IgdGhlIFJDVQo+ ICsJICogZ3JhY2UgcGVyaW9kIHNvIHRoYXQgd2UgY2F0Y2ggd29yayBxdWV1ZWQgdmlhIFJDVSBm cm9tIHRoZSBmaXJzdAo+ICsJICogcGFzcy4gQXMgbmVpdGhlciBkcmFpbl93b3JrcXVldWUoKSBu b3IgZmx1c2hfd29ya3F1ZXVlKCkgcmVwb3J0Cj4gKwkgKiBhIHJlc3VsdCwgd2UgbWFrZSBhbiBh c3N1bXB0aW9uIHRoYXQgd2Ugb25seSBkb24ndCByZXF1aXJlIG1vcmUKPiArCSAqIHRoYW4gMiBw YXNzZXMgdG8gY2F0Y2ggYWxsIHJlY3Vyc2l2ZSBSQ1UgZGVsYXllZCB3b3JrLgo+ICsJICoKPiAr CSAqLwo+ICsJaW50IHBhc3MgPSAyOwo+ICsJZG8gewo+ICsJCXJjdV9iYXJyaWVyKCk7Cj4gKwkJ ZHJhaW5fd29ya3F1ZXVlKGk5MTUtPndxKTsKCkkgYW0gZmluZSB3aXRoIHRoZSBwYXJhbm9pYSwg YW5kIGl0IGNvdmVycyB0aGUgY2FzZSBiZWxvdy4gU3RpbGwgaWYgd2UgZG86CgpkcmFpbl93b3Jr cXVldWUoKTsKcmN1X2JhcnJpZXIoKTsKCldpdGggZHJhd2luaW5nIGluIHByb2dyZXNzLCBvbmx5 IGNoYWluIHF1ZXVpbmcgaXMgYWxsb3dlZC4gSSB1bmRlcnN0YW5kCnRoaXMgc28gdGhhdCB3aGVu IGl0IHJldHVybnMsIGFsbCB0aGUgY3R4IHBvaW50ZXJzIGFyZSBub3cgdW5yZWZlcmVuY2VkCmJ1 dCBub3QgZnJlZWQuCgpUaHVzIHRoZSByY3VfYmFycmllcigpIGFmdGVyIGl0IGNsZWFucyB0aGUg dHJhc2ggYW5kIHdlIGFyZSBnb29kIHRvCmJlIHVubG9hZGVkLiBXaXRoIG9uZSBwYXNzLgoKSSBn dWVzcyBpdCBjb21lcyB0byBob3cgdG8gdW5kZXJzdGFuZCB0aGUgY29tbWVudCwgc28gY291bGQg eW91CmVsYWJvcmF0ZSB0aGUgJ3dlIGhhdmUgd29ya2VycyB0aGF0IGFyZSBhcm1lZCBieSBSQ1Ug YW5kIHRoZW4gcmVhcm0KdGhlbXNlbHZlcyc/LiBBcyBmcm9tIGRyYWluX3dvcmtxdWV1ZSBkZXNj LCB0aGlzIHNob3VsZCBiZSBjb3ZlcmVkLgoKVGhhbmtzLAotTWlrYQoKPiArCX0gd2hpbGUgKC0t cGFzcyk7Cj4gK30KPiArCj4gIHN0cnVjdCBpOTE1X3ZtYSAqIF9fbXVzdF9jaGVjawo+ICBpOTE1 X2dlbV9vYmplY3RfZ2d0dF9waW4oc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiAg CQkJIGNvbnN0IHN0cnVjdCBpOTE1X2dndHRfdmlldyAqdmlldywKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL21vY2tfZ2VtX2RldmljZS5jIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvc2VsZnRlc3RzL21vY2tfZ2VtX2RldmljZS5jCj4gaW5kZXggNDc2MTNkMjBi YmE4Li43YTQ2OGNiMzA5NDYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2Vs ZnRlc3RzL21vY2tfZ2VtX2RldmljZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2Vs ZnRlc3RzL21vY2tfZ2VtX2RldmljZS5jCj4gQEAgLTU3LDcgKzU3LDcgQEAgc3RhdGljIHZvaWQg bW9ja19kZXZpY2VfcmVsZWFzZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAKPiAgCWNhbmNl bF9kZWxheWVkX3dvcmtfc3luYygmaTkxNS0+Z3QucmV0aXJlX3dvcmspOwo+ICAJY2FuY2VsX2Rl bGF5ZWRfd29ya19zeW5jKCZpOTE1LT5ndC5pZGxlX3dvcmspOwo+IC0JZmx1c2hfd29ya3F1ZXVl KGk5MTUtPndxKTsKPiArCWk5MTVfZ2VtX2RyYWluX3dvcmtxdWV1ZShpOTE1KTsKPiAgCj4gIAlt dXRleF9sb2NrKCZpOTE1LT5kcm0uc3RydWN0X211dGV4KTsKPiAgCWZvcl9lYWNoX2VuZ2luZShl bmdpbmUsIGk5MTUsIGlkKQo+IC0tIAo+IDIuMTMuMwpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK