Re: [Qemu-devel] [PATCH 2/2] risu_reginfo_arm.c: Move orphan comment to risu.h.

["Alex Bennée" <alex.bennee@linaro.org>]

Peter Maydell <peter.maydell@linaro.org> writes:

> Move an orphan comment that describes the reginfo structure
> into risu.h, and expand it a little.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  risu.h             | 5 +++++
>  risu_reginfo_arm.c | 5 -----
>  2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/risu.h b/risu.h
> index 3fbeda8..70c2184 100644
> --- a/risu.h
> +++ b/risu.h
> @@ -48,6 +48,11 @@ extern int test_fp_exc;
>  /* The memory block should be this long */
>  #define MEMBLOCKLEN 8192
>
> +/* This is the data structure we pass over the socket for OP_COMPARE
> + * and OP_TESTEND. It is a simplified and reduced subset of what can
> + * be obtained with a ucontext_t*, and is architecture specific
> + * (defined in risu_reginfo_*.h).
> + */
>  struct reginfo;
>
>  /* Functions operating on reginfo */
> diff --git a/risu_reginfo_arm.c b/risu_reginfo_arm.c
> index b0d5da7..6b9ee7b 100644
> --- a/risu_reginfo_arm.c
> +++ b/risu_reginfo_arm.c
> @@ -19,11 +19,6 @@
>
>  extern int insnsize(ucontext_t *uc);
>
> -/* This is the data structure we pass over the socket.
> - * It is a simplified and reduced subset of what can
> - * be obtained with a ucontext_t*
> - */
> -
>  static void reginfo_init_vfp(struct reginfo *ri, ucontext_t *uc)
>  {
>      /* Read VFP registers. These live in uc->uc_regspace, which is

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

--
Alex Bennée