From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dNKcM-0002UM-Cz for qemu-devel@nongnu.org; Tue, 20 Jun 2017 10:58:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dNKcL-0007de-Mn for qemu-devel@nongnu.org; Tue, 20 Jun 2017 10:58:58 -0400 Received: from mail-wr0-x22e.google.com ([2a00:1450:400c:c0c::22e]:34083) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dNKcL-0007dX-GP for qemu-devel@nongnu.org; Tue, 20 Jun 2017 10:58:57 -0400 Received: by mail-wr0-x22e.google.com with SMTP id 77so94503227wrb.1 for ; Tue, 20 Jun 2017 07:58:57 -0700 (PDT) References: <1497969886-17773-1-git-send-email-peter.maydell@linaro.org> <1497969886-17773-3-git-send-email-peter.maydell@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1497969886-17773-3-git-send-email-peter.maydell@linaro.org> Date: Tue, 20 Jun 2017 15:59:38 +0100 Message-ID: <87shiuu2lh.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 2/2] risu_reginfo_arm.c: Move orphan comment to risu.h. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org Peter Maydell writes: > Move an orphan comment that describes the reginfo structure > into risu.h, and expand it a little. > > Signed-off-by: Peter Maydell > --- > risu.h | 5 +++++ > risu_reginfo_arm.c | 5 ----- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/risu.h b/risu.h > index 3fbeda8..70c2184 100644 > --- a/risu.h > +++ b/risu.h > @@ -48,6 +48,11 @@ extern int test_fp_exc; > /* The memory block should be this long */ > #define MEMBLOCKLEN 8192 > > +/* This is the data structure we pass over the socket for OP_COMPARE > + * and OP_TESTEND. It is a simplified and reduced subset of what can > + * be obtained with a ucontext_t*, and is architecture specific > + * (defined in risu_reginfo_*.h). > + */ > struct reginfo; > > /* Functions operating on reginfo */ > diff --git a/risu_reginfo_arm.c b/risu_reginfo_arm.c > index b0d5da7..6b9ee7b 100644 > --- a/risu_reginfo_arm.c > +++ b/risu_reginfo_arm.c > @@ -19,11 +19,6 @@ > > extern int insnsize(ucontext_t *uc); > > -/* This is the data structure we pass over the socket. > - * It is a simplified and reduced subset of what can > - * be obtained with a ucontext_t* > - */ > - > static void reginfo_init_vfp(struct reginfo *ri, ucontext_t *uc) > { > /* Read VFP registers. These live in uc->uc_regspace, which is Reviewed-by: Alex Bennée -- Alex Bennée