Re: [Qemu-devel] [PATCH 2/2] migration: Don't create decompression threads if not enabled

[Juan Quintela <quintela@redhat.com>]

Peter Xu <peterx@redhat.com> wrote:
> On Tue, Jun 13, 2017 at 11:54:32AM +0200, Juan Quintela wrote:
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>> 
>> --
>> 
>> I removed the [HACK] part because previous patch just check that
>> compression pages are not received.
>> ---
>>  migration/ram.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>> 
>> diff --git a/migration/ram.c b/migration/ram.c
>> index f2d1bce..d475cf5 100644
>> --- a/migration/ram.c
>> +++ b/migration/ram.c
>> @@ -2234,6 +2234,9 @@ static void compress_threads_load_setup(void)
>
> I cannot find compress_threads_load_setup() in my repo, but
> migrate_decompress_threads_create()?


Sorry, this patches are on top of load_setup/cleanup series.

Later, Juan.

>
> Thanks,
>
>>  {
>>      int i, thread_count;
>>  
>> +    if (!migrate_use_compression()) {
>> +        return;
>> +    }
>>      thread_count = migrate_decompress_threads();
>>      decompress_threads = g_new0(QemuThread, thread_count);
>>      decomp_param = g_new0(DecompressParam, thread_count);
>> @@ -2255,6 +2258,9 @@ static void compress_threads_load_cleanup(void)
>>  {
>>      int i, thread_count;
>>  
>> +    if (!migrate_use_compression()) {
>> +        return;
>> +    }
>>      thread_count = migrate_decompress_threads();
>>      for (i = 0; i < thread_count; i++) {
>>          qemu_mutex_lock(&decomp_param[i].mutex);
>> -- 
>> 2.9.4
>>