From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] x86/gpu: GLK uses the same GMS values as SKL Date: Wed, 25 Jan 2017 13:31:10 +0200 Message-ID: <87sho74br5.fsf@intel.com> References: <1485283642-14401-1-git-send-email-paulo.r.zanoni@intel.com> <20170125072903.GA20432@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B1AE6E980 for ; Wed, 25 Jan 2017 11:31:14 +0000 (UTC) In-Reply-To: <20170125072903.GA20432@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ingo Molnar , Paulo Zanoni Cc: Ander Conselvan de Oliveira , Daniel Vetter , intel-gfx@lists.freedesktop.org, x86@kernel.org, linux-kernel@vger.kernel.org, Rodrigo Vivi , Dhinakaran Pandiyan , "H . Peter Anvin" List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyNSBKYW4gMjAxNywgSW5nbyBNb2xuYXIgPG1pbmdvQGtlcm5lbC5vcmc+IHdyb3Rl Ogo+ICogUGF1bG8gWmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRlbC5jb20+IHdyb3RlOgo+Cj4+ IFNvIGRvbid0IGZvcmdldCB0byByZXNlcnZlIGl0cyBzdG9sZW4gbWVtb3J5IGJpdHMuCj4+IAo+ PiBDYzogSW5nbyBNb2xuYXIgPG1pbmdvQGtlcm5lbC5vcmc+Cj4+IENjOiBILiBQZXRlciBBbnZp biA8aHBhQHp5dG9yLmNvbT4KPj4gQ2M6IEFuZGVyIENvbnNlbHZhbiBkZSBPbGl2ZWlyYSA8YW5k ZXIuY29uc2VsdmFuLmRlLm9saXZlaXJhQGludGVsLmNvbT4KPj4gQ2M6IHg4NkBrZXJuZWwub3Jn Cj4+IFJldmlld2VkLWJ5OiBBbmRlciBDb25zZWx2YW4gZGUgT2xpdmVpcmEgPGFuZGVyLmNvbnNl bHZhbi5kZS5vbGl2ZWlyYUBpbnRlbC5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6IFBhdWxvIFphbm9u aSA8cGF1bG8uci56YW5vbmlAaW50ZWwuY29tPgo+PiAtLS0KPj4gIGFyY2gveDg2L2tlcm5lbC9l YXJseS1xdWlya3MuYyB8IDEgKwo+PiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCj4+ IAo+PiBGb3VuZCBieSBjb2RlIGluc3BlY3Rpb24uIFRoaXMgaXMgY29tcGxldGVseSB1bnRlc3Rl ZCBzaW5jZSBJIGRvbid0IGhhdmUKPj4gR0xLIGhhcmR3YXJlLgo+PiAKPj4gZGlmZiAtLWdpdCBh L2FyY2gveDg2L2tlcm5lbC9lYXJseS1xdWlya3MuYyBiL2FyY2gveDg2L2tlcm5lbC9lYXJseS1x dWlya3MuYwo+PiBpbmRleCA2YTA4ZTI1Li4yM2M0ZjFjIDEwMDY0NAo+PiAtLS0gYS9hcmNoL3g4 Ni9rZXJuZWwvZWFybHktcXVpcmtzLmMKPj4gKysrIGIvYXJjaC94ODYva2VybmVsL2Vhcmx5LXF1 aXJrcy5jCj4+IEBAIC01MjYsNiArNTI2LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBwY2lfZGV2 aWNlX2lkIGludGVsX2Vhcmx5X2lkc1tdIF9faW5pdGNvbnN0ID0gewo+PiAgCUlOVEVMX1NLTF9J RFMoJmdlbjlfZWFybHlfb3BzKSwKPj4gIAlJTlRFTF9CWFRfSURTKCZnZW45X2Vhcmx5X29wcyks Cj4+ICAJSU5URUxfS0JMX0lEUygmZ2VuOV9lYXJseV9vcHMpLAo+PiArCUlOVEVMX0dMS19JRFMo JmdlbjlfZWFybHlfb3BzKSwKPj4gIH07Cj4KPiBUaGVyZSdzIG5vIElOVEVMX0dMS19JRFMoKSB1 cHN0cmVhbSAtIGlzIHRoZXJlIGFueSBkZXBlbmRlbmN5IGhlcmUgb24gb3RoZXIgCj4gY2hhbmdl cyB0byB0aGUgaTkxNSBHUFUgZHJpdmVyPwoKSXQncyBpbiBvdXIgLW5leHQuIEFjayBmb3IgbWVy Z2luZyB0aGlzIHRocm91Z2ggZHJtLWludGVsIGFsb25nIHdpdGggdGhlCmRlcHM/CgpCUiwKSmFu aS4KCj4KPiBUaGFua3MsCj4KPiAJSW5nbwo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJj ZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752110AbdAYLbQ (ORCPT ); Wed, 25 Jan 2017 06:31:16 -0500 Received: from mga07.intel.com ([134.134.136.100]:30536 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751994AbdAYLbP (ORCPT ); Wed, 25 Jan 2017 06:31:15 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,283,1477983600"; d="scan'208";a="813133819" From: Jani Nikula To: Ingo Molnar , Paulo Zanoni Cc: Ander Conselvan de Oliveira , "H . Peter Anvin" , intel-gfx@lists.freedesktop.org, x86@kernel.org, linux-kernel@vger.kernel.org, Dhinakaran Pandiyan , Rodrigo Vivi , Daniel Vetter Subject: Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL In-Reply-To: <20170125072903.GA20432@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1485283642-14401-1-git-send-email-paulo.r.zanoni@intel.com> <20170125072903.GA20432@gmail.com> Date: Wed, 25 Jan 2017 13:31:10 +0200 Message-ID: <87sho74br5.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 25 Jan 2017, Ingo Molnar wrote: > * Paulo Zanoni wrote: > >> So don't forget to reserve its stolen memory bits. >> >> Cc: Ingo Molnar >> Cc: H. Peter Anvin >> Cc: Ander Conselvan de Oliveira >> Cc: x86@kernel.org >> Reviewed-by: Ander Conselvan de Oliveira >> Signed-off-by: Paulo Zanoni >> --- >> arch/x86/kernel/early-quirks.c | 1 + >> 1 file changed, 1 insertion(+) >> >> Found by code inspection. This is completely untested since I don't have >> GLK hardware. >> >> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c >> index 6a08e25..23c4f1c 100644 >> --- a/arch/x86/kernel/early-quirks.c >> +++ b/arch/x86/kernel/early-quirks.c >> @@ -526,6 +526,7 @@ static const struct pci_device_id intel_early_ids[] __initconst = { >> INTEL_SKL_IDS(&gen9_early_ops), >> INTEL_BXT_IDS(&gen9_early_ops), >> INTEL_KBL_IDS(&gen9_early_ops), >> + INTEL_GLK_IDS(&gen9_early_ops), >> }; > > There's no INTEL_GLK_IDS() upstream - is there any dependency here on other > changes to the i915 GPU driver? It's in our -next. Ack for merging this through drm-intel along with the deps? BR, Jani. > > Thanks, > > Ingo > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center