All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH igt 2/2] intel-ci: Add reloading module without	any display
Date: Wed, 18 Jan 2017 12:21:18 +0200	[thread overview]
Message-ID: <87shog3bz5.fsf@intel.com> (raw)
In-Reply-To: <20170118101605.GD13302@nuc-i3427.alporthouse.com>

On Wed, 18 Jan 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Wed, Jan 18, 2017 at 12:07:17PM +0200, Jani Nikula wrote:
>> On Wed, 18 Jan 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> > A quick test to exercise one module paramter that should disable a chunk
>> > of code usually run at startup and shutdown.
>> 
>> Going for test driven development, are we? The BAT test list is not the
>> place to add tests that will break. We should get tests to be added to
>> the list passing first.
>
> I think it's a bit late to claim this is test-driven. Just responding to
> that a supported parameter has been broken for about 6 months.

I'm sure there are tons of tests in igt that fail for a bunch of our
supported features. But I thought we were in agreement we would not add
stuff to BAT that fail off the, uh, bat.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-01-18 10:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-18  9:58 [PATCH igt 1/2] intel-ci: Do module reload last Chris Wilson
2017-01-18  9:58 ` [PATCH igt 2/2] intel-ci: Add reloading module without any display Chris Wilson
2017-01-18 10:07   ` Jani Nikula
2017-01-18 10:16     ` Chris Wilson
2017-01-18 10:21       ` Jani Nikula [this message]
2017-01-18 10:14 ` [PATCH igt 1/2] intel-ci: Do module reload last Petri Latvala
2017-01-18 10:21   ` Chris Wilson
2017-01-18 10:25     ` Petri Latvala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87shog3bz5.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.