All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Vidya Srinivas <vidya.srinivas@intel.com>
Cc: intel-gfx@lists.freedesktop.org, "Syrjala,
	Ville" <ville.syrjala@intel.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm: Fix for invalid pruning of modes in dual display cases
Date: Tue, 13 Dec 2016 16:52:01 +0200	[thread overview]
Message-ID: <87shprswz2.fsf@intel.com> (raw)
In-Reply-To: <20161213104605.GN20316@nuc-i3427.alporthouse.com>

On Tue, 13 Dec 2016, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Tue, Dec 13, 2016 at 03:46:54PM +0530, Vidya Srinivas wrote:
>> Currently in dual display connected boot scenarios, minimum of the resolutions
>> is taken for fb width and height as reference. Based on this resolution, other
>> modes are pruned.
>> 
>> Example Scenario: If DSI mode is 2560x1440 and HDMI is 1920x1080, during the probing
>> the fb width and height is set to max 1920x1080 and the DSI mode gets pruned as it is
>> more than the reference. As a result, there is no DSI display.
>> Patch fixes this issue by taking the max of the resolutions and creating the fb
>> based on the same.
>
> On the other hand, the viewable content is defined by the smaller mode.
> If that is the only output visible at panic time, you don't want that
> information lost due to it being invisible.
>
> This is only used for fbcon, which has to be the lowest common
> denominator. Any actual application can set their own modes and fb.

Do we fail to take over non-native modes with scaling on DSI then?
Ville?

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-12-13 14:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-13 10:16 [PATCH] drm: Fix for invalid pruning of modes in dual display cases Vidya Srinivas
2016-12-13 10:28 ` [Intel-gfx] " Jani Nikula
2016-12-13 10:45 ` ✓ Fi.CI.BAT: success for " Patchwork
2016-12-13 10:46 ` [PATCH] " Chris Wilson
2016-12-13 14:52   ` Jani Nikula [this message]
2016-12-13 15:46     ` [Intel-gfx] " Ville Syrjälä
2017-01-16 10:13       ` Srinivas, Vidya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87shprswz2.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=vidya.srinivas@intel.com \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.