From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42538)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bVYwK-0001gu-Rj
	for qemu-devel@nongnu.org; Fri, 05 Aug 2016 02:49:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bVYwJ-0002Zr-RW
	for qemu-devel@nongnu.org; Fri, 05 Aug 2016 02:49:04 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1470339735-30037-1-git-send-email-hch@lst.de>
	<20160804201429.GA6992@localhost.localdomain>
Date: Fri, 05 Aug 2016 08:48:56 +0200
In-Reply-To: <20160804201429.GA6992@localhost.localdomain> (Keith Busch's
	message of "Thu, 4 Aug 2016 16:14:29 -0400")
Message-ID: <87shuj7lt3.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] fix incorrect identify implementation in nvme
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Keith Busch <keith.busch@intel.com>
Cc: Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org, qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>

Keith Busch <keith.busch@intel.com> writes:

> On Thu, Aug 04, 2016 at 09:42:13PM +0200, Christoph Hellwig wrote:
>> Third resent of this series after this didn't get picked up the
>> previous times.  The Qemu NVMe implementation mistakes the cns
>> field in the Identify command as a boolean.  This was never
>> true, and is actively harmful since NVMe1.1 (which the Qemu
>> device claims to support) supports more than two Identify variants.
>> 
>> We had to add a quirk in Linux to work around this behavior.
>
> Yes, these are great. Do we need to ping a maintainer to go through
> their tree, or can this be applied immediately? If need be, I can apply
> and send a pull request.

$ scripts/get_maintainer.pl -f hw/block/nvme.c 
Keith Busch <keith.busch@intel.com> (supporter:nvme)
Kevin Wolf <kwolf@redhat.com> (supporter:Block layer core)
Max Reitz <mreitz@redhat.com> (supporter:Block layer core)
qemu-block@nongnu.org (open list:nvme)
qemu-devel@nongnu.org (open list:All patches CC here)

Send a pull request (assuming you have a properly signed PGP key).