From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVgLc-0004yD-VF for qemu-devel@nongnu.org; Fri, 05 Aug 2016 10:43:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVgLZ-0007ug-PW for qemu-devel@nongnu.org; Fri, 05 Aug 2016 10:43:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47726) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVgLZ-0007uU-JX for qemu-devel@nongnu.org; Fri, 05 Aug 2016 10:43:37 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CBCE8C0567A2 for ; Fri, 5 Aug 2016 14:43:36 +0000 (UTC) From: Markus Armbruster References: <20160721140030.28383-1-marcandre.lureau@redhat.com> <20160721140030.28383-11-marcandre.lureau@redhat.com> Date: Fri, 05 Aug 2016 16:43:33 +0200 In-Reply-To: <20160721140030.28383-11-marcandre.lureau@redhat.com> (marcandre lureau's message of "Thu, 21 Jul 2016 18:00:28 +0400") Message-ID: <87shujp97u.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 10/12] monitor: use qmp_dispatch() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com Cc: qemu-devel@nongnu.org marcandre.lureau@redhat.com writes: > From: Marc-Andr=C3=A9 Lureau > > Replace the old manual dispatch and validation code by the generic one > provided by qapi common code. > > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > monitor.c | 319 +++++++----------------------------------------------= ------ > trace-events | 1 - > 2 files changed, 34 insertions(+), 286 deletions(-) All right, this is where it gets interesting: you replace a whole bunch of code by other code we have anyway. Excellent. Only we need to convince ourselves the replacement is functionally equivalent. Before I dive into that, what have you done to convince yourself?