From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPAv9-00008y-LN for qemu-devel@nongnu.org; Mon, 18 Jul 2016 11:57:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPAv5-0003Pm-IY for qemu-devel@nongnu.org; Mon, 18 Jul 2016 11:57:26 -0400 Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]:35292) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPAv5-0003Pi-BS for qemu-devel@nongnu.org; Mon, 18 Jul 2016 11:57:23 -0400 Received: by mail-wm0-x235.google.com with SMTP id f65so109079165wmi.0 for ; Mon, 18 Jul 2016 08:57:23 -0700 (PDT) References: <1468335639-24582-1-git-send-email-alex.bennee@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1468335639-24582-1-git-send-email-alex.bennee@linaro.org> Date: Mon, 18 Jul 2016 16:57:23 +0100 Message-ID: <87shv7ndlo.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v5 0/7] docker: Support building qemu-user powered docker test images List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: famz@redhat.com, riku.voipio@linaro.org Alex Bennée writes: > Hi, > > This is v5 of the series (Fam posted the last revision). I've dropped > all the fancy chroot-in-docker stuff in favour of making the > debootstrap.pre script more platform agnostic. If it can't find > debootstrap on the system it just clones the upstream SCM and uses the > script from there. > > There is a patch pending in Debian to remove one minor niggle that > stops that working at the moment, see: > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=830869 > > The pre script also does a bunch of additional checking of the > pre-requisites including if binfmt_misc is setup for qemu-$ARCH. It > doesn't go quite as far as checking the setup path though but it > should be sufficient. > > The only remaining problem is how to handle the flexibility of > multiple architectures in the Make system. As the dockerfiles live in > the tests/docker/dockerfile directory all the normal docker test > constructions work. However if you want a cross-arch docker image you > need to build it "by hand" with the appropriate DEB_ARCH/DEB_TYPE and > --include-executable stanza. > > So any ideas about that? Any thoughts on that Fam? Can we merge it without the final step on the grounds it makes for useful testing? > > Alex Bennée (5): > tests/docker/docker.py: docker_dir outside build > tests/docker/docker.py: support --include-executable > tests/docker/docker.py: check and run .pre script > tests/docker/dockerfiles: new debian-bootstrap.docker > tests/docker/docker.py: add update operation > > Fam Zheng (2): > docker: More sensible run script > docker: Fix exit code if $CMD failed > > tests/docker/Makefile.include | 4 +- > tests/docker/docker.py | 144 +++++++++++++++++++++-- > tests/docker/dockerfiles/debian-bootstrap.docker | 21 ++++ > tests/docker/dockerfiles/debian-bootstrap.pre | 82 +++++++++++++ > tests/docker/run | 16 ++- > 5 files changed, 252 insertions(+), 15 deletions(-) > create mode 100644 tests/docker/dockerfiles/debian-bootstrap.docker > create mode 100755 tests/docker/dockerfiles/debian-bootstrap.pre -- Alex Bennée