From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rfcJC6KFtzDqtp for ; Wed, 29 Jun 2016 19:07:23 +1000 (AEST) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u5T93V62115252 for ; Wed, 29 Jun 2016 05:07:22 -0400 Received: from e32.co.us.ibm.com (e32.co.us.ibm.com [32.97.110.150]) by mx0a-001b2d01.pphosted.com with ESMTP id 23v09p4sq5-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 29 Jun 2016 05:07:21 -0400 Received: from localhost by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 29 Jun 2016 03:07:21 -0600 From: Stewart Smith To: Suraj Jitindar Singh , linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au Cc: robh@kernel.org, arnd@arndb.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, paulus@samba.org, sjitindarsingh@gmail.com Subject: Re: [PATCH V5 2/3] powerpc/opal: Add inline function to get rc from an ASYNC_COMP opal_msg In-Reply-To: <1467171519-19882-2-git-send-email-sjitindarsingh@gmail.com> References: <1467171519-19882-1-git-send-email-sjitindarsingh@gmail.com> <1467171519-19882-2-git-send-email-sjitindarsingh@gmail.com> Date: Wed, 29 Jun 2016 19:07:09 +1000 MIME-Version: 1.0 Content-Type: text/plain Message-Id: <87shvw1hz6.fsf@linux.vnet.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Suraj Jitindar Singh writes: > --- a/arch/powerpc/include/asm/opal.h > +++ b/arch/powerpc/include/asm/opal.h > @@ -276,6 +276,14 @@ extern int opal_error_code(int rc); > > ssize_t opal_msglog_copy(char *to, loff_t pos, size_t count); > > +static inline int opal_get_async_rc(struct opal_msg msg) > +{ > + if (msg.msg_type != OPAL_MSG_ASYNC_COMP) > + return OPAL_PARAMETER; Should instead be WARN_ON or BUG_ON ? Is there *ever* a situation where calling opal_get_async_rc on a non-OPAL_MSG_ASYNC_COMP is a not both a dumb idea and a bug? otherwise (including if above change is made) Acked-by: Stewart Smith -- Stewart Smith OPAL Architect, IBM. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stewart Smith Subject: Re: [PATCH V5 2/3] powerpc/opal: Add inline function to get rc from an ASYNC_COMP opal_msg Date: Wed, 29 Jun 2016 19:07:09 +1000 Message-ID: <87shvw1hz6.fsf@linux.vnet.ibm.com> References: <1467171519-19882-1-git-send-email-sjitindarsingh@gmail.com> <1467171519-19882-2-git-send-email-sjitindarsingh@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1467171519-19882-2-git-send-email-sjitindarsingh@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au Cc: robh@kernel.org, arnd@arndb.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, paulus@samba.org, sjitindarsingh@gmail.com List-Id: devicetree@vger.kernel.org U3VyYWogSml0aW5kYXIgU2luZ2ggPHNqaXRpbmRhcnNpbmdoQGdtYWlsLmNvbT4gd3JpdGVzOgo+ IC0tLSBhL2FyY2gvcG93ZXJwYy9pbmNsdWRlL2FzbS9vcGFsLmgKPiArKysgYi9hcmNoL3Bvd2Vy cGMvaW5jbHVkZS9hc20vb3BhbC5oCj4gQEAgLTI3Niw2ICsyNzYsMTQgQEAgZXh0ZXJuIGludCBv cGFsX2Vycm9yX2NvZGUoaW50IHJjKTsKPiAgCj4gIHNzaXplX3Qgb3BhbF9tc2dsb2dfY29weShj aGFyICp0bywgbG9mZl90IHBvcywgc2l6ZV90IGNvdW50KTsKPiAgCj4gK3N0YXRpYyBpbmxpbmUg aW50IG9wYWxfZ2V0X2FzeW5jX3JjKHN0cnVjdCBvcGFsX21zZyBtc2cpCj4gK3sKPiArCWlmICht c2cubXNnX3R5cGUgIT0gT1BBTF9NU0dfQVNZTkNfQ09NUCkKPiArCQlyZXR1cm4gT1BBTF9QQVJB TUVURVI7CgpTaG91bGQgaW5zdGVhZCBiZSBXQVJOX09OIG9yIEJVR19PTiA/IElzIHRoZXJlICpl dmVyKiBhIHNpdHVhdGlvbiB3aGVyZQpjYWxsaW5nIG9wYWxfZ2V0X2FzeW5jX3JjIG9uIGEgbm9u LU9QQUxfTVNHX0FTWU5DX0NPTVAgaXMgYSBub3QgYm90aCBhCmR1bWIgaWRlYSBhbmQgYSBidWc/ CgpvdGhlcndpc2UgKGluY2x1ZGluZyBpZiBhYm92ZSBjaGFuZ2UgaXMgbWFkZSkKQWNrZWQtYnk6 IFN0ZXdhcnQgU21pdGggPHN0ZXdhcnRAbGludXgudm5ldC5pYm0uY29tPgoKCi0tIApTdGV3YXJ0 IFNtaXRoCk9QQUwgQXJjaGl0ZWN0LCBJQk0uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpMaW51eHBwYy1kZXYgbWFpbGluZyBsaXN0CkxpbnV4cHBjLWRl dkBsaXN0cy5vemxhYnMub3JnCmh0dHBzOi8vbGlzdHMub3psYWJzLm9yZy9saXN0aW5mby9saW51 eHBwYy1kZXY=