From: Felipe Balbi <balbi@kernel.org>
To: William Wu <william.wu@rock-chips.com>,
gregkh@linuxfoundation.org, heiko@sntech.de
Cc: briannorris@google.com, dianders@google.com,
kever.yang@rock-chips.com, huangtao@rock-chips.com,
frank.wang@rock-chips.com, eddie.cai@rock-chips.com,
John.Youn@synopsys.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug
Date: Mon, 09 May 2016 16:35:34 +0300 [thread overview]
Message-ID: <87shxrz74p.fsf@intel.com> (raw)
In-Reply-To: <57308DAB.3020401@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 791 bytes --]
William Wu <william.wu@rock-chips.com> writes:
> On 05/09/2016 08:10 PM, Felipe Balbi wrote:
>> William Wu <william.wu@rock-chips.com> writes:
> Thanks Felipe Balbi and Greg KH. I'm really sorry that I forgot to
> add changelog.
>>> Signed-off-by: William Wu <william.wu@rock-chips.com>
>> no changelog = no commit, sorry. Why do you want to dump GUCTL1?
> Because GUCTL1 can be written by user. For rockchip platform,
> we set GUCTL1.DEV_FORCE_20_CLK_FOR_30_CLK(bit26) to 1 in
> bootrom(used for usb2.0 device only),
> and after kernel boot, I want to check whether this bit can be
> reset to default 0 after core reset.
> Dump GUCTL1 reg from debugfs is more convenient for me.
cool, something like this could go to commit log :-)
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-05-09 13:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 12:00 [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug William Wu
2016-05-09 12:04 ` Greg KH
2016-05-09 12:10 ` Felipe Balbi
2016-05-09 13:16 ` William Wu
2016-05-09 13:35 ` Felipe Balbi [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-05-13 10:05 William Wu
2016-05-13 10:05 ` William Wu
[not found] ` <1463133926-7366-1-git-send-email-william.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-05-13 10:07 ` William Wu
2016-05-13 10:07 ` William Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shxrz74p.fsf@intel.com \
--to=balbi@kernel.org \
--cc=John.Youn@synopsys.com \
--cc=briannorris@google.com \
--cc=dianders@google.com \
--cc=eddie.cai@rock-chips.com \
--cc=frank.wang@rock-chips.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=william.wu@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.