From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60429)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ayaKm-0003LW-On
	for qemu-devel@nongnu.org; Fri, 06 May 2016 03:38:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ayaKa-0002k0-VQ
	for qemu-devel@nongnu.org; Fri, 06 May 2016 03:37:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50898)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ayaKa-0002hM-QD
	for qemu-devel@nongnu.org; Fri, 06 May 2016 03:37:48 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1459237645-17227-1-git-send-email-zxq_yx_007@163.com>
	<1e5877c8.11366.154807f2624.Coremail.zxq_yx_007@163.com>
	<CAFEAcA-BDp9ybo+Z2xUG_cqWo_jeRaq863Z4PJnNVPEpWHv8nA@mail.gmail.com>
Date: Fri, 06 May 2016 09:37:35 +0200
In-Reply-To: <CAFEAcA-BDp9ybo+Z2xUG_cqWo_jeRaq863Z4PJnNVPEpWHv8nA@mail.gmail.com>
	(Peter Maydell's message of "Thu, 5 May 2016 13:51:01 +0100")
Message-ID: <87shxv63i8.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 0/6] QOM'ify hw/char devices
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: =?utf-8?B?6LW15bCP5by6?= <zxq_yx_007@163.com>, QEMU Developers <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, Michael Walle <michael@walle.cc>, Paolo Bonzini <pbonzini@redhat.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>

Peter Maydell <peter.maydell@linaro.org> writes:

> On 5 May 2016 at 11:38, =E8=B5=B5=E5=B0=8F=E5=BC=BA <zxq_yx_007@163.com> =
wrote:
>> At 2016-03-29 15:47:19, "xiaoqiang zhao" <zxq_yx_007@163.com> wrote:
>>>This patch set trys to QOM'ify hw/char files, see commit messages
>>>for more details
>>>
>>>Changes in v2:
>>>* rename TYPE_SCLP_LM_CONSOLE to TYPE_SCLPLM_CONSOLE which is suggested =
by
>>>  Cornelia Huck <cornelia.huck@de.ibm.com>
>>>* rebase on the current master
>>>
>>>xiaoqiang zhao (6):
>>>  hw/char: QOM'ify escc.c
>>>  hw/char: QOM'ify etraxfs_ser.c
>>>  hw/char: QOM'ify lm32_juart.c
>>>  hw/char: QOM'ify lm32_uart.c
>>>  hw/char: QOM'ify sclpconsole-lm.c
>>>  hw/char: QOM'ify sclpconsole.c
>>>
>>> hw/char/escc.c           | 12 +++++-------
>>> hw/char/etraxfs_ser.c    | 11 +++++------
>>> hw/char/lm32_juart.c     |  9 +++------
>>> hw/char/lm32_uart.c      | 12 +++++-------
>>> hw/char/sclpconsole-lm.c | 14 +++++++++-----
>>> hw/char/sclpconsole.c    | 12 ++++++++----
>>> 6 files changed, 35 insertions(+), 35 deletions(-)
>>>
>>>--
>>>2.1.4
>>>
>>
>> ping ???
>
> I think you will have better luck if you rearrange all these
> QOM patches so that you provide them as one series per board
> or per target architecture, not one per type of device.
> There is no single person with responsibility for "all of
> hw/char" so structuring your cleanup patchsets like this will
> tend to result in the people who might care about the devices
> not looking at them. (Also you can concentrate on the devices
> which are actively maintained, like ARM ones, x86 ones, MIPS
> and SPARC ones, rather than the oddballs semi-orphaned ones
> like lm32, CRIS, etc.)

But please don't throw away your cleanups for the oddballs just yet.
Unloved code keeping obsolete internal interfaces alive is a problem
worth reducing.