From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42258)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1aj419-0001wK-10
	for qemu-devel@nongnu.org; Thu, 24 Mar 2016 08:05:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1aj413-0003Oh-UT
	for qemu-devel@nongnu.org; Thu, 24 Mar 2016 08:05:34 -0400
Received: from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]:38486)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1aj413-0003OS-HW
	for qemu-devel@nongnu.org; Thu, 24 Mar 2016 08:05:29 -0400
Received: by mail-wm0-x229.google.com with SMTP id l68so62504004wml.1
	for <qemu-devel@nongnu.org>; Thu, 24 Mar 2016 05:05:29 -0700 (PDT)
References: <1458753657-21664-1-git-send-email-alex.bennee@linaro.org>
	<1458753657-21664-5-git-send-email-alex.bennee@linaro.org>
	<56F3B20A.9010607@gmail.com>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <56F3B20A.9010607@gmail.com>
Date: Thu, 24 Mar 2016 12:05:27 +0000
Message-ID: <87shzgqdx4.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v2 4/5] ./configure: accept stems to match
	a range of targets
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sergey Fedorov <serge.fdrv@gmail.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, david@gibson.dropbear.id.au


Sergey Fedorov <serge.fdrv@gmail.com> writes:

> On 23/03/16 20:20, Alex Bennée wrote:
>> diff --git a/configure b/configure
>> index b88d0db..ebf8a42 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1246,7 +1246,8 @@ Standard options:
>>    --target-list=LIST       set target list (default: build everything)
>>  $(echo Available targets: $default_target_list | \
>>    fold -s -w 53 | sed -e 's/^/                           /')
>> -
>> +                           LIST can contain stems to match sets of targets
>> +                           (e.g. softmmu will match all softmmu targets)
>>  Advanced options (experts only):
>>    --source-path=PATH       path of source code [$source_path]
>>    --cross-prefix=PREFIX    use PREFIX for compile tools [$cross_prefix]
>
> Maybe we'd better require user to specify the exact glob patterns in
> '--target-list' to avoid possible misuse?

Don't you run into problems of escaping glob patterns from the shell and
the like? For example if I do:

12:04 alex@zen/x86_64  [qemu.git/mttcg/base-patches-v2] >./configure
--target-list=arm*

ERROR: Unknown target name 'arm-softmmu-config-devices.mak.d'

As the shell picks up file names from the src dir.

>
> Kind regards,
> Sergey


--
Alex Bennée