From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix use after free when printing load failure
Date: Wed, 23 Mar 2016 12:12:02 +0200 [thread overview]
Message-ID: <87shzhec5p.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20160323085635.GA21717@nuc-i3427.alporthouse.com>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> [ text/plain ]
> On Wed, Mar 23, 2016 at 10:31:46AM +0200, Mika Kuoppala wrote:
>> Commit d15d7538c6d2 ("drm/i915: Tune down init error message due
>> to failure injection") added i915_load_error message to failure
>> path on device initialization. The message is printed
>> after the device is freed. And as the message printing helper
>> uses the device structure, this leads to use after free.
>>
>> Spotted by Kasan.
>
> Oops. I don't think it's practical to run the entire igt with kasan
> enabled (anything that stresses memory operations takes forever), even
> just one machine running BAT with kasan would be enough to catch silly
> errors like this one. How much heterogenity do we have in configs across
> CI? I guess not enough because as always we will be limited upon
> machines.
>
You don't want to compile kernel on Kasan enabled. But
it is not so bad with igt/bat.
time ./run-tests.sh -t basic
[191/191] skip: 20, pass: 167, dmesg-warn: 3, dmesg-fail: 1 \
Thank you for running Piglit!
Results have been written to /home/miku/src/intel-gpu-tools/results
real 13m22.860s
user 0m39.503s
sys 5m48.932s
I don't have the numbers for most recent CI/bat runs but
according to Tomi, the slowest ones are in this ballpark.
So wiring Kasan on of the fastest one, and we are good.
>> Cc: Imre Deak <imre.deak@intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Patch pushed to dinq, thanks for review.
-Mika
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-03-23 10:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 8:31 [PATCH] drm/i915: Fix use after free when printing load failure Mika Kuoppala
2016-03-23 8:32 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-03-23 9:01 ` Mika Kuoppala
2016-03-23 8:56 ` [PATCH] " Chris Wilson
2016-03-23 10:12 ` Mika Kuoppala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shzhec5p.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.