From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43644)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1aePZn-00034u-Gp
	for qemu-devel@nongnu.org; Fri, 11 Mar 2016 11:06:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1aePZi-0002sa-BM
	for qemu-devel@nongnu.org; Fri, 11 Mar 2016 11:06:07 -0500
Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:33879)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1aePZi-0002sQ-4S
	for qemu-devel@nongnu.org; Fri, 11 Mar 2016 11:06:02 -0500
Received: by mail-wm0-x22c.google.com with SMTP id p65so23881156wmp.1
	for <qemu-devel@nongnu.org>; Fri, 11 Mar 2016 08:06:02 -0800 (PST)
References: <1457086720-30391-1-git-send-email-famz@redhat.com>
	<1457086720-30391-5-git-send-email-famz@redhat.com>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1457086720-30391-5-git-send-email-famz@redhat.com>
Date: Fri, 11 Mar 2016 16:05:59 +0000
Message-ID: <87shzxt2xk.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v3 04/13] docker: Add test runner
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, peter.maydell@linaro.org, sw@weilnetz.de, qemu-devel@nongnu.org, stefanha@redhat.com, Paolo Bonzini <pbonzini@redhat.com>, jsnow@redhat.com, david@gibson.dropbear.id.au


Fam Zheng <famz@redhat.com> writes:

> It's better to have a launcher for all tests, to make it easier to
> initialize and manage the environment.
>
> If "DEBUG=1"  a shell prompt will show up before the test runs.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  tests/docker/run | 58 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 58 insertions(+)
>  create mode 100755 tests/docker/run
>
> diff --git a/tests/docker/run b/tests/docker/run
> new file mode 100755
> index 0000000..ec3d119
> --- /dev/null
> +++ b/tests/docker/run
> @@ -0,0 +1,58 @@
> +#!/bin/bash -e
> +#
> +# Docker test runner
> +#
> +# Copyright (c) 2016 Red Hat Inc.
> +#
> +# Authors:
> +#  Fam Zheng <famz@redhat.com>
> +#
> +# This work is licensed under the terms of the GNU GPL, version 2
> +# or (at your option) any later version. See the COPYING file in
> +# the top-level directory.
> +
> +# Prepare the environment
> +. /etc/profile || true
> +export PATH=/usr/lib/ccache:$PATH
> +
> +if test -n "$J"; then
> +    export MAKEFLAGS="$MAKEFLAGS -j$J"
> +fi
> +
> +# We are in the container so the whole file system belong to us
> +export TEST_DIR=/tmp/qemu-test
> +mkdir -p $TEST_DIR/{src,build,install}
> +
> +# Extract the source tarballs
> +tar -C $TEST_DIR/src -xzf qemu.tgz
> +for p in dtc pixman; do
> +    if test -f $p.tgz; then
> +        tar -C $TEST_DIR/src/$p -xzf $p.tgz
> +        export FEATURES="$FEATURES $p"
> +    fi
> +done
> +
> +export QEMU_SRC="$TEST_DIR/src"
> +
> +cd "$QEMU_SRC/tests/docker"
> +
> +CMD="$QEMU_SRC/tests/docker/$@"
> +
> +if test -n "$DEBUG"; then
> +    echo "* Prepared to run command:"
> +    echo "  $CMD"
> +    echo "* Hit Ctrl-D to continue, or type 'exit 1' to abort"
> +    echo
> +    $SHELL
> +fi
> +
> +if "$CMD"; then
> +    exit 0
> +elif test -n "$DEBUG"; then
> +    echo "* Command failed:"
> +    echo "  $CMD"
> +    echo "* Hit Ctrl-D to exit"
> +    echo
> +    # Force error after shell exits
> +    $SHELL && exit 1
> +fi


--
Alex Bennée