From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVKVq-0003Yn-K7 for qemu-devel@nongnu.org; Mon, 15 Feb 2016 09:52:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVKVl-0003ez-Je for qemu-devel@nongnu.org; Mon, 15 Feb 2016 09:52:30 -0500 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:34277) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVKVl-0003ek-8w for qemu-devel@nongnu.org; Mon, 15 Feb 2016 09:52:25 -0500 Received: by mail-wm0-x22c.google.com with SMTP id b205so70783607wmb.1 for ; Mon, 15 Feb 2016 06:52:25 -0800 (PST) References: <1454664263-25969-1-git-send-email-famz@redhat.com> <1454664263-25969-7-git-send-email-famz@redhat.com> <87wpq6m490.fsf@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: Date: Mon, 15 Feb 2016 14:52:23 +0000 Message-ID: <87si0um3fc.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 06/12] docker: Add basic test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Kevin Wolf , Fam Zheng , Stefan Weil , QEMU Developers , Stefan Hajnoczi , Paolo Bonzini , John Snow , David Gibson Peter Maydell writes: > On 15 February 2016 at 14:34, Alex Bennée wrote: >> >> Fam Zheng writes: >>> +cd $(mktemp -d) >>> +mkdir build >>> +mkdir install >>> +cd build >>> +build_qemu --target-list=x86_64-softmmu --prefix="${pwd}/install" > > Why restrict the target list ? > >>> +make check $MAKEFLAGS >>> +make install >> >> From my excursions last week into the tests directory I discovered the >> unit tests are built for a number of different qtest binaries. For >> completeness we should probably include the whole list: >> >> #+name: qtest-targets >> #+begin_src sh :dir ~/lsrc/qemu/qemu.git :results scalar >> grep -E "check-qtest-[[:alnum:]]+-y " tests/Makefile | cut -d " " -f 1 | sort -u >> #+end_src >> >> #+RESULTS: qtest-targets >> #+begin_example >> check-qtest-arm-y >> check-qtest-generic-y >> check-qtest-i386-y >> check-qtest-ipack-y >> check-qtest-microblazeel-y >> check-qtest-mips64el-y >> check-qtest-mips64-y >> check-qtest-mips-y >> check-qtest-pci-y >> check-qtest-ppc64-y >> check-qtest-ppc-y >> check-qtest-sh4eb-y >> check-qtest-sh4-y >> #check-qtest-sparc64-y >> check-qtest-sparc64-y >> #check-qtest-sparc-y >> check-qtest-virtioserial-y >> check-qtest-virtio-y >> check-qtest-x86_64-y >> check-qtest-xtensaeb-y >> check-qtest-y >> #+end_example > > I'm having difficulty figuring out what you're proposing here, > but it looks like you're suggesting listing all the check-qtest-* > test names again here, which seems worth avoiding. We should > just do a build and make check and let that take care of > running all the tests. Well there is a halfway house between building one target and building all possible targets. Not all the softmmu targets include additional tests. Having said that it is probably simpler as you say to just build everything. > > thanks > -- PMM -- Alex Bennée