From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38519) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQE1f-0003pX-Kg for qemu-devel@nongnu.org; Mon, 01 Feb 2016 07:56:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQE1c-0006WL-FS for qemu-devel@nongnu.org; Mon, 01 Feb 2016 07:56:15 -0500 From: Markus Armbruster References: <1454075341-13658-1-git-send-email-eblake@redhat.com> <1454075341-13658-22-git-send-email-eblake@redhat.com> Date: Mon, 01 Feb 2016 13:56:04 +0100 In-Reply-To: <1454075341-13658-22-git-send-email-eblake@redhat.com> (Eric Blake's message of "Fri, 29 Jan 2016 06:48:57 -0700") Message-ID: <87si1c613v.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v10 21/25] qapi: Drop unused 'kind' for struct/enum visit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Michael Roth , "Michael S. Tsirkin" , Alexander Graf , qemu-devel@nongnu.org, "open list:sPAPR" , marcandre.lureau@redhat.com, Paolo Bonzini , Luiz Capitulino , Andreas =?utf-8?Q?F=C3=A4rber?= , David Gibson Eric Blake writes: > visit_start_struct() and visit_type_enum() had a 'kind' argument > that was usually set to either the stringized version of the > corresponding qapi type name, or to NULL (although some clients > didn't even get that right). But nothing ever used the argument. > It's even hard to argue that it would be useful in a debugger, > as a stack backtrace also tells which type is being visited. > > Therefore, drop the 'kind' argument as dead. > > Signed-off-by: Eric Blake > Reviewed-by: Marc-Andr=C3=A9 Lureau > > --- > v10: rebase to earlier changes, tweak copyright > v9: no change > v8: rebase to 'name' motion > v7: new patch [...] > diff --git a/qapi/qapi-visit-core.c b/qapi/qapi-visit-core.c > index 23ff6a9..2999995 100644 > --- a/qapi/qapi-visit-core.c > +++ b/qapi/qapi-visit-core.c > @@ -3,6 +3,7 @@ > * > * Copyright (C) 2012-2016 Red Hat, Inc. > * Copyright IBM, Corp. 2011 > + * Copyright (C) 2015 Red Hat, Inc. Rebase mistake. Can drop the hunk on commit. > * > * Authors: > * Anthony Liguori [...]