From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757385AbbJIKNm (ORCPT ); Fri, 9 Oct 2015 06:13:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36316 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753743AbbJIKNk (ORCPT ); Fri, 9 Oct 2015 06:13:40 -0400 From: Vitaly Kuznetsov To: Olaf Hering Cc: KY Srinivasan , "gregkh\@linuxfoundation.org" , "linux-kernel\@vger.kernel.org" , "devel\@linuxdriverproject.org" , "apw\@canonical.com" , "jasowang\@redhat.com" Subject: Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context References: <1444269571-25217-1-git-send-email-kys@microsoft.com> <1444269709-25270-1-git-send-email-kys@microsoft.com> <1444269709-25270-2-git-send-email-kys@microsoft.com> <87r3l5ebmj.fsf@vitty.brq.redhat.com> <20151008133037.GA31748@aepfle.de> <87mvvteabq.fsf@vitty.brq.redhat.com> <20151009070757.GA27773@aepfle.de> Date: Fri, 09 Oct 2015 12:13:36 +0200 In-Reply-To: <20151009070757.GA27773@aepfle.de> (Olaf Hering's message of "Fri, 9 Oct 2015 09:07:58 +0200") Message-ID: <87si5kqrhr.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Olaf Hering writes: > On Thu, Oct 08, KY Srinivasan wrote: > >> > yes, but after doing fcopy_respond_to_host(). I'd suggest we leave the >> > check in place, better safe than sorry. >> >> Agreed; Olaf, if it is ok with you, I can fix it up and send. > > I will retest with this part reverted. I think without two code paths > entering hv_fcopy_callback it should be ok to leave this check in. I think hv_fcopy_callback() is not involved here: we call fcopy_on_msg() every time userspace daemon writes to the device and it is not anyhow synchronized with host-guest communication. -- Vitaly