Re: [Qemu-devel] [PATCH 03/11] target-m68k: Remove incorrect clearing of cc_x

[Andreas Schwab <schwab@linux-m68k.org>]

Richard Henderson <rth@twiddle.net> writes:

> The CF docs certainly doesnt suggest this is true.
>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  target-m68k/helper.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/target-m68k/helper.c b/target-m68k/helper.c
> index c7b0fbe..6feb4bf 100644
> --- a/target-m68k/helper.c
> +++ b/target-m68k/helper.c
> @@ -205,19 +205,12 @@ static uint32_t cpu_m68k_flush_flags(CPUM68KState *env, int op)
>          break;
>      case CC_OP_LOGICB:
>          SET_NZ(dest, int8_t);
> -        goto set_x;
>          break;
>      case CC_OP_LOGICW:
>          SET_NZ(dest, int16_t);
> -        goto set_x;
>          break;
>      case CC_OP_LOGIC:
>          SET_NZ(dest, int32_t);
> -set_x:
> -        if (!m68k_feature(env, M68K_FEATURE_M68000)) {
> -            /* Unlike m68k, coldfire always clears the overflow bit.  */

I think this refers to the muls/mulu insn, where the CF always clears V.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."