From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZADV5-0003Pc-RY for qemu-devel@nongnu.org; Wed, 01 Jul 2015 04:36:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZADV1-0000uk-Iv for qemu-devel@nongnu.org; Wed, 01 Jul 2015 04:36:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40388) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZADV1-0000uf-EI for qemu-devel@nongnu.org; Wed, 01 Jul 2015 04:36:07 -0400 From: Juan Quintela In-Reply-To: <1434043048-4444-2-git-send-email-dgilbert@redhat.com> (David Alan Gilbert's message of "Thu, 11 Jun 2015 18:17:17 +0100") References: <1434043048-4444-1-git-send-email-dgilbert@redhat.com> <1434043048-4444-2-git-send-email-dgilbert@redhat.com> Date: Wed, 01 Jul 2015 10:36:05 +0200 Message-ID: <87si982s22.fsf@neno.neno> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 01/12] Rename RDMA structures to make destination clear Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: amit.shah@redhat.com, arei.gonglei@huawei.com, qemu-devel@nongnu.org, mrhines@us.ibm.com "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > RDMA has two data types that are named confusingly; > RDMALocalBlock (pointed to indirectly by local_ram_blocks) > RDMARemoteBlock (pointed to by block in RDMAContext) > > RDMALocalBlocks, as the name suggests is a data strucuture that > represents the RDMAable RAM Blocks on the current side of the migration > whichever that is. > > RDMARemoteBlocks is always the shape of the RAMBlocks on the > destination, even on the destination. > > Rename: > RDMARemoteBlock -> RDMADestBlock > context->'block' -> context->dest_blocks > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: Michael R. Hines Reviewed-by: Juan Quintela