All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com,
	mimu@linux.vnet.ibm.com, mdroth@linux.vnet.ibm.com,
	qemu-devel@nongnu.org, borntraeger@de.ibm.com, agraf@suse.de,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	bharata@linux.vnet.ibm.com, cornelia.huck@de.ibm.com,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Jiri Denemark" <jdenemar@redhat.com>,
	lcapitulino@redhat.com, "Andreas Färber" <afaerber@suse.de>,
	david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [PATCH v2] qmp: Add qom_path field to query-cpus command
Date: Tue, 12 May 2015 19:42:17 +0200	[thread overview]
Message-ID: <87sib1zo92.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <20150512154736.GS17796@thinpad.lan.raisama.net> (Eduardo Habkost's message of "Tue, 12 May 2015 12:47:36 -0300")

Eduardo Habkost <ehabkost@redhat.com> writes:

> On Tue, May 12, 2015 at 05:38:37PM +0200, Markus Armbruster wrote:
> [...]
>> > @@ -699,8 +701,9 @@
>> >  #        data is sent to the client, the guest may no longer be halted.
>> >  ##
>> >  { 'struct': 'CpuInfo',
>> > -  'data': {'CPU': 'int', 'current': 'bool', 'halted': 'bool', '*pc': 'int',
>> > - '*nip': 'int', '*npc': 'int', '*PC': 'int', 'thread_id': 'int'}
>> > }
>> > + 'data': {'CPU': 'int', 'current': 'bool', 'halted': 'bool',
>> > qom_path': 'str',
>> 
>> Long line.
>
> It has exactly 80 characters.

Several characters too wide for my taste.

I just realized checkpatch is fine with 80.  I'll revert my line wrap if
you feel strongly about it.

  reply	other threads:[~2015-05-12 17:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08 19:04 [Qemu-devel] [PATCH v2] qmp: Add qom_path field to query-cpus command Eduardo Habkost
2015-05-08 21:16 ` Eric Blake
2015-05-12 15:38 ` Markus Armbruster
2015-05-12 15:47   ` Eduardo Habkost
2015-05-12 17:42     ` Markus Armbruster [this message]
2015-05-12 19:18       ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sib1zo92.fsf@blackfin.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jdenemar@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=mimu@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.