From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpKSO-0000TF-Oz for qemu-devel@nongnu.org; Mon, 04 May 2015 13:47:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YpKSK-0005QF-O2 for qemu-devel@nongnu.org; Mon, 04 May 2015 13:47:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34230) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpKSK-0005Q3-JU for qemu-devel@nongnu.org; Mon, 04 May 2015 13:47:00 -0400 From: Markus Armbruster References: <1430751937-17523-1-git-send-email-eblake@redhat.com> <1430751937-17523-29-git-send-email-eblake@redhat.com> Date: Mon, 04 May 2015 19:46:55 +0200 In-Reply-To: <1430751937-17523-29-git-send-email-eblake@redhat.com> (Eric Blake's message of "Mon, 4 May 2015 09:05:25 -0600") Message-ID: <87sibc44mo.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v8 28/40] qapi: Prefer 'struct' over 'type' in generator List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, berto@igalia.com, qemu-devel@nongnu.org Eric Blake writes: > Referring to "type" as both a meta-type (built-in, enum, union, > alternate, or struct) and a specific type (the name that the > schema uses for declaring structs) is confusing. The confusion > is only made worse by the fact that the generator mostly already > refers to struct even when dealing with expr['type']. This > commit changes the generator to consistently refer to it as > struct everywhere, plus a single back-compat tweak that allows > accepting the existing .json files as-is, so that the meat of > this change is separate from the mindless churn of that change. > > Fix the testsuite fallout for error messages that change, and > in some cases, become more legible. Improve comments to better > match our intentions where a struct (rather than any complex > type) is required. Note that in some cases, an error message > now refers to 'struct' while the schema still refers to 'type'; > that will be cleaned up in the later commit to the schema. > > Signed-off-by: Eric Blake Reviewed-by: Markus Armbruster