From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pat Thoyts Subject: Re: [PATCH] git-gui: sort entries in tclIndex Date: Fri, 01 May 2015 15:57:38 +0100 Message-ID: <87sibgpcpp.fsf@red.patthoyts.tk> References: <1422292043-12711-1-git-send-email-olaf@aepfle.de> <20150210151803.GB8965@aepfle.de> <20150415072251.GA18595@aepfle.de> <553BC05F.1070702@web.de> Reply-To: patthoyts@users.sourceforge.net Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Olaf Hering , git@vger.kernel.org To: =?iso-8859-1?Q?Ren=E9?= Scharfe X-From: git-owner@vger.kernel.org Fri May 01 16:57:49 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YoCNv-000671-Mj for gcvg-git-2@plane.gmane.org; Fri, 01 May 2015 16:57:48 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753830AbbEAO5n convert rfc822-to-quoted-printable (ORCPT ); Fri, 1 May 2015 10:57:43 -0400 Received: from know-smtprelay-omc-4.server.virginmedia.net ([80.0.253.68]:50769 "EHLO know-smtprelay-omc-4.server.virginmedia.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753764AbbEAO5m convert rfc822-to-8bit (ORCPT ); Fri, 1 May 2015 10:57:42 -0400 Received: from red.patthoyts.tk ([82.45.42.101]) by know-smtprelay-4-imp with bizsmtp id Nexg1q0062AxhvW01exgjS; Fri, 01 May 2015 15:57:40 +0100 X-Originating-IP: [82.45.42.101] X-Spam: 0 X-Authority: v=2.1 cv=S8BXwecP c=1 sm=1 tr=0 a=FEdcR8KTC/yDun0iFnNZnw==:117 a=FEdcR8KTC/yDun0iFnNZnw==:17 a=Rf460ibiAAAA:8 a=6gpmbu8EOFEA:10 a=8nJEP1OIZ-IA:10 a=xqWC_Br6kY4A:10 a=FP58Ms26AAAA:8 a=1oJP67jkp3AA:10 a=ZZnuYtJkoWoA:10 a=h1PgugrvaO0A:10 a=QOUmHT2YOf-4WCxZ8ZwA:9 a=UEZnLJIWFb4C8Wdic9J8r10ra3M=:19 a=wPNLvfGTeEIA:10 a=-FEs8UIgK8oA:10 a=NWVoK91CQyQA:10 Received: from red.patthoyts.tk (red.patthoyts.tk [IPv6:2a01:348:2be::2]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by red.patthoyts.tk (Postfix) with ESMTPS id 8BB781963238; Fri, 1 May 2015 15:57:39 +0100 (BST) X-Face: .`d#euqz@6H{";Ysmx2IVe_7M3vA+2w1X[QLk?ZO&QRauXQL{*L'$3getx}9+zK.-KWDx3. qrlR)76MFb`6bgoGvLpLtcQKB=X~;* (=?iso-8859-1?Q?=22Ren=E9?= Scharfe"'s message of "Sat, 25 Apr 2015 18:27:11 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Ren=E9 Scharfe writes: >Looping in Pat (git-gui maintainer). > >Am 15.04.2015 um 09:22 schrieb Olaf Hering: >> Ping? >> >> On Tue, Feb 10, Olaf Hering wrote: >> >>> Ping? >>> >>> On Mon, Jan 26, Olaf Hering wrote: >>> >>>> ALL_LIBFILES uses wildcard, which provides the result in directory >>>> order. This order depends on the underlying filesystem on the >>>> buildhost. To get reproducible builds it is required to sort such = list >>>> before using them. >>>> >>>> Signed-off-by: Olaf Hering >>>> --- >>>> git-gui/Makefile | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/git-gui/Makefile b/git-gui/Makefile >>>> index cde8b2e..7564a18 100644 >>>> --- a/git-gui/Makefile >>>> +++ b/git-gui/Makefile >>>> @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS >>>> rm -f $@ ; \ >>>> echo '# Autogenerated by git-gui Makefile' >$@ && \ >>>> echo >>$@ && \ >>>> - $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/= ,,$p)' >>$@ &&) \ >>>> + $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(su= bst lib/,,$p)' >>$@ &&) \ >>>> echo >>$@ ; \ >>>> fi >>>> > Applied. Thank you. --=20 Pat Thoyts http://www.patthoyts.tk/ PGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD