From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
QEMU Developers <qemu-devel@nongnu.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property
Date: Mon, 23 Mar 2015 14:43:48 +0100 [thread overview]
Message-ID: <87sicvltgr.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <551012D4.2070407@redhat.com> (Paolo Bonzini's message of "Mon, 23 Mar 2015 14:19:16 +0100")
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 23/03/2015 13:09, Peter Maydell wrote:
>> > The only alternative for 2.3 is reverting the patch for sdhci-pci. I
>> > certainly don't want "-drive if=sd -device sdhci-pci" to become ABI!
>>
>> What's wrong with that, incidentally? It's what I would have
>> expected for connecting an SD card to sdhci-pci, given
>> how the other SD controller devices work. (The only
>> difference with sdhci-pci is it happens to be a
>> pluggable device rather than hardwired into a board model.)
>
> Usually, "-drive if=" options (apart from if=none) are only handled at
> board creation time, and is not affected by -device. PCI devices use
> "-device sdhci-pci,drive=xyz" to tie themselves to a -drive option.
Yes.
In other words: realize() methods aren't supposed to go on fishing
expeditions for backends. They should rely on their backend properties.
The disgusting way we implement if=scsi should serve as deterrent, not
as example to emulate.
next prev parent reply other threads:[~2015-03-23 13:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-21 15:54 [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property Paolo Bonzini
2015-03-23 9:10 ` Markus Armbruster
2015-03-23 12:05 ` Paolo Bonzini
2015-03-23 12:09 ` Peter Maydell
2015-03-23 13:19 ` Paolo Bonzini
2015-03-23 13:43 ` Markus Armbruster [this message]
2015-03-23 13:35 ` Markus Armbruster
2015-03-23 13:56 ` Paolo Bonzini
2015-03-23 15:01 ` Peter Crosthwaite
2015-03-23 15:15 ` Peter Maydell
2015-03-23 15:58 ` Paolo Bonzini
2015-03-24 14:53 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sicvltgr.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.