From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Fri, 13 Mar 2015 16:14:46 +0200 Subject: [ath9k-devel] [PATCH] ath9k: Configure beacons for AP vif if this has not happened yet In-Reply-To: <1426253587-11397-1-git-send-email-benjamin@sipsolutions.net> (Benjamin Berg's message of "Fri, 13 Mar 2015 14:33:07 +0100") References: <1426253587-11397-1-git-send-email-benjamin@sipsolutions.net> Message-ID: <87sid9q90p.fsf@kamboji.qca.qualcomm.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Benjamin Berg writes: > Right now there is a bug where beaconing might not be enabled correctly > if the user has configuring multiple VIFs. > The issue surfaces if the userspace first creates the AP devices and > only then configures the first VIF (ath9k_bss_info_changed is called). > In this case the current ath9k_allow_beacon_config implementation will > not allow configuration as multiple AP VIFs are already present and > beaconing is never configured in the driver. > > This issue was probably introduced back in 2012 by commit ef4ad6336 > "ath9k: Cleanup beacon logic". The fix in this patch simply checks > whether beaconing has been configured yet (or configuration is scheduled) > and allows the configuration in that case. This works around the issue > here, but I have no idea whether it is a sane solution. > > Signed-off-by: Benjamin Berg Sorry, I guess I missed this the last time but ath9k patches need to be CCed to linux-wireless for wider review. -- Kalle Valo