From: Kalle Valo <kvalo@codeaurora.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Jim Davis <jim.epost@gmail.com>,
linux-next <linux-next@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
zajec5@gmail.com, linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: randconfig build error with next-20150303, in drivers/bcma/driver_pcie2.c
Date: Thu, 05 Mar 2015 15:44:56 +0200 [thread overview]
Message-ID: <87sidj4kyv.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20150305080130.41b132ee@canb.auug.org.au> (Stephen Rothwell's message of "Thu, 5 Mar 2015 08:01:30 +1100")
Stephen Rothwell <sfr@canb.auug.org.au> writes:
> Hi Kalle,
>
> On Wed, 04 Mar 2015 16:31:00 +0200 Kalle Valo <kvalo@codeaurora.org> wrote:
>>
>> Jim Davis <jim.epost@gmail.com> writes:
>>
>> > Building with the attached random configuration file,
>> >
>> > drivers/bcma/driver_pcie2.c: In function 'bcma_core_pcie2_up':
>> > drivers/bcma/driver_pcie2.c:196:2: error: implicit declaration of
>> > function 'pcie_set_readrq' [-Werror=implicit-function-declaration]
>> > err = pcie_set_readrq(dev, pcie2->reqsize);
>> > ^
>>
>> This should fix it:
>>
>> bcma: add missing includes
>>
>> https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=2264fc857decd45798368f46861d9aecac23546f
>
> However, that commit is in next-20150304 and we still get the error
> (see, for example,
> http://kisskb.ellerman.id.au/kisskb/buildresult/12376688/).
I applied few fixes from Rafal and Chen:
1ca2760fb2c1 bcma: prepare Kconfig symbol for PCI driver
0a4e699a41f7 bcma: move internal function declarations to private header
c32ec2a11321 bcma: make bcma_host_pci_(up|down) calls safe for every config
b09f5ec18b16 bcma: Kconfig: Let it depend on PCI
It would be great if someone could report if the build errors are gone
now.
--
Kalle Valo
next prev parent reply other threads:[~2015-03-05 13:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 16:11 randconfig build error with next-20150303, in drivers/bcma/driver_pcie2.c Jim Davis
2015-03-04 14:31 ` Kalle Valo
2015-03-04 21:01 ` Stephen Rothwell
2015-03-04 21:42 ` Rafał Miłecki
2015-03-05 13:44 ` Kalle Valo [this message]
2015-03-05 17:06 ` Jim Davis
2015-03-06 16:24 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sidj4kyv.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=jim.epost@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.