From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= Subject: Re: [PATCH v2] drm/i915: gen4: work around hang during hibernation Date: Mon, 02 Mar 2015 14:00:58 +0100 Message-ID: <87sidn8sfp.fsf@nemi.mork.no> References: <1425294281-7297-1-git-send-email-imre.deak@intel.com> <87385n60re.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <87385n60re.fsf@intel.com> (Jani Nikula's message of "Mon, 02 Mar 2015 14:29:25 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4gd3JpdGVzOgoKPiBPbiBNb24sIDAy IE1hciAyMDE1LCBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+IHdyb3RlOgo+PiBCasO4 cm4gcmVwb3J0ZWQgdGhhdCBoaXMgbWFjaGluZSBoYW5nIGR1cmluZyBoaWJlcm5hdGlvbiBhbmQg ZXZlbnR1YWxseQo+PiBiaXNlY3RlZCB0aGUgcHJvYmxlbSB0byB0aGUgZm9sbG93aW5nIGNvbW1p dDoKPj4KPj4gY29tbWl0IGRhMmJjMWI5ZGIzMzUxYWRkZDI5M2U1YjgyNzU3ZWZlMWY3N2VkMWQK Pj4gQXV0aG9yOiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cj4+IERhdGU6ICAgVGh1 IE9jdCAyMyAxOToyMzoyNiAyMDE0ICswMzAwCj4+Cj4+ICAgICBkcm0vaTkxNTogYWRkIHBvd2Vy b2ZmX2xhdGUgaGFuZGxlcgo+Pgo+PiBUaGUgcHJvYmxlbSBzZWVtcyB0byBiZSB0aGF0IGFmdGVy IHRoZSBrZXJuZWwgcHV0cyB0aGUgZGV2aWNlIGludG8gRDMKPj4gdGhlIEJJT1Mgc3RpbGwgdHJp ZXMgdG8gYWNjZXNzIGl0LCBvciBvdGhlcndpc2UgYXNzdW1lcyB0aGF0IGl0J3MgaW4gRDAuCj4+ IFRoaXMgaXMgY2xlYXJseSBib2d1cywgc2luY2UgQUNQSSBtYW5kYXRlcyB0aGF0IGRldmljZXMg YXJlIHB1dCBpbnRvIEQzCj4+IGJ5IHRoZSBPU1BNIGlmIHRoZXkgYXJlIG5vdCB3YWtlLXVwIHNv dXJjZXMuIEluIHRoZSBmdXR1cmUgd2Ugd2FudCB0bwo+PiB1bmlmeSBtb3JlIG9mIHRoZSBkcml2 ZXIncyBydW50aW1lIGFuZCBzeXN0ZW0gc3VzcGVuZCBwYXRocywgZm9yIGV4YW1wbGUKPj4gYnkg c2tpcHBpbmcgYWxsIHRoZSBzeXN0ZW0gc3VzcGVuZC9oaWJlcm5hdGlvbiBob29rcyBpZiB0aGUg ZGV2aWNlIGlzCj4+IHJ1bnRpbWUgc3VzcGVuZGVkIGFscmVhZHkuIEFjY29yZGluZ2x5IGZvciBh bGwgb3RoZXIgcGxhdGZvcm1zIHRoZSBnb2FsCj4+IGlzIHN0aWxsIHRvIHByb3Blcmx5IHBvd2Vy IGRvd24gdGhlIGRldmljZSBkdXJpbmcgaGliZXJuYXRpb24uCj4+Cj4+IHYyOgo+PiAtIEFub3Ro ZXIgR0VONCBMZW5vdm8gbGFwdG9wIGhhZCB0aGUgc2FtZSBpc3N1ZSwgd2hpbGUgcGxhdGZvcm1z IGZyb20KPj4gICBvdGhlciB2ZW5kb3JzIChpbmNsdWRpbmcgbW9iaWxlIGFuZCBkZXNrdG9wLCBH RU40IGFuZCBub24tR0VONCkgc2VlbQo+PiAgIHRvIHdvcmsgZmluZS4gQmFzZWQgb24gdGhpcyBh cHBseSB0aGUgd29ya2Fyb3VuZCBvbiBhbGwgR0VONCBMZW5vdm8KPj4gICBwbGF0Zm9ybXMuCj4+ IC0gYWRkIGNvZGUgY29tbWVudCBhYm91dCBmYWlsaW5nIHBsYXRmb3JtcyAoVmlsbGUpCj4+Cj4+ IFJlZmVyZW5jZTogaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9hcmNoaXZlcy9pbnRlbC1n ZngvMjAxNS1GZWJydWFyeS8wNjA2MzMuaHRtbAo+PiBSZXBvcnRlZC1hbmQtYmlzZWN0ZWQtYnk6 IEJqw7hybiBNb3JrIDxiam9ybkBtb3JrLm5vPgo+PiBTaWduZWQtb2ZmLWJ5OiBJbXJlIERlYWsg PGltcmUuZGVha0BpbnRlbC5jb20+Cj4KPiBCasO4cm4sIEkgd291bGQgcmVhbGx5IGFwcHJlY2lh dGUgeW91ciBUZXN0ZWQtYnkgb24gdGhpcyBwYXRjaCBiZWZvcmUgSQo+IHF1ZXVlIGl0IGZvciB2 NC4wIGFuZCBjYzogc3RhYmxlIGZvciB2My4xOS4KCk5vIHByb2JsZW0uIFRoaXMgdmVyc2lvbiBz dGlsbCB3b3JrcyBmaW5lIGZvciBtZS4gIEZlZWwgZnJlZSB0byBhZGQKClRlc3RlZC1ieTogQmrD uHJuIE1vcmsgPGJqb3JuQG1vcmsubm8+CgoKCkJqw7hybgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753933AbbCBNBQ (ORCPT ); Mon, 2 Mar 2015 08:01:16 -0500 Received: from canardo.mork.no ([148.122.252.1]:33211 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751117AbbCBNBN convert rfc822-to-8bit (ORCPT ); Mon, 2 Mar 2015 08:01:13 -0500 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Jani Nikula Cc: Imre Deak , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Ville =?utf-8?B?U3lyasOkbMOk?= , David Weinehall Subject: Re: [PATCH v2] drm/i915: gen4: work around hang during hibernation Organization: m References: <1425294281-7297-1-git-send-email-imre.deak@intel.com> <87385n60re.fsf@intel.com> Date: Mon, 02 Mar 2015 14:00:58 +0100 In-Reply-To: <87385n60re.fsf@intel.com> (Jani Nikula's message of "Mon, 02 Mar 2015 14:29:25 +0200") Message-ID: <87sidn8sfp.fsf@nemi.mork.no> User-Agent: Gnus/5.130011 (Ma Gnus v0.11) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.3.9 (canardo.mork.no [IPv6:2001:4641::1]); Mon, 02 Mar 2015 14:01:02 +0100 (CET) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jani Nikula writes: > On Mon, 02 Mar 2015, Imre Deak wrote: >> Bjørn reported that his machine hang during hibernation and eventually >> bisected the problem to the following commit: >> >> commit da2bc1b9db3351addd293e5b82757efe1f77ed1d >> Author: Imre Deak >> Date: Thu Oct 23 19:23:26 2014 +0300 >> >> drm/i915: add poweroff_late handler >> >> The problem seems to be that after the kernel puts the device into D3 >> the BIOS still tries to access it, or otherwise assumes that it's in D0. >> This is clearly bogus, since ACPI mandates that devices are put into D3 >> by the OSPM if they are not wake-up sources. In the future we want to >> unify more of the driver's runtime and system suspend paths, for example >> by skipping all the system suspend/hibernation hooks if the device is >> runtime suspended already. Accordingly for all other platforms the goal >> is still to properly power down the device during hibernation. >> >> v2: >> - Another GEN4 Lenovo laptop had the same issue, while platforms from >> other vendors (including mobile and desktop, GEN4 and non-GEN4) seem >> to work fine. Based on this apply the workaround on all GEN4 Lenovo >> platforms. >> - add code comment about failing platforms (Ville) >> >> Reference: http://lists.freedesktop.org/archives/intel-gfx/2015-February/060633.html >> Reported-and-bisected-by: Bjørn Mork >> Signed-off-by: Imre Deak > > Bjørn, I would really appreciate your Tested-by on this patch before I > queue it for v4.0 and cc: stable for v3.19. No problem. This version still works fine for me. Feel free to add Tested-by: Bjørn Mork Bjørn